geoffodonnell/dotnet-tinyman-sdk

Tinyman .NET SDK

dotnet-tinyman-sdk's Issues

Will there be dotnet core version?

Unless .NET actually means .NET core?

.NET 5 is the next major release of .NET Core following 3.1. We named this new release .NET 5 instead of .NET Core 4
https://docs.microsoft.com/en-us/dotnet/core/whats-new/dotnet-5

If not, wondering if it's easy to port over to core or if it's fairly simple to run dotnet in Linux. Thanks for all this!

Error while deserailzation

Looks like algorand api are no longer returning "creator" field for assets. This fields is required, so all tinyman api like GetBalance, FetchAssets are failing.

Possible MintQuote Bug - Checking both asset amounts are equal in case of new mint

In case the liquidity is 0, the code compares the input asset amounts instead of checking that they are non null values.

https://github.com/geoffodonnell/dotnet-tinyman-sdk/blob/main/src/Tinyman/V1/Model/PoolExtensions.cs#L183

// Pool exists does not contain assets
} else {

if (amount1 != amount2) {
	throw new Exception("Amounts required for both assets for first mint!");
}

liquidityAssetAmount = Convert.ToUInt64(
	Math.Sqrt((double)BigInteger.Multiply(amount1.Amount, amount2.Amount)) - 1000);
slippage = 0;
}

FetchAssetAsync uses FetchAssetFromApiAsync

Hi,

there is issue with FetchAssetAsync. The algod has dropped support for asa fetch from the api, and was transformed only for use by the indexer.

https://algoexplorer.io/api-dev/v2

if tinymanMainnetClient.FetchAssetAsync returns 403, it means your algod does not support it any longer.

i am afraid the only solution is to add the indexer to the library

Pool token unit name for V1_1 bootstrapping

The unit name for pool in bootstrapping is set to TM1POOL11 instead of TMPOOL11

if (validatorAppId == Constant.TestnetValidatorAppIdV1_0 ||
				validatorAppId == Constant.MainnetValidatorAppIdV1_0) {
				unitName = "TM1POOL";
				name = $"Tinyman Pool {asset1.UnitName}-{asset2.UnitName}";
			} else {
				unitName = "TM1POOL11";
				name = $"TinymanPool1.1 {asset1.UnitName}-{asset2.UnitName}";
			}

Python sdk - https://github.com/tinymanorg/tinyman-py-sdk/blob/v1-1-updates/tinyman/v1/bootstrap.py#L40

Bad Request - Malformed Algorand transaction

Every time I am running the swap example it throws "Bad Request - Malformed Algorand transaction".

Thank you in advance.