Giter Site home page Giter Site logo

Display filename in hash view about collision HOT 8 CLOSED

geopjr avatar geopjr commented on May 25, 2024
Display filename in hash view

from collision.

Comments (8)

GeopJr avatar GeopJr commented on May 25, 2024 1

It does look better, I'll add it after the rebrand is done, thanks!

hashbrown on the hash list view with a status page of "README.md" as title and the hash list box as a child

from collision.

melix99 avatar melix99 commented on May 25, 2024 1

Also notice that libadwaita now uses .title-1 for the title, which is a bit smaller and bolder, so it may already look better with that.

from collision.

GeopJr avatar GeopJr commented on May 25, 2024

Agreed, however I am not sure how to display it. Using the title is useless as on desktop mode the ViewSwitcher covers it.

(Quick mockups)
Infobar maybe?

hashbrown with infobar showing the filepath of the current file

Or perhaps a row in the hash list?

hashbrown on the hash list view with an additional row at the top of the list with the title "filepath" and a text entry with the path of the file

Also should it be full path or just the file name?

from collision.

melix99 avatar melix99 commented on May 25, 2024

I'd suggest using an AdwStatusPage with the filename (or path, I'm still unsure what's better) as the title and the listbox as its child.

from collision.

GeopJr avatar GeopJr commented on May 25, 2024

More testing:

Normal case + title

Hashbrown hashlist with a typical file name displayed as status page title on desktop

Hashbrown hashlist with a typical file name displayed as status page title on mobile

Normal case + description

Hashbrown hashlist with a typical file name displayed as status page description on desktop

Hashbrown hashlist with a typical file name displayed as status page description on mobile

Extreme case + title

Hashbrown hashlist with a typical file name displayed as status page title on desktop

Hashbrown hashlist with a typical file name displayed as status page title on mobile

Extreme case + description

Hashbrown hashlist with a typical file name displayed as status page description on desktop

Hashbrown hashlist with a typical file name displayed as status page description on mobile

Extreme cases + titles are a bit too much, perhaps after a certain amount of characters I should add ellipsis or use description instead of text.

cc: @bertob

from collision.

bertob avatar bertob commented on May 25, 2024

I agree that using a status page title makes the most sense here. Perhaps the path could even be displayed below the name as the status page description?

from collision.

GeopJr avatar GeopJr commented on May 25, 2024

(Note: .title-1 manually applied (on host) for the screenshots due to this bug)

hashbrown mobile view on hash list with status page with filename as its title and filepath as its description
hashbrown desktop view on hash list with status page with filename as its title and filepath as its description

from collision.

bertob avatar bertob commented on May 25, 2024

Looking good!

from collision.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.