georgysk/alcor

Kinematical studies of white dwarfs populations

alcor's Issues

Needless addition of main sequence life times when interpolating/extrapolating by cooling time

All over the interpolating/extrapolating subroutines you can see that in some cases we add pre-white-dwarf times = main sequence life times. E.g.:
https://github.com/wolvespack/alcor/blob/dcc6b029ab7e6eb96b65b7b996cf335c3b030649/test_project/code/magnitudes/interp.f#L58-L59
But there is no need to do that as those times are already taken into account when reading the files. E.g.:
https://github.com/wolvespack/alcor/blob/dcc6b029ab7e6eb96b65b7b996cf335c3b030649/test_project/code/cooling/DA/DA_cooling.f#L117-L118

Wrong mass indexes in `intermag`

For the case of extrapolating by mass to the highest values
https://github.com/wolvespack/alcor/blob/dcc6b029ab7e6eb96b65b7b996cf335c3b030649/test_project/code/magnitudes/DA/intermag.f#L242
and extrapolating by luminosities to the lowest values
https://github.com/wolvespack/alcor/blob/dcc6b029ab7e6eb96b65b7b996cf335c3b030649/test_project/code/magnitudes/DA/intermag.f#L329-L330
mass indexes are wrong. E.g.:
https://github.com/wolvespack/alcor/blob/dcc6b029ab7e6eb96b65b7b996cf335c3b030649/test_project/code/magnitudes/DA/intermag.f#L340
They should be replaced with the ones as, for example, here:
https://github.com/wolvespack/alcor/blob/dcc6b029ab7e6eb96b65b7b996cf335c3b030649/test_project/code/magnitudes/DA/intermag.f#L321-L322
Edit: I noticed later that right under this case, there are wrong indexes for interpolating by luminosity as well. E.g.:
https://github.com/wolvespack/alcor/blob/dcc6b029ab7e6eb96b65b7b996cf335c3b030649/test_project/code/magnitudes/DA/intermag.f#L426-L427