Office funds generation too fast when focused

[ger-space]

Office funds generation too fast when focused

[xilexio]

I had a look at the code and I think there must be a problem in this general area:

Kerbal-Konstructs/src/Facilities/ProductionGUI.cs

Lines 156 to 175 in 1e87ef0

	if ((float)dTime - fLastCheck > 43200)
	{
	float fDays = (((float)dTime - fLastCheck) / 43200);
	float fProduced = fDays * fProductionRate;
	fCurrent = fCurrent + fProduced;
	if (fCurrent > fMax) fCurrent = fMax;
	if (sFacilityType == "Research")
	{
	myResearch.ScienceOCurrent = fCurrent;
	}
	if (sFacilityType == "Business")
	{
	myBusiness.FundsOCurrent = fCurrent;
	}
	facField.GetField("LastCheck").SetValue(selectedFacility.myFacilities[0], (float)dTime);
	}

I think there is a bug with time being incorrectly counted when the updates happen too fast. I was expecting something like rounding errors that lead to adding ceil(small float number), but it seems floats are being used. The updating code in the if in L156 looks okay to me though, I'd have to actually compile it to be sure.

[xilexio]

Actually, how about never updating it, just saving the time when the funds were taken last time and just displaying a computed min(maxFunds, days * ratio) every time? That way, the intermediate state would never be there, and you'd only have to store a single value - the time of last withdrawal. That would remove any bug connected to updating funds too often instead of computing them and updating at the point of withdrawal only.

[GER-Space]

The main problem was. that I pulled the productionrate and set it to the last-check time. And I did it every frame... that why you got the insane amounts of credits and research.

[GER-Space]

ok, the Code is really a mess. I never really looked into it. I always only made it compile... this time I'm fixing it for real and I will give it reasonable numbers for the investment.

[GER-Space]

fixed with commit 3fbdf96