gesman/bitcoin-payments-for-woocommerce

Bitcoin Payments for WooCommerce is a Wordpress plugin that allows you to accept payments in bitcoins for physical and digital products at your WooCommerce-powered online store.

bitcoin-payments-for-woocommerce's Issues

bwwc-cron.php (hardcron) always generates a new electrum address

This cron script generates electrum addresses well past the max count when the hardcron setting is enabled. My wp_bwwc_btc_addresses had 300+ addresses after a day when I setup the cron to be run every 5 minutes. The culprit seems to be this query:

      // NULL == not found
      // Retrieve:
      //     'unused'   - with fresh zero balances
      //     'assigned' - expired, with fresh zero balances (if 'reuse_expired_addresses' is true)
      //
      // Hence - any returned address will be clean to use.
      $query =
        "SELECT COUNT(*) as `total_unused_addresses` FROM `$btc_addresses_table_name`
           WHERE `origin_id`='$origin_id'
           AND `total_received_funds`='0'
           AND (('$current_time' - `received_funds_checked_at`) < '$funds_received_value_expires_in_secs')
           AND (`status`='unused' $reuse_expired_addresses_query_part)
           ";

Specifically this where clause statement:

AND (('$current_time' - `received_funds_checked_at`) < '$funds_received_value_expires_in_secs')

Since the received_funds_checked_at field never gets updated for unused addresses after they're generated, the query doesn't count them, so a new address gets generated on each run.

Does not work with proxy

Configuring wordpress so that outbound connections are only possible through a proxy, with the proxy defined in wp-config.php, breaks this plugin. It ignores the proxy setting in wordpress, and attempts to connect to blockchain.info/blockexplorer.com/bitcoinway.com directly. At least those are the ones I found after digging through the code so I could make custom firewall rules to allow the traffic.

unpaid orders are not automatically cancelled

Woocommerce uses a woocommerce_cancel_unpaid_orders scheduled task for this, but it only applies to orders with status = 'pending', not 'on-hold' (which is the status assigned to new bitcoin orders).

Apparently the 'on-hold' status is supposed to represent an order that has not been paid and requires manual admin interaction (like a check payment).

See 36e4294 for fix.

function BWWC__get_bitcoin_address_for_payment__electrum doesn't retrieve unused addresses

The initial query uses a received_funds_checked_at constraint that won't match most unused addresses. Similar to pull request #3.

See 1ade4cb for fix.

Not using Nonces and/or checking permissions

add a nonce to POST calls to prevent unauthorized access.

Relying on nonces for authorization purposes is a security issue. Use current_user_can() in order to prevent users without the right permissions from accessing things.

checkout to the thankyou page skipping the QR code pagr

I don't know why exactly, but after selecting bitcoin as payment method, and proceeding my woocommerce bring me directly to the thankyou page skipping the QR code page.

url on the thankyou page is: domain.com/checkout/order-received/6526/?key=wc_order_536aa78e4954f&order=6526

I don't have any error, I already tried to re-install the plugin

thanks for any help

Updating Logo

possible updating BCH Logo

Exchange rate calculation type

Exchange rate calculation type: Mtgox

Error coming in bitcoin-payments-for-woocommerce

`Hello Gesman,

I have some question regarding for bitcoin-payment-for woocommerce.

I have download the bitcoin-payment-for woocommerce plugin code for github and install to my wordpress.

After that fill all the detail as requirement as you see in screenshot

After that when we click on the place order button in check out page than

error message is showing.. (As you see in screen shot)

So Please help me to solve this error.

Thanks , `