Giter Site home page Giter Site logo

magento-v2-bread's People

Contributors

aleksa-andersinnovation avatar alexnick173 avatar alexxss1986 avatar dfroneberger avatar dksimon avatar fkhan-bread avatar jelenaandersinnovations avatar jenlesamuel avatar kiprotichmaritim avatar mirandajohnson avatar nenadstojic avatar omgitsdev avatar weigao10 avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

magento-v2-bread's Issues

Didn't Clean Minicart Items

Hi Bread Team
I got a problem with bread after enabled Catalog Product View button, After redirect to checkout/success page but the mini cart didn't clean

screenshot-2019 11 11-18_01_34

Thanks
Hidro Le

Didn't Clean Minicart Items

Hi Bread Team
I got a problem with bread after enabled Catalog Product View button, After redirect to checkout/success page but the mini cart didn't clean.
screenshot-2019 11 11-18_01_34

Thanks
Hidro Le

Error handling in API Client.php doesn't cover curl failures

Model/Payment/Api/Client.php line 277 includes references to $status, and $result which are defined only in the try block. This causes an error within the catch block if garbage data is thrown at the curl call by using invalid characters in the username or password. The catch block does not cover an error with the curl call itself, thereby preventing the bubbling of the root cause of a failure because PHP errors on the undefined variables before the original exception is passed on again at line 285.

Deprecated Functionality: preg_replace() with PHP8.1

We are getting the following error and can see that the code is still the same.

Exception: Deprecated Functionality: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /app/pjs6hecc2k6im/vendor/breadfinance/module-breadcheckout/Helper/Quote.php on line 271 in /app/pjs6hecc2k6im/vendor/magento/framework/App/ErrorHandler.php:61

Also, "preg_replace" is being used in other several places of the module.
image

Broken fetch polyfill method in IE11

I'm struggling with the problem on Internet Explorer 11. Does your module support it?

Issue Details:
Fetch polyfill is broken in your core-js lib and it's very hard to fix that, b/c this script is runned on your side in an iframe.
Zrzut ekranu 2019-07-12 o 13 04 15

After adding debugger - breadPromise, and breadFetch is undefined.
Zrzut ekranu 2019-07-12 o 13 06 04

Error when upgrading from 2.3.2 to 2.3.5

Hi,

I'm having an error when running "setup:upgrade" locally after upgrade from 2.3.2 to 2.3.5:

Unable to apply data patch Bread\BreadCheckout\Setup\Patch\Data\CopyApiCredentials for module Bread_BreadCheckout. Original exception message: Warning: Undefined array key "value" in /var/www/html/juram2/app/code/Bread/BreadCheckout/Setup/Patch/Data/CopyApiCredentials.php on line 64

Thanks,
Victor.

getAllowCheckout() undefined

allowCheckout: false is hardcoded on product list grid view, it should be extended with getAllowCheckout() method like in product-view.

Admin Panel view
test

broken script if bread checkout is undefined

For some reason if bread object isn't created then our app will be broken and stop. So it's necessary to wrap bread.checkout(breadConfig) as a condition

if (typeof bread !== 'undefined') { 
  bread.checkout(breadConfig);
}

Not working with PHP 8.1

Hi Bread team,

I got some errors when upgrade my PHP to 8.1. Most of them are passing null to parameter of strtotime(), preg_replace(), explode(). Could you verify all the code and make sure it's compatible with PHP 8.1?

PHP 7.4 and Magento 2.4 Support

Team,

PHP 7.4 and Magento 2.4 have been released for quite some time, the lack of support blocks our customer from upgrading to the latest version which also affects security compliance. Can you please update the module to support 2.4 Magento and PHP 7.4?

send request once on product-list

There's any way to do that with your API? I didn't find any solution, but I want to send request once instead multiple times on product list/grid page (performence)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.