getkirby / layouts Goto Github PK

View Code? Open in Web Editor NEW

43.0 43.0 2.0 19 KB

Extend Kirby’s templates with a powerful layout system

License: MIT License

PHP 100.00%

layouts's People

Contributors

Stargazers

Watchers

Forkers

8grad modufolio

layouts's Issues

Breaks `$page->render()`

I've been preparing an error issue for the Kirby Static Site Generator not working if layouts are used, but looking closely at the problem, it seems there's something weird happening with the render() function when the layouts plugin is used.

If I call $page('error')->render() with the layouts plugin on, the $page refers to the error (correct) page in the layout, but refers to the last rendered / first requested page (see edit) in the template itself.

You can see the problem in the kirby/ssg/layouts demo repo build files:

result of page('error')->render():

<!DOCTYPE html>
<html class="no-js">

<head>
	<meta charset="UTF-8">
	<meta name="viewport" content="width=device-width">

	<title>Error • Site Title</title>
	<script type="module">
		document.documentElement.classList.remove('no-js');
		document.documentElement.classList.add('js');
	</script>

	<link rel="icon" href="/favicon.png">
	<link rel="icon" href="/favicon.svg" type="image/svg+xml">
</head>

<body class="antialiased dark:bg-gray-900 dark:text-white">

<h1>Home</h1>

</body>
</html>

Edit:

Order matters. templates get whatever page called 'render' first.

// generates `<h1>Error</h1>` in the template body
page('error')->render();

// generates `<h1>Home</h1>` in the template body of both
page('home')->render(); page('error')->render();

// generates `<h1>Error</h1>` in the template body of both
page('error')->render(); page('home')->render();

Global layout data not working

I tried to pass some data to the layout method, but I get "Undefined variable" error every time.

My template:
/site/templates/default.php

<?php layout("default", ["title" => "Some title"]) ?>

<p>Some content...</p>

Layout:
/site/layouts/default.php

<?= $title ?>

<?php slot() ?>
<?php endslot() ?>

Latest version of Kirby Plainkit, no other plugins installed.

Add ability to define layouts in plugins

Would love to have the ability to register layouts via a plugin instead of having to have inside of the site/layouts folder.

Any Plugin Index.php

'layouts'     => [
    'default' => __DIR__ . '/layouts/default.php',
    'blog' => __DIR__ . '/layouts/blog.php',
    …
],

Nesting `slot()`s

Hey there,
I would like to nest slots - take the following scenario:

<?php slot('content') ?>
<section class="container">
    <?php slot() ?>
    some default content
    <?php endslot() ?>
</section>
<?php endslot() ?>

Most of the time, my templates would use slot(), drop some content, maybe echo $page->myfield()->toBlocks() etc but some templates would need to remove the container element and do something completely different. IMHO nesting slots would make this way more DRY, wouldn't it?

Thanks for considering this and have a good day,
S1SYPHOS

Breaks pages cache

If i use layouts and slots the pages cache is no longer created.

If i return a string here instead of Tpl::load it works and cache files are created.
Layout Class

static public function render(array $data = []): string
    {
        Slots::render();
        return Tpl::load(kirby()->root('site') . '/layouts/' . static::$name . '.php', array_merge(Layout::$data ?? [], $data));
    }

'cache' => [
    'pages' => [
      'active' => true
    ]
  ]

$page->isCacheable() returns true.
kirby()->cache('pages')->set('a.html', 'test'); creates a file so not a permission error.

osx valet, kirby 3.6.6

getkirby / layouts Goto Github PK

layouts's People

Contributors

Stargazers

Watchers

Forkers

layouts's Issues

Breaks `$page->render()`

Global layout data not working

Add ability to define layouts in plugins

Any Plugin Index.php

Nesting `slot()`s

Breaks pages cache

Cannot install on PHP 8.2 with composer

Layout extending Layout

Minimum required PHP version

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent