getletterpress/athens

Simple AWS Athena queries

athens's Issues

Unsupported type string

If you run a SHOW TABLES query against athena, you'll get string column values in the result. These give you the curious error:

WARNING: Unsupported type: string, defaulting to string

Just need to add string to the list here:

athens/lib/athens/query.rb

Line 154 in fa30f46

when 'varchar'

Error: IncompleteSignatureException

Thanks for all the work here.

Getting an error when attempting to run a query. Almost certainly my bad, but any assistance very much appreciated!

Dependencies:

aws-sdk-core (3.121.2)
aws-sdk-athena (1.42.0)
athens (0.4.0)

I can't go higher on the aws sdk's due to platform dependencies.

Config in initializer:

  Athens.configure do |config|
    config.output_location = "s3://my-bucket/my-folder/athena/results/",
    config.aws_access_key      = s3_access_key_id,
    config.aws_secret_key      = s3_secret_access_key,
    #config.aws_profile         = 'myprofile'  # Optional - I have this commented out for time being
    config.aws_region          = s3_region,
    config.wait_polling_period = 0.25
    config.result_encryption   = nil
  end

Rails console responses:

[3] pry(main)> conn = Athens::Connection.new(database: 'addresses')
=> #<Athens::Connection:0x0000558021402378 @client=#<Aws::Athena::Client>, @database_name="addresses">
[4] pry(main)> query = conn.execute("SELECT * FROM addresses")
Aws::Athena::Errors::IncompleteSignatureException: '"rH------------------------D1"' not a valid key=value pair (missing equal-sign) in Authorization header: 'AWS4-HMAC-SHA256 Credential=["A-------------------Q", "rH--------------------D1", "eu-west-2", 0.25]/20220317/eu-west-2/athena/aws4_request, SignedHeaders=content-type;host;x-amz-content-sha256;x-amz-date;x-amz-target, Signature=f0--------------------------------------------8b'.
from /home/merefield/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/aws-sdk-core-3.121.2/lib/seahorse/client/plugins/raise_response_errors.rb:17:in `call'

FYI due to unrelated exports to S3 using these credentials, I know the keys are correct.

AWS dependencies are too old

The AWS dependencies listed in them gemspec are too old and blocks the upgrade of other dependencies in the application.

Please consider upgrade the dependencies while bumping the version of this gem.

Could not find compatible versions

Because aws-sdk-states >= 1.64.0 depends on aws-sdk-core >= 3.191.0, < 4.A
  and athens >= 0.4.1 depends on aws-sdk-core ~> 3.131.1,
  aws-sdk-states >= 1.64.0 is incompatible with athens >= 0.4.1.
So, because Gemfile depends on athens >= 0.4.1, < 0.5.A
  and Gemfile depends on aws-sdk-states ~> 1.64,
  version solving has failed.

This is the error I get when trying to upgrade aws-sdk-states to a newer version in my application, which also uses athens

Add ability to specify encryption_option

Currently it is hard coded to SSE_S3—give configuration option to set it to nil and thus not encrypt.

Verbose Logging Suddenly Enabled

Hello!

I've recently ran into an issue with Verbose logging suddenly being enabled resulting in a ton of log garage:

[Aws::Athena::Client 200 0.234237 0 retries] get_query_results(query_execution_id:"37c11c47-3b64-4e13-9b7b-6a959bab1906",next_token:"AVi4dF...")  
[Aws::Athena::Client 200 0.173789 0 retries] get_query_results(query_execution_id:"37c11c47-3b64-4e13-9b7b-6a959bab1906",next_token:"AVi4dFwtW1m...")  
[Aws::Athena::Client 200 0.14255 0 retries] get_query_results(query_execution_id:"37c11c47-3b64-4e13-9b7b-6a959bab1906",next_token:"AVi4dFwtW1...")  
[Aws::Athena::Client 200 0.223625 0 retries] get_query_results(query_execution_id:"37c11c47-3b64-4e13-9b7b-6a959bab1906",next_token:"AVi4dFwt...")  

I've looked through the Athena client docs (https://docs.aws.amazon.com/sdk-for-ruby/v2/api/Aws/Athena/Client.html) and see that passing in either logger: nil or a log level should disable this. I've tried that as follows:

    @athena = Athens::Connection.new(database: 'database', aws_client_override: { logger: nil, log_level: :warn })

This hasn't had any impact.

Curious if you've seen anything like it? Otherwise I'll keep looking.

-- Jesse