The characterstatsclassic from getov

Holy Paladin spell crit chance

Holy Palas have additional 5% spell crit chance by talent Holy Power, but that not shown in addon.

MP5 not taken into consideration for MP5

Mana-regen seems to ignore whatever you get from MP5 items.

Feature request: Show one decimal in Mana Regen (While Not Casting)

Addon's code floors mp5 gained from spirit. Please remove flooring and let already existing number formating show one decimal.
Actual regen in the game does not do flooring for mana gains from spirit.

Weapon skill formulas are wrong

There are a few issues with the implementation of weapon skill formulas.

Weapon skill doesn't give you bonus hit chance; it reduces your miss chance and, depending on the skill/defense delta, makes you ignore the 1% penalty to +hit from gear/talents/buffs vs. +3 mobs. This is an important distinction as the reduced miss chance varies by the skill/defense delta and target type (NPC vs. player) and is used as the base miss chance to calculate the dual-wield miss penalty. It also means you can't just add the weapon skill difference to the hit bonus.

Additionally, the formulas used in the addon to calculate miss chance are wrong; see https://github.com/magey/classic-warrior/wiki/Attack-table for full details.

My suggestion is to remove the current functionality and add miss chances vs. various types of mobs and players in the tooltip that shows when you hover over 'Hit Chance'. You should also clarify that +hit bonus from gear/talents/buffs doesn't actually increase your chance to hit - what it does is reduce your chance to miss; again, an important distinction as it basically converts Miss entries in the attack table to Hit entries. You can optionally also include the dual-wield miss chance. Example tooltip could be something like this:

+Hit Chance: 6%
Reduces your chance to miss.

Miss chance vs.
    Level 60 NPC: xx.x% (xx.x% dual wield)
    Level 60 Player: xx.x% (xx.x% dual wield)
    Level 63 NPC/Boss: xx.x% (xx.x% dual wield)

If you need any clarifications or assistance feel free to contact me on the Fight Club discord.

Request: Expected DPS

Right now this is showing DPS from weapon and attack power only. But the expected DPS includes crit.

It would make it easier to compare gear with expected DPS calculated by EXPECTED = (1+ CRIT)*DPS

Allow access of frame from other addons

I'm trying to move the CSC UI Frame, but I can't access it from a different addon.
Is there a way to deal with this?

MP5 on Epiphany buff (8p T3 priest bonus) missing

Hi,

Thanks for the work on this addon!

However, it seems that the Epiphany buff from the 8p T3 priest set is not taken into account.

Could it be possible to add such feature?

Critical cap ignores dodge reduction from weapon skill

Current critical strike cap is calculating with static 6.5% dodge chance, but this value can be reduced via weapon skill. (reduction by 0.1% per 1 point of difference)

Getting an error on the Classic PTR

Time: Tue Jun 16 12:42:58 2020
Count: 1
Stack: ...CharacterStatsClassic\CharacterStatsClassicUtils.lua:304: Division by zero
...CharacterStatsClassic\CharacterStatsClassicUtils.lua:304: in function `CSC_PaperDollFrame_SetDamage'
...ns\CharacterStatsClassic\CharacterStatsClassicUI.lua:84: in function `SetCharacterStats'
...ns\CharacterStatsClassic\CharacterStatsClassicUI.lua:123: in function `UpdateStats'
...ns\CharacterStatsClassic\CharacterStatsClassicUI.lua:118: in function `CreateMenu'
...ns\CharacterStatsClassic\CharacterStatsClassicUI.lua:237: in function <...ns\CharacterStatsClassic\CharacterStatsClassicUI.lua:221>

Locals: statFrame = <unnamed> {
 0 = <userdata>
 OnEnterCallback = <function> defined *:OnEnter:1
 Label = <unnamed> {
 }
 Value = <unnamed> {
 }
 Background = <unnamed> {
 }
}
unit = "player"
category = "Melee"
speed = 0
offhandSpeed = nil
minDamage = 0
maxDamage = 0
minOffHandDamage = 0
maxOffHandDamage = 0
physicalBonusPos = 0
physicalBonusNeg = 0
percent = 0
displayMin = 1
displayMax = 1
(*temporary) = 0
(*temporary) = 1
(*temporary) = 1
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "Division by zero"
CSC_PaperDollFrame_SetLabelAndText = <function> defined @Interface\AddOns\CharacterStatsClassic\CharacterStatsClassicUtils.lua:58
CSC_GetAppropriateAttackSpeed = <function> defined @Interface\AddOns\CharacterStatsClassic\CharacterStatsClassicUtils.lua:35
CSC_GetAppropriateDamage = <function> defined @Interface\AddOns\CharacterStatsClassic\CharacterStatsClassicUtils.lua:26
CSC_GetAppropriateAttackRaiting = <function> defined @Interface\AddOns\CharacterStatsClassic\CharacterStatsClassicUtils.lua:44
Message: ...CharacterStatsClassic\CharacterStatsClassicUtils.lua:304: Division by zero
Time: Tue Jun 16 12:43:17 2020
Count: 1
Stack: ...CharacterStatsClassic\CharacterStatsClassicUtils.lua:304: Division by zero
...\CharacterStatsClassic\CharacterStatsClassicCore.lua:22: in function <...\CharacterStatsClassic\CharacterStatsClassicCore.lua:21>

Locals: self = <unnamed> {
 0 = <userdata>
}
event = "UNIT_MODEL_CHANGED"
core = <table> {
 UIConfig = <table> {
 }
}```

Hit chance doesn't take player level into account.

Change Line 1015 to 1017 to:

	GameTooltip:AddDoubleLine(format("    Level %s NPC: %.2F%%", UnitLevel("Player"), missChanceVsNPC), format("(Dual wield: %.2F%%)", dwMissChanceVsNpc));
	GameTooltip:AddDoubleLine(format("    Level %s Player: %.2F%%", UnitLevel("Player"), missChanceVsPlayer), format("(Dual wield: %.2F%%)", dwMissChanceVsPlayer));
	GameTooltip:AddDoubleLine(format("    Level %s NPC/Boss: %.2F%%", UnitLevel("Player") + 3, missChanceVsBoss), format("(Dual wield: %.2F%%)", dwMissChanceVsBoss));```

lua error

1x [ADDON_ACTION_BLOCKED] AddOn 'CharacterStatsClassic' tried to call the protected function 'CompactRaidFrame20:Show()'.
!BugGrabber\BugGrabber.lua:519: in function <!BugGrabber\BugGrabber.lua:519>
[C]: in function Show' FrameXML\CompactUnitFrame.lua:353: in function CompactUnitFrame_UpdateVisible'
FrameXML\CompactUnitFrame.lua:286: in function <FrameXML\CompactUnitFrame.lua:284>
[C]: in function `CompactUnitFrame_UpdateAll'
FrameXML\CompactUnitFrame.lua:185: in function <FrameXML\CompactUnitFrame.lua:185>

Locals:
Skipped (In Encounter)

Values from ZG enchants

Values from ZG enchants are missing on stats that are not retrieved using the api but calculated by ourself.

Cases Im aware are:

Warrior Blockvalue (if api is disabled)
Priest MP5
#35 #45

Since these enchants will always be relevant I would like to get this fixed.
I will try to come up with something to detect the enchant and add those values.
Assuming your approval.

Lua Error 1

I got this at every login:

Message: ...CharacterStatsClassic\CharacterStatsClassicUtils.lua:303: Division by zero
Time: Sat Feb 29 19:36:50 2020
Count: 1
Stack: ...CharacterStatsClassic\CharacterStatsClassicUtils.lua:303: Division by zero
...CharacterStatsClassic\CharacterStatsClassicUtils.lua:303: in function CSC_PaperDollFrame_SetDamage' ...ns\CharacterStatsClassic\CharacterStatsClassicUI.lua:84: in function SetCharacterStats'
...ns\CharacterStatsClassic\CharacterStatsClassicUI.lua:123: in function UpdateStats' ...ns\CharacterStatsClassic\CharacterStatsClassicUI.lua:118: in function CreateMenu'
...ns\CharacterStatsClassic\CharacterStatsClassicUI.lua:237: in function <...ns\CharacterStatsClassic\CharacterStatsClassicUI.lua:221>

Locals: statFrame = {
0 =
OnEnterCallback = defined *:OnEnter:1
Label = {
}
Value = {
}
Background = {
}
}
unit = "player"
category = "Melee"
speed = 0
offhandSpeed = nil
minDamage = 0
maxDamage = 0
minOffHandDamage = 0
maxOffHandDamage = 0
physicalBonusPos = 0
physicalBonusNeg = 0
percent = 0
displayMin = 1
displayMax = 1
(*temporary) = 0
(*temporary) = 1
(*temporary) = 1
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "Division by zero"
CSC_PaperDollFrame_SetLabelAndText = defined @interface\AddOns\CharacterStatsClassic\CharacterStatsClassicUtils.lua:59
CSC_GetAppropriateAttackSpeed = defined @interface\AddOns\CharacterStatsClassic\CharacterStatsClassicUtils.lua:36
CSC_GetAppropriateDamage = defined @interface\AddOns\CharacterStatsClassic\CharacterStatsClassicUtils.lua:27
CSC_GetAppropriateAttackRaiting = defined @interface\AddOns\CharacterStatsClassic\CharacterStatsClassicUtils.lua:45

Rogue Miss

Melee Rogue does not show the chance of a miss

Hunter Critical Strike

I believe something is amiss with your calculations of Hunter Critical Strike in the Ranged pane. I a modestly geared Hunter, and everything has seemed to be fine with your addon with my Hunter and several other of my characters. However, I recently picked up Mandokir's Sting from ZG, as a considered replacement for Blastershot Launcher on my Hunter.

Skipping to the details, when naked (NOTHING else equipped, no buffs, no quiver or ammo pouch) I equip my Blastershot launcher and my Critical Strike is calculated at 8.46%. I have 5% from talents (Lethal Shots, that isn't added in until a ranged weapon isn't equipped), but the weapon only provides 1% critical strike chance, not 3.46%. So I would expect this to be 6%.

Meanwhile, Mandokir's Sting has +11 Agility, which I would expect to translate to some small amount of Critical Strike chance (roughly 0.4% (rounded up to the nearest tenth of a percent) if 29 Agility is equal to 1% Critical Strike chance). Again, with NOTHING else equipped, your addon shows only 5% Critical Strike in the Ranged pane. I would expect this to read approximately 5.4%.

Unless there are some hidden attributes of each weapon that affects things, I'm very confused since removing your addon still shows some oddities with these weapons in particular. I'll have to find some other ranged weapons to further test.

[Bug] Priest spritiual healing has no effect on +heal, should be removed from calculation

Observation

Since the last commit, spiritual healing is added to the total +spell healing in the character sheet calculation for priests

Expectation

Spiritual healing should have no influence on +spell healing

Explanation

Spiritual healing only increases base heal of healing spells. All +heal bonus from equip is ignored and irrelevant for this talent. This can be easily tested by using any healing spell (renew works best) and calculating the added +heal to the base spell values. The current 1.1 modifier to spell healing due to spiritual healing in commit eb60fe0 is wrong.

Example

Spiritual healing is skilled 5/5 and no improved renew

Renew Rank 3 should heal 195 after all talents (https://classic.wowhead.com/spell=6075/renew base spell only heals 175)

Each renew tick of rank 3 ticks for 244, so 1220 in total

This is the +heal value shown with the most recent commit.

If we subtract the base heal of 195 from the total renew (100% coefficient), we get 1025 +heal. This is the original, correct value. The new calculation since commit eb60fe0 multiplies this value by 1.1 and arrives at a wrong value of 1129.7 (which is also wrong due to rounding errors, but this is another floating point problem that classic has everywhere).

Character planner link with equip (without spirit buff, which would add ~10 +heal for a total of 1026) https://classic.wowhead.com/gear-planner/priest/undead/AjwQUAIxEwUAHyBRUQMDAAVf8IFCGV5nAlQDg02BX2SFQhs2dQZNgodLuV5niEvtNkKJQh5c-opCGGH3C0rEDFLaDUtYDkvDD0hOkFOiWN4RS3ASVSk

Final fix for blockvalue detection

Hey @getov, after testing your latest update I have to tell you that the blockvalue is still not correct.

However, its easy to fix, so easy that I will describe it here instead of opening a PR.

If a might item is detected the counter is increased at each line of the tooltip a break; after line 772 would prevent this.
The bonus is only added if there are exactly 3 pieces of might present maybe a >= would do better in line 801.

Im glad you finally got this working, thanks.

[enhancement] add spell hit from talents

add spell hit from talents like Elemental Precision or Suppression

Feral weapon skill calculation in miss chance

It looks like the miss chance calculation does not take into consideration whether or not I am in forms.

When a feral druid is in forms, all weapon skills are considered maxed (level * 5), regardless of what their actual weapon skills are. The reason for this is that they aren't technically holding any weapons in forms, and their skill with feral attacking is always maxed (like languages).

I noticed that in equipping the Big Iron Fishing Pole, which is a weapon-type Fishing Pole (similarly always considered maxed), the miss formula appears to work. So maybe you can add the feral forms exception to this when class is druid and form is not form:0.

Characters stats bugged

as showed on the SC, the addon is bugged, it is both showing add, and not removing std, stat shower

MP5 from Enchant Bracer - Mana Regeneration not counted

MP5 from Enchant Bracer - Mana Regeneration is not added to Mana Regen. Neither to MP5 from gear or other mana regen values.

Gear in Gear Planner:
https://classic.wowhead.com/gear-planner/mage/gnome/AjwAiUGfXPk

Gear:

MP5 stats:

Mp5 on Resilience of the Scourge Enchant Issue

5 Mp5 on Resilience of the Scourge Enchant on shoulders is not showing up

Priest Holy Spec talent not reflected in pane

Holy crit chance should be 4% higher based on my talents.

priest crit chance and other minor bugs

according to warcraftlogs, this formula should better describe my critchance:
https://wowwiki.fandom.com/wiki/Spell_critical_strike
1.24 + Int/59.2 + BonusCrit

it doesn't count the 2% holy crit chance of benediction

it doesn't count the +4 mp5 from the zg head and legs enchant (+heal of it is getting picked up correctly)

Mp5 from Prophetic Aura ZG enchant not counted

Version: 3.4.1

Range Attack Speed

Hello

Range Attack Speed is not correct it's the same as melee attack speed and don`t take value of the Range weapon.

Incorrect block value

The block value is only calculated form the shields base value and strength. But items may also add block value through their effects.

For example the shield Drillborer Disk will increase the effective value by 23. This is not recognized at all.

I already have a workaround for this problem, will open a PR.

FPS loss in Combat

I noticed since the update I lose heavy fps as soon as I enter raidcombat, haven not tried solo.
Disabled the addon and game is back to smooth.

Request: Show +damage versus Undead

Would it be possible to include an option to show damage done versus Undead mobs?

With the inclusion of items like https://classic.wowhead.com/item=23207/mark-of-the-champion and mages running the Undead Cleansing Set (https://classic.wowhead.com/gear-planner/mage/gnome/AjwAgVNjXmQCVGiDS6pfZYVaLU45BkrAh1SsXmSIU2A2QolaM04oilosYfYLVM0MSssNWqcOS7MPTZEQUxkSLeQ) I think it would make a great addition if the +damage would be visible on the character pane.

This could either be on its own, or included in the total Spell Power (and showing as separate in tooltip).

[Improvement] Missing Warlock Crit Talent

Maybe I missed it, but it looks like the Warlock Destruction crit talent is missing in the crit calculation.

https://classic.wowhead.com/spell=18130/devastation

[request] crit cap

It could be a great addition, in the melee tab, to have crit cap.
Maybe with a color (white or green if not capped, red otherwise).

Defense Tooltip isn't based on bonus defense.

Currently your addon is showing bonus mitigation calculated using total defence skill (324*0.04), rather than bonus defense skill above your level ((324-level*5)*0.04). So in the above screenshot it should be showing 0.96%, rather than 12.96%.

[Feature]Add Elemental Shaman crit/hit from talents

Hi, can you add the shaman talents bonus for crit and hit.

Crit

Call of Thunder is only applied to the lightning spells.
Tidal Mastery affects healing/nature and lightning spells

Hit

Nature's Guidance counts for melee and spell hit

Spell School's

Lightning spells are Lightning Bolt and Chain Lightning
Nature spells are all Shaman spells except Frost/Fire/Shadow/Holy ...

Rogue + [Royal Seal of Eldre'Thalas] = bugged hit rating

Found a weird bug when equipping the rogue DM hit rating trinket ([Royal Seal of Eldre'Thalas]).

How to reproduce it:

My hit rating is 6%

When i equip [Royal Seal of Eldre'Thalas] my hit rating doesnt change (i should have 8% when wearing the trinket)
When i take off [Royal Seal of Eldre'Thalas] my hit rating goes up to 8% (with an empty trinket slot)
When i equip another trinket without hit rating, my hit goes down to 6% again

Screenshots example: https://imgur.com/a/OCo0jTi

Mana Regeneration from Spirit

This is Pseudo code pulled from my WeakAura and may require tweaking to work under your addon.
GetManaRegen() records inside/outside the 5 second rule

local playerClass, _, classID = UnitClass("player");
tblPlayerStats = { }
tblPlayerStats["ID"] = classID;
tblPlayerStats["Class"] = playerClass

There's Coefficients for mana regen for spirit:
tblClassRegen = { }
tblClassRegen[1] = {0, 0}; -- 1 Warrior
tblClassRegen[2] = {15, 5}; -- 2 Paladin
tblClassRegen[3] = {15, 5}; -- 3 Hunter
tblClassRegen[4] = {0, 0}; -- 4 Rogue
tblClassRegen[5] = {13,4}; -- 5 Priest
tblClassRegen[6] = {0, 0}; -- 6 ??
tblClassRegen[7] = {15, 5}; -- 7 Shaman
tblClassRegen[8] = {13, 4}; -- 8 Mage
tblClassRegen[9] = {8, 4}; -- 9 Warlock
tblClassRegen[10] = {0, 0}; -- 10 ??
tblClassRegen[11] = {0, 0}; -- 11 Druid

This is mana per tick (A tick is roughly 2.5 seconds)
tblPlayerStats["NotCasting"] = (tblClassRegen[tblPlayerStats["ID"]][1] + (UnitStat("player", 5) / tblClassRegen[tblPlayerStats["ID"]][2]));

Casting mp5 is then calculated from this specific number:
Mage Example:
for i=1,40 do
if (UnitBuff("player",i)) then
local buffName = select(1, UnitBuff("player",i))

    -- Mage: Mage Armor (Flat 30%)
    if (buffName == "Mage Armor") then

tblPlayerStats["Modifiers"] = tblPlayerStats["Modifiers"] + .30;
end
end
end

if (tblPlayerStats["Class"] == "Mage") then
-- Arcane Meditation 5/10/15%
tblPlayerStats["Modifiers"] = tblPlayerStats["Modifiers"] + ((select(5, GetTalentInfo(1, 12)) * 5) / 100);
end

tblPlayerStats["Casting"] = tblPlayerStats["NotCasting"] * tblPlayerStats["Modifiers"];

if (GetManaRegen() < 1) then
RetVal = "MPT: " .. tblColors["Red"] .. format("%.0f", tblPlayerStats["NotCasting"]) .. " (NC)|r " .. tblColors["Green"] .. format("%.0f", tblPlayerStats["Casting"]) .. " (C)|r";
else
RetVal = "MPT: " .. tblColors["Green"] .. format("%.0f", tblPlayerStats["NotCasting"]) .. " (NC)|r " .. tblColors["Red"] .. format("%.0f", tblPlayerStats["Casting"]) .. " (C)|r";
end

An example of this can be seen here: https://media.wago.io/screenshots/j4WOs4U4U/5e0aa74bd0b1d019c8dca11c.png
https://wago.io/j4WOs4U4U <- Weakaura I wrote for Regen code

Lua Error 2

I got this at every login:

Message: ...CharacterStatsClassic\CharacterStatsClassicUtils.lua:303: Division by zero
Time: Sat Feb 29 19:36:54 2020
Count: 1
Stack: ...CharacterStatsClassic\CharacterStatsClassicUtils.lua:303: Division by zero
...CharacterStatsClassic\CharacterStatsClassicUtils.lua:303: in function CSC_PaperDollFrame_SetDamage' ...ns\CharacterStatsClassic\CharacterStatsClassicUI.lua:84: in function SetCharacterStats'
...ns\CharacterStatsClassic\CharacterStatsClassicUI.lua:123: in function `UpdateStats'
...\CharacterStatsClassic\CharacterStatsClassicCore.lua:22: in function <...\CharacterStatsClassic\CharacterStatsClassicCore.lua:21>

Locals: statFrame = {
0 =
OnEnterCallback = defined *:OnEnter:1
Label = {
}
Value = {
}
Background = {
}
}
unit = "player"
category = "Melee"
speed = 0
offhandSpeed = nil
minDamage = 0
maxDamage = 0
minOffHandDamage = 0
maxOffHandDamage = 0
physicalBonusPos = 0
physicalBonusNeg = 0
percent = 0
displayMin = 1
displayMax = 1
(*temporary) = 0
(*temporary) = 1
(*temporary) = 1
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "Division by zero"
CSC_PaperDollFrame_SetLabelAndText = defined @interface\AddOns\CharacterStatsClassic\CharacterStatsClassicUtils.lua:59
CSC_GetAppropriateAttackSpeed = defined @interface\AddOns\CharacterStatsClassic\CharacterStatsClassicUtils.lua:36
CSC_GetAppropriateDamage = defined @interface\AddOns\CharacterStatsClassic\CharacterStatsClassicUtils.lua:27
CSC_GetAppropriateAttackRaiting = defined @interface\AddOns\CharacterStatsClassic\CharacterStatsClassicUtils.lua:45

Defense only showing base defense (not bonuses)

Hello,

As someone commented on curse, the defense part is not counting any modifier. I use the french client and i don't know since when it does that.

Anyway, great add on. I really like it :)

Are PRs welcome?

Hey.
I've stumbled upon your addon what does exactly what I want, in a lightweight way.

However, there are some problems with classic clients when localization differs from english.
I run the german client, where different texts overlap each other.
Also the usage of localized strings is kind of inconsistent.

Do you mind me opening some PRs to cover these issues?

Weaponskill calculation doesnt work on german locales

While working on a fix for #22 I stumbled over a general problem in local function CSC_GetPlayerMissChances(unit, playerHit).

On german locales the weapon type is not identical with the weapon skill.
E.g. while wearing a 1H sword the weapon type is "Schwert" but the weapon skill is "Schwerter". The weapon type is the singular while the weapon skill is the plural.

I tried to change the way these strings are compared, and used string.find what worked with the given example. But I dont know if this is a safe way in general.

Holy Priest Issue

Nothing too fancy - the addon is just not adding the +5% holy crit from the holy talent tree.

error msg

1x [ADDON_ACTION_BLOCKED] AddOn 'CharacterStatsClassic' tried to call the protected function 'PaperDollFrame:Show()'.
!BugGrabber\BugGrabber.lua:519: in function <!BugGrabber\BugGrabber.lua:519>
[C]: in function Show' FrameXML\CharacterFrame.lua:40: in function CharacterFrame_ShowSubFrame'
...ns\CharacterStatsClassic\CharacterStatsClassicUI.lua:203: in function `ToggleCharacter'
[string "TOGGLECHARACTER0"]:1: in function <[string "TOGGLECHARACTER0"]:1>

Locals:
InCombatSkipped

Also think that it sometimes block me from opening my character panel in combat..

[request] School specific spellpower in tooltip

In classic, much of your spellpower will be school specific (frost spell damage, shadow damage, etc) so it'd be nice to be able to see that in the tool tip for spellpower.

Random lua error when logging in

Date: 2019-10-13 10:46:24
ID: 1
Error occured in: Global
Count: 3
Message: ...CharacterStatsClassic\CharacterStatsClassicUtils.lua line 97:
attempt to index local 'stats' (a nil value)
Debug:
[C]: ?
...CharacterStatsClassic\CharacterStatsClassicUtils.lua:97:
...CharacterStatsClassic\CharacterStatsClassicUtils.lua:89
...CharacterStatsClassic\CharacterStatsClassicUtils.lua:697: CSC_PaperDollFrame_SetManaRegen()
...ns\CharacterStatsClassic\CharacterStatsClassicUI.lua:97: SetCharacterStats()
...ns\CharacterStatsClassic\CharacterStatsClassicUI.lua:120: UpdateStats()
...\CharacterStatsClassic\CharacterStatsClassicCore.lua:22:
...\CharacterStatsClassic\CharacterStatsClassicCore.lua:21
Locals:

AddOns:
Swatter, v8.2.6377 (SwimmingSeadragon)
WowheadLooter, v11302
AdvancedInterfaceOptions, v1.3.3
Atlas, vv1.45.01.11302
AtlasClassicWoW, vv1.45.00.11302.05
AtlasDungeonLocs, vv1.45.00.11302.01
AtlasLootClassic, vv1.3.0
AtlasLootClassicData, vv1.3.0
AtlasLootClassicDungeonsAndRaids, vv1.3.0
AtlasQuest, v4.11.54
Auctionator, v8.1.0
BagBrother, v
Bagnon, v8.2.16
BiSTracker, v1.4
CharacterStatsClassic, v2.2
ClassicAuraDurations, v
Clique, vv11302-1.0.0
CrossGambling, v8.2.0
DBMCore, v1.13.15
DBMDefaultSkin, v
DBMStatusBarTimers, v
Decursive, v2.7.6.4
Details, v
DetailsTinyThreat, v
DismountMe, v1.5
ElvUI, v1.14
GatherMate2, v1.45.5-1-gab6216a
Grail, v101
GrailNPCsclassic, v27178
GrailNPCsclassicenUS, v27178
GrailQuestsclassic, v27178
GrailQuestsclassicenUS, v29297
GrailReputationsclassic, v007
GTFO, v4.50.1
GuildRosterManager, v1.76
LeatrixPlus, v1.13.34
LunaUnitFrames, v3038
Mapster, v1.8.5-1-g3e96752
MonkeyLibrary, v
MonkeyQuest, v
MonkeyQuestLog, v
Necrosis, v5.0
OmniCC, v8.2.5
Prat30, v3.7.36-2-g374a268
Prat30Libraries, v
Questie, v4.2.1 0 0f28ee6
RollTrackerClassic, v1.50
SilverDragon, vv11302.0
SilverDragonClassic, vv11302.0
SmartBuff, v1.13.2d
Stubby, v8.2.6376 (SwimmingSeadragon)
Thaliz, v0.2.2
TitanClassic, v1.1.1.11302
TitanClassicAmmo, v1.1.1.11302
TitanClassicBag, v1.1.1.11302
TitanClassicClock, v1.1.1.11302
TitanClassicGold, v1.1.1.11302
TitanClassicLocation, v1.1.1.11302
TitanClassicLootType, v1.1.1.11302
TitanClassicPerformance, v1.1.1.11302
TitanClassicRegen, v1.1.0.11302
TitanClassicRepair, v1.1.1.11302
TitanClassicVolume, v1.1.1.11302
TitanClassicXP, v1.1.1.11302
TomTom, vv11302-1.0.7
TrinketMenu, v7.3.2
Wholly, v072
BlizRuntimeLib_enUS v1.13.2.11302
(ck=72a)

Shaman T2 5-Piece Set Bonus

When a shaman wears 5 piece T2 and the bonus is applied, +3% critical strike chance to all Nature spells, the addon is applying double the amount of Crit for a total of 6%. This happens every time the 5 piece effect is used.

Mp5 on mana oil not calculated

Brilliant mana oil's 12mp5 does not display in character sheet once applied.

First screen shot shows 150mp5 with oil and weapon equipped

Removing weapon removes 15mp5 from the weapon but not the 12mp5 from oil

Mp5 was not added when oil was applied but forgot to get before/after screenshots

Make table background either black or transparent
- I assume by making it transparent, it'll just take the BG color of the parent window frame (therefore the character's window frame).

Otherwise, GJ on the addon, very useful!

Warrior's Defence still not showing right.

subject

Missing localization strings

There are quite a few locale strings missing e.g. melee hit strings and others

getov / characterstatsclassic Goto Github PK

characterstatsclassic's People

Stargazers

Watchers

Forkers

characterstatsclassic's Issues

Observation

Expectation

Explanation

Example

Crit

Hit

Spell School's

Recommend Projects

Recommend Topics

Recommend Org