gfto/bitstream

biTStream is a set of C headers allowing a simpler access to binary structures such as specified by MPEG, DVB, IETF, etc. This repository is mirror of official repo at git://git.videolan.org/bitstream.git and my personal development tree.

bitstream's Issues

Missing function in descriptor 0x83 and 0x88 ...

Hi,

I realized that for these descriptors the "set" functions are absent.

I have attached the patch.

debugasm

patch.txt

Wrong right shift in a52e_get_strmtyp()

Shouldn't the result in a52e_get_strmtyp() be right shifted 6 times, instead of 5, to get a value masked with 0xc0 "down"?
a52e_set_strmtyp() shifts the value left 6 times when setting a new value.

desc48_get_provider vs desc48_get_service ...

Hi,

in the descriptr 0x48 the returned parameter is different, one is "const" one is not.

static inline const uint8_t *desc48_get_provider(const uint8_t *p_desc,
                                                 uint8_t *pi_length)
{
    const uint8_t *p = p_desc + DESC48_HEADER_SIZE;
    *pi_length = p[0];
    return p + 1;
}

static inline uint8_t *desc48_get_service(const uint8_t *p_desc,
                                          uint8_t *pi_length)
{
    uint8_t *p = (uint8_t *)p_desc + DESC48_HEADER_SIZE + 1 + p_desc[3];
    *pi_length = p[0];
    return p + 1;
}

The first one generate "warning", in my opinion, the structure of "desc48_get_service" is more correct and can also be used for "desc48_get_provider"

static inline uint8_t *desc48_get_provider(const uint8_t *p_desc,
                                           uint8_t *pi_length)
{
    uint8_t *p = (uint8_t *)p_desc + DESC48_HEADER_SIZE;
    *pi_length = p[0];
    return p + 1;
}

debugasm