gfurtadoalmeida/esp32-driver-mcp320x

ESP32 driver for Microchip MCP3204 and MCP3208 12-bit ADCs.

esp32-driver-mcp320x's Issues

Voltage calculation suffers from integer division in float context

The voltage calculation for a reference voltage less than 4096 will always return 0 and any reference voltage other than 4096 will return an inaccurate voltage.

Here is a patch :

diff --git a/components/esp32_driver_mcp320x/src/mcp320x.c b/components/esp32_driver_mcp320x/src/mcp320x.c
index ce6e6fe..5af377d 100644
--- a/components/esp32_driver_mcp320x/src/mcp320x.c
+++ b/components/esp32_driver_mcp320x/src/mcp320x.c
@@ -40,7 +40,8 @@ mcp320x_t *mcp320x_install(mcp320x_config_t const *config)
     mcp320x_t *dev = (mcp320x_t *)malloc(sizeof(mcp320x_t));
     dev->spi_handle = spi_device_handle;
     dev->mcp_model = config->device_model;
-    dev->millivolts_per_resolution_step = config->reference_voltage / MCP320X_RESOLUTION;
+    dev->millivolts_per_resolution_step = (float)config->reference_voltage / (float)MCP320X_RESOLUTION;

 
     return dev;

Voltage not properly displayed

When I run the code, the displayed voltage couldn't go greater than somewhere around 70 mV. The hex value in rx buffer was responding properly to the input voltage though, so I modified the code a little bit. Change diff.patch -> diff.html
diff.patch

esp32 cpu crashes when reading is done in a loop

Cpu crashes when your example code is put in a while (1) loop with vtask delay