ghoneycutt/puppet-module-ntp

Puppet module to manage ntp

puppet-module-ntp's Issues

Bump major version

Ideas in PR #69 on what should change

osfamily values in spec tests are not capitalized correctly

currently is

suse instead of Suse
debian instead of Debian
etc..

every fail() in the class should be represented in the spec test.

We are missing tests to ensure that failure happens on unsupported versions of supported distro's

suse compatibility broke the code

quoted booleans

Uses strings for booleans. Should use booleans and check for strings and convert if necessary. See the following example.

https://github.com/ghoneycutt/puppet-module-common/blob/master/manifests/init.pp#L42

update design pattern for puppet v3

Uses ::data design pattern from 2.7 days. Update to remove ::data and have all the options as parameters in the main ntp class.

validate package_source and package_adminfile

Validate that these are absolute paths. See https://github.com/puppetlabs/puppetlabs-stdlib/tree/3.2.0

incompatible restrict options for Solaris 10

The module is using restrict options that are incompatible with Solaris 10. Because of that the complete line for restrict is ignored leading to an completly unrestricted NTP server.

Error messages show that the restrict lines are ignored (at all)

Feb  5 15:49:21 sol10 xntpd[35808]: [ID 504011 daemon.error] getnetnum: "-4" invalid host number, line ignored
Feb  5 15:49:21 sol10 xntpd[35808]: [ID 504011 daemon.error] getnetnum: "-6" invalid host number, line ignored
Feb  5 15:49:21 sol10 xntpd[35808]: [ID 504011 daemon.error] getnetnum: "::1" invalid host number, line ignored
Feb  5 15:49:21 sol10 xntpd[35808]: [ID 269952 daemon.error] can't open key file /etc/inet/ntp.keys: No such file or directory
Feb  5 15:49:21 sol10 xntpd[35808]: [ID 241925 daemon.error] configure: keyword "tinker" unknown, line ignored
Feb  5 15:49:24 sol10 xntpd[35808]: [ID 373468 daemon.error] adj_frequency: ntp_adjtime failed: Not owner

To restrict ntp on Solaris 10 these line would be sufficient:

restrict default noserve noquery
restrict 127.0.0.1

Should I create a PR with (new) valid defaults for Solaris 10 ?

README is incomplete

Should include compatibility, parameters, etc.

ensure /etc/ntp is present

If you want to use /etc/ntp/step-tickers, you need /etc/ntp, though your distributions package may not include that directory. Our code should ensure the path for step-tickers is present.

fix README for $keys

Section for $keys got copy pasted from $driftfile and have irritating lefttovers.

rake spec error

I'm getting the following "rake spec" error from v2.2.3 and current master. v2.2.2 had no errors.

1. ntp with package_name set to an array
   Failure/Error: it { should compile.with_all_deps }
   NameError:
   undefined local variable or method `compile' for #RSpec::Core::ExampleGroup::Nested_1::Nested_21::Nested_1:0x7fb4df7d2698

   ./spec/classes/init_spec.rb:706

2. ntp with package_name set to a string
   Failure/Error: it { should compile.with_all_deps }
   NameError:
   undefined local variable or method `compile' for #RSpec::Core::ExampleGroup::Nested_1::Nested_21::Nested_2:0x7fb4df47eb18

   ./spec/classes/init_spec.rb:725