ghostery/url-parser

A fast typescript implementation of the window.URL API

url-parser's Issues

fails to detect invalid URL

The following URL is accepted by @cliqz/url-parser but rejected by URL constructor in Firefox/Node.js: http://data:text/plain;charset=UTF-8;page=21,the%20data:1234,5678.

handle ipv6

Currently fails to handle ipv6 (e.g.: https://[::1]).

Unable to set querystring

For the following snippet,

let url = new URL('https://github.com');
url.searchParams.set('key', 'value');
console.log(url.href);

Standard URL returns https://github.com/?key=value while url-parser gives me https://github.com.

If this is out of the scope of this library (I guess is being a super fast parser), feel free to close the issue.

TLD parsing options

Currently the hostname is parsed using default tldts options. In practice we may want to pass options such as allowPrivateDomains when parsing the hostname.

We could, for example, add an optional argument to the URL constructor with the tldts IOptions for tldts.parse. Alternatively we could expose a global that sets the options for all URLs created by the application.

add tests for corner cases

There are a few resources we might be able to leverage to test more corner cases for the parsing logic.

• https://github.com/cweb/url-testing/blob/master/urls.json
• https://webkit.org/blog/7086/url-parsing-in-webkit/
• https://www.lookout.net/test/url/
• https://www.lookout.net/test/url/url-runner.html

[question] new URL(...).origin === "null" for unknown/custom schemes (not this module but browser/node)

In node/browser when native URL used the call like this new URL("webclient://domain.net/blank.html?loader-id=2fb1c580").origin returns "null" (notice unknowns/custom scheme). This library returns the value regardless the scheme and I like such behavior.

The questions:

• Is this module planning returning "null" for unknown/custom schemes like node & browser do?
• Maybe there is a link to documentation which covers the described "null" case?

library seems to be missing 'tslib' dependency

After installing the library I could see an exception because tslib was missing. Probably it should be bundled instead.