Giter Site home page Giter Site logo

Comments (8)

gildor2 avatar gildor2 commented on May 23, 2024 2

Done, made a new release.

from fast_zlib.

gildor2 avatar gildor2 commented on May 23, 2024 1

I've downloaded the new zlib release, its code is not buildable at the moment for Windows/Winapi DLL build. Windows/Cdecl build is okay. Tested with provided Visual Studio solution, the same error appears there too - so, there's a bug in zlib code itself. I'll wait for the update.

Just for reference, errors are looking like this:

../zlib/crc32.c(1089): error C2708: 'crc32_combine64': actual parameters length in bytes differs from previous call or reference
../zlib/crc32.c(1072): note: see declaration of 'crc32_combine64'
../zlib/crc32.c(1106): error C2708: 'crc32_combine_gen64': actual parameters length in bytes differs from previous call or reference
../zlib/crc32.c(1093): note: see declaration of 'crc32_combine_gen64'
../zlib/crc32.c(1110): error C2373: 'crc32_combine_op': redefinition; different type modifiers
...\zlib.h(1768): note: see declaration of 'crc32_combine_op'

from fast_zlib.

Neustradamus avatar Neustradamus commented on May 23, 2024 1

@gildor2: Thanks for your update!

Have you proposed your patch in upstream?

from fast_zlib.

gildor2 avatar gildor2 commented on May 23, 2024 1

Yep, a few years ago
madler/zlib#231

from fast_zlib.

gisphm avatar gisphm commented on May 23, 2024

Looks like zlib will make a new release version.
Please make new release
I'll wait for your build when zlib releases new version.

I've downloaded the new zlib release, its code is not buildable at the moment for Windows/Winapi DLL build. Windows/Cdecl build is okay. Tested with provided Visual Studio solution, the same error appears there too - so, there's a bug in zlib code itself. I'll wait for the update.

Just for reference, errors are looking like this:

../zlib/crc32.c(1089): error C2708: 'crc32_combine64': actual parameters length in bytes differs from previous call or reference
../zlib/crc32.c(1072): note: see declaration of 'crc32_combine64'
../zlib/crc32.c(1106): error C2708: 'crc32_combine_gen64': actual parameters length in bytes differs from previous call or reference
../zlib/crc32.c(1093): note: see declaration of 'crc32_combine_gen64'
../zlib/crc32.c(1110): error C2373: 'crc32_combine_op': redefinition; different type modifiers
...\zlib.h(1768): note: see declaration of 'crc32_combine_op'

from fast_zlib.

gildor2 avatar gildor2 commented on May 23, 2024

BTW I'm not tracking zlib releases myself, so if you'll notice new commits/release there, just let me know. I've already made some changes locally to support more modern Visual Studio versions (there were many more errors building the code), but the mentioned problem comes from original repo.

from fast_zlib.

Neustradamus avatar Neustradamus commented on May 23, 2024

@madler has done the new build, the 1.2.13 has been released with the CVE-2022-37434 fix.

from fast_zlib.

Neustradamus avatar Neustradamus commented on May 23, 2024

I see :/

from fast_zlib.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.