Giter Site home page Giter Site logo

Comments (5)

gilzoide avatar gilzoide commented on May 25, 2024 2

Okay, so after some testing I found out the culprit.
Setting the panel style to a colored StyleBoxFlat, we can see that the panels (which subclass TabContainer) are actually receiving the right Rects.
Screenshot_20221106_111153
So the problem is that Reference Controls' content is not updated correctly in these cases.
They were using the NOTIFICATION_SORT_CHILDREN notification to reposition the content. So it seems that Godot does not ask for Containers inside TabContainers to sort their children depending on the panel style and whether resizing horizontally vs vertically. Weird stuff, right?
Changing it to a NOTIFICATION_TRANSFORM_CHANGED solves this issue, I'll soon create a PR with the fix.

Thanks for the report!

from godot-dockable-container.

Nif-kun avatar Nif-kun commented on May 25, 2024

I currently don't have any time to look for it in code. But if given a hint or I find it during my spare time, I'll try to make a fix for it.

from godot-dockable-container.

gilzoide avatar gilzoide commented on May 25, 2024

Wow, that's really weird =S
I've been able to reproduce here as well. Seems like something is off in regards to respecting the minimum size, but only when a style is applied. I'll try looking into it quickly here and see if I can find something of interest for fixing.

from godot-dockable-container.

gilzoide avatar gilzoide commented on May 25, 2024

@Nif-kun feel free to try the fix before we merge it into the main branch.

from godot-dockable-container.

gilzoide avatar gilzoide commented on May 25, 2024

FYI I've submitted the new version 1.1.2 with this fix and the new icon to the Asset Store!

from godot-dockable-container.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.