girugacode/cs-2.1-trees-sorting

Class repository for CS 2.1

cs-2.1-trees-sorting's Issues

Feedback on sorting algorithms

What was great:

• Good job on implementing your is_sorting function efficiently!
• Good job on successfully implementing your sorting algorithms!

Here's some feedback to improve:

• Try adding a couple more test cases! It may seem intimidating at first, but you've made it past the hard part. Implementation is way tougher than calling these functions and comparing inputs. In the work environment, writing tests will be required. Its a good habit to build :)

Feedback on prefix trees

Great job on completing the prefix tree! You can further challenge yourself by working on time and space complexities for each prefix tree method. You would be expected to do this in interviews, and it would be good practice :)

Feedback on heaps, priority queues, and integer sorting algorithms

Great work on completing these challenges. Here's some feedback to improve your code:

• Your priority queue should insert based on the given priority! The min_item should be at the top, using the given priority.
• Your counting sort fails tests. Try running pytest sorting_test.py::IntegerSortTest to see what errors you get and reach out if you need help debugging. This could likely be because your counting_sort is not in place, and mutating the original list before returning like original_list[:] = result could fix the problem. And make sure to check for an empty list case because min & max don't support empty lists.