githawkapp/flatcache

Implementation of Soroush Khanlou's Flat Cache.

flatcache's Issues

CI not triggering for PR's

Check out #5 and #6, Its not triggering travis and no check updates.

NSHashTable weak objects releasing

Ahoy there @rnystrom, while sifting through your nice collection of repos, I came across this one which I see is still being worked on and just wanted to comment a bit on this guy below.

FlatCache/FlatCache/FlatCache.swift

Line 71 in 5700835

table = NSHashTable.weakObjects()

I recently came across NSHashTable and MSMapTable and found their ideas to be quite useful then I tested it out and found some issues when using weak references within the tables such as the ones found in the link below and a few other places ☹️

A quick playground of testing out what others spoke about seems to hold true at least in terms of when the object within the table is released

http://cocoamine.net/blog/2013/12/13/nsmaptable-and-zeroing-weak-references/

Then I got a little curious when I saw your implementation of FlatCache from Soroush and was wondering (if you had freetime of course) to test out the usage of FlatCache and it working as expected? I like the idea that the tables provide the flexibility of using both strong and weak keys and values interchangeably but didn't seem to work as intended all the time.

Cheers to implementing FlatCache, I'll be lurking for its release 😉