githawkapp/githawk

The (second) best iOS app for GitHub.

githawk's Issues

Add "No description provided." when content is empty

Cells in settings have no selected state

Support renamed timeline events

iPad shows splitview detail pane when in 50/50 mode

Feature: Swipe to next unread notifications

Would be super slick if you could swipe through issues to go through all the unread ones?
Maybe once you've read them it all it just gives you a page saying "All caught up!" or similar.

PR review threaded comments

Comment as part of a review. Can have multiple responses. All stem from a seed comment that has a diffHunk + position. Show the previous 4 lines. Color code when line is prefixed with + (green) or - (red)

Read notifications still have a swipe action to mark as read

Bug: Relative time is incorrect

iOS 11 beta 2; 6S+

The relative time on actual GitHub says 5 hours ago, and the one in the app says 17 hours ago!

One of them must be wrong 🤔

Bug: 1Password integration empty

Pressed the button on login screen, share sheet opened but only had a "More" button which opened no apps.

Was no way to use 1Password from what I could tell?
(I have it installed, and use it)

Sometimes I dislike long passwords 😞
2FA support was nice though 😃

iOS 11 beta 2, 6S+

Swipe notifications to dismiss

• Use SwipeCellKit
• Send notification POST request
• Optimistically dismiss
• Re-show if request fails

Show total unread count in seg control

Should look like

Unread (16)

Large code blocks do not fully display

The display of a large code block:

// Some code
//
//
//
//
// More code
//
//
//
//
// Even more code
//
//
//

Does not work properly.

Supported HTML

Supported HTML elements

h1 h2 h3 h4 h5 h6 br b i strong em a pre code img tt
div ins del sup sub p ol ul table thead tbody tfoot blockquote
dl dt dd kbd q samp var hr ruby rt rp li tr td th s strike summary details

H1

H2

H3

H4

H5

H6

This is some bold with strong, a sprinkle of em and i. How about a link? And some inline code.

let a = "foo"

Definition header

Definition item

• Unordered list
• Another unordered

1. Ordered list
2. Item 2

Strike

Refresh feed after backgrounding for more than 30 minutes

Refresh on warm start, save you from pulling to refresh

Signing out does not return you to login

When you sign out of an account, you can still return back to the issue overview and browse through them.

Creative "empty" view (ala zero)

Username highlighting and tap

V1 open profile in web view

Format tests

Bla is the only thing I want for a man who is the best team on this team and the best of the best to play the app with a great app Bla is the only thing I want for a man who is the best team on this team and the best of the best to play the app with a great app

Bla is the only thing I want for a man who is the best team on this team and the best of the best to play the app with a great app

_{Sent from GitHawk}

"Mark all as read" button on notifications

GitHub check lists

• unchecked
• checked

Load page x keeps incrementing even when nothing can be retrieved

Issue title scrolls after opening on 7+

When tapping an issue, after the segue there is a moment when the issue title is shown followed by a the view scrolling down to Labels. The title is hidden unless you scroll the view down where you will see it until you’ve released your scroll.

It might be an iOS 11 specific issue with the transition from bottomLayoutGuide to safeAreaLayoutGuide

Apologies for the lack of code blocks, can’t figure out where to find the back ticks on my phone.

New MarkdownView

Found this library. Haven't tried it but looks promising for markdown rendering :)

https://github.com/keitaoouchi/MarkdownView

"Merged" status on PRs in title

Sample issue

Tables

Markdown	Less	Pretty
Still	renders	nicely
1	2	3
(Do!) doe, a deer	(Re!) ray, a drop of golden sun	42

Issues paging

Only showing first 100 items of issue timeline content. Needs paging.

Settings cells that push should have accessory

Highlight self-posts

Light blue

Issue/PR open/closed icon is backwards

Disable "mark all" if all read

Open commit notifications in Safari VC

Complicated, might be impossible b/c file contents require even more API requests.

Bug: Notifications pane width doesn't update on rotate

iOS 11 beta 2, 6S+

From either notifications view or an issue view, rotating (which then does split screen) does not update the notifications pane width - this means that some of the text is cut off

If you pull to refresh or change the filter, this does update and fix it
The opposite it also happens if you have a thin version and go to portrait

Locked status in header

Next to status (open/merged/closed)

Markdown test

Headers

# H1
## H2
### H3
#### H4
##### H5
###### H6

Alternatively, for H1 and H2, an underline-ish style:

Alt-H1
======

Alt-H2
------

H1

H2

H3

H4

H5

H6

Alternatively, for H1 and H2, an underline-ish style:

Alt-H1

Alt-H2

Emphasis

Emphasis, aka italics, with *asterisks* or _underscores_.

Strong emphasis, aka bold, with **asterisks** or __underscores__.

Combined emphasis with **asterisks and _underscores_**.

Strikethrough uses two tildes. ~~Scratch this.~~

Emphasis, aka italics, with asterisks or underscores.

Strong emphasis, aka bold, with asterisks or underscores.

Combined emphasis with asterisks and underscores.

Strikethrough uses two tildes. Scratch this.

Lists

1. First ordered list item
2. Another item
    * Unordered sub-list. 
    * Another unordered item
        1. Embedded-embedded list
        2. And another
1. Actual numbers don't matter, just that it's a number
    1. Ordered sub-list
    2. Ordered sub-list
4. And another item.

Text before paragraph
* Unordered list can use asterisks
- Or minuses
+ Or pluses

1. First ordered list item
2. Another item
   • Unordered sub-list.
   • Another unordered item
     1. Embedded-embedded list
     2. And another
3. Actual numbers don't matter, just that it's a number
   1. Ordered sub-list
   2. Ordered sub-list
4. And another item.

Text before paragraph

• Unordered list can use asterisks

• Or minuses

• Or pluses

Links

There are two ways to create links.

[I'm an inline-style link](https://www.google.com)

[I'm an inline-style link with title](https://www.google.com "Google's Homepage")

[I'm a reference-style link][Arbitrary case-insensitive reference text]

[I'm a relative reference to a repository file](../blob/master/LICENSE)

[You can use numbers for reference-style link definitions][1]

Or leave it empty and use the [link text itself].

URLs and URLs in angle brackets will automatically get turned into links. 
http://www.example.com or <http://www.example.com> and sometimes 
example.com (but not on Github, for example).

Some text to show that the reference links can follow later.

[arbitrary case-insensitive reference text]: https://www.mozilla.org
[1]: http://slashdot.org
[link text itself]: http://www.reddit.com

I'm an inline-style link

I'm an inline-style link with title

I'm a reference-style link

I'm a relative reference to a repository file

You can use numbers for reference-style link definitions

Or leave it empty and use the link text itself.

URLs and URLs in angle brackets will automatically get turned into links.
http://www.example.com or http://www.example.com and sometimes
example.com (but not on Github, for example).

Some text to show that the reference links can follow later.

Images

Here's our logo (hover to see the title text):

Inline-style: 
![alt text](https://github.com/adam-p/markdown-here/raw/master/src/common/images/icon48.png "Logo Title Text 1")

Reference-style: 
![alt text][logo]

[logo]: https://github.com/adam-p/markdown-here/raw/master/src/common/images/icon48.png "Logo Title Text 2"

Here's our logo (hover to see the title text):

Inline-style:

Reference-style:

Code and Syntax Highlighting

Inline `code` has `back-ticks around` it.

Inline code has back-ticks around it.

Blocks of code are either fenced by lines with three back-ticks ```, or are indented with four spaces. I recommend only using the fenced code blocks -- they're easier and only they support syntax highlighting.

```javascript
var s = "JavaScript syntax highlighting";
alert(s);
```
 
```python
s = "Python syntax highlighting"
print s
```
 
```
No language indicated, so no syntax highlighting. 
But let's throw in a <b>tag</b>.
```

var s = "JavaScript syntax highlighting";
alert(s);

s = "Python syntax highlighting"
print s

No language indicated, so no syntax highlighting in Markdown Here (varies on Github). 
But let's throw in a <b>tag</b>.

Tables

Tables aren't part of the core Markdown spec, but they are part of GFM and Markdown Here supports them. They are an easy way of adding tables to your email -- a task that would otherwise require copy-pasting from another application.

Colons can be used to align columns.

| Tables        | Are           | Cool  |
| ------------- |:-------------:| -----:|
| col 3 is      | right-aligned | $1600 |
| col 2 is      | centered      |   $12 |
| zebra stripes | are neat      |    $1 |

There must be at least 3 dashes separating each header cell.
The outer pipes (|) are optional, and you don't need to make the 
raw Markdown line up prettily. You can also use inline Markdown.

Markdown | Less | Pretty
--- | --- | ---
*Still* | `renders` | **nicely**
1 | 2 | 3

Colons can be used to align columns.

Tables	Are	Cool
col 3 is	right-aligned	$1600
col 2 is	centered	$12
zebra stripes	are neat	$1

There must be at least 3 dashes separating each header cell. The outer pipes (|) are optional, and you don't need to make the raw Markdown line up prettily. You can also use inline Markdown.

Markdown	Less	Pretty
Still	renders	nicely
1	2	3

Blockquotes

> Blockquotes are very handy in email to emulate reply text.
> This line is part of the same quote.

Quote break.

> This is a very long line that will still be quoted properly when it wraps. Oh boy let's keep writing to make sure this is long enough to actually wrap for everyone. Oh, you can *put* **Markdown** into a blockquote. 

>This is a quote with no space

> Quote level one
> > Quote level two
> > Another block
> > > And three

Blockquotes are very handy in email to emulate reply text.
This line is part of the same quote.

Quote break.

This is a very long line that will still be quoted properly when it wraps. Oh boy let's keep writing to make sure this is long enough to actually wrap for everyone. Oh, you can put Markdown into a blockquote.

This is a quote with no space

Quote level one

Quote level two
Another block

And three

Inline HTML

You can also use raw HTML in your Markdown, and it'll mostly work pretty well.

<dl>
  <dt>Definition list</dt>
  <dd>Is something people use sometimes.</dd>

  <dt>Markdown in HTML</dt>
  <dd>Does *not* work **very** well. Use HTML <em>tags</em>.</dd>
</dl>

Definition list

Is something people use sometimes.

Markdown in HTML

Does *not* work **very** well. Use HTML tags.

Horizontal Rule

Three or more...

---

Hyphens

***

Asterisks

___

Underscores

Three or more...

---

Hyphens

---

Asterisks

---

Underscores

Line Breaks

My basic recommendation for learning how line breaks work is to experiment and discover -- hit <Enter> once (i.e., insert one newline), then hit it twice (i.e., insert two newlines), see what happens. You'll soon learn to get what you want. "Markdown Toggle" is your friend.

Here are some things to try out:

Here's a line for us to start with.

This line is separated from the one above by two newlines, so it will be a *separate paragraph*.

This line is also a separate paragraph, but...
This line is only separated by a single newline, so it's a separate line in the *same paragraph*.

Here's a line for us to start with.

This line is separated from the one above by two newlines, so it will be a separate paragraph.

This line is also begins a separate paragraph, but...
This line is only separated by a single newline, so it's a separate line in the same paragraph.

(Technical note: Markdown Here uses GFM line breaks, so there's no need to use MD's two-space line breaks.)

Notifications paging

Only showing the first page of notifications content. Should add paging.

Lock timeline events

Cell selection and highlighting

Highlight when tapped, maintain selection esp for split view. On compact needs to remove selection when going back.

Showing a full screen view (eg. Safari VC) deselects selected row

Steps to reproduce:

Open in split view
Select issue / PR -> is now selected
Open issue / PR in Safari and dismiss
Issue / PR is now deselected

Account name in settings appears as entered

Logging in with "basthomas" displays "basthomas", logging in with "BASTHOMAS" displays "BASTHOMAS". Not sure if this is an issue?

Tapping labels opens webview

Layout not updated on screen change

When changing orientation or the app's size in splitview on iPad, the layout isn't updated. Clicking something that causes some sort of refresh (focus on account in settings, switching state in notifications) fixes this. How can this be resolved best?

Impact: everything (except GitHubLogin.storyboard)

In a thread, tapping a comment fixes it only partially; the textview width is not updated.

Screenshots

Feature: open in Safari VC (instead of just Safari)

Markdown table rendering support

Convert tables:

First Header	Second Header
Content from cell 1	Content from cell 2
Content in the first column	Content in the second column

Into a model + UICollectionViewCell within the comment section controller. Constraints:

• Nested UICollectionView
• Horizontal UICollectionViewFlowLayout
• Item width should be max of row
• Headers are bold + centered
• Limited markdown rendering
  • Strikethrough
  • Bold
  • Italics
  • Links

Tapping name and avatar in header opens profile

PR Review timeline events

PullRequestReview GQL object. Has a body text and decision (accept/reject).

Merge events in timeline

Bug: Part of issue appears underneath navigation bar

In the first image below I am scrolled as far up as possible, and parts of the content has extended under the navigation bar -- second image for reference I've pulled down.

iOS 11 beta 2

Soft read notifications when opening

Add note to a "soft read" status when opening (issue/commit/PR). Fades contents to 50% but DOESNT remove item (so you can go back). On reload the item is added to read list.

Feature: Gradient over portrait images

If you fullscreen view an image and it's pretty light at the top, it's hard to see the close/share button (didn't actually see share button at first!)

Probably be nice to have a dark gradient just to make them more visible

Move settings to nav bar button

Remove the tab bar, takes up too much screen real-estate atm