Giter Site home page Giter Site logo

Comments (5)

aleung avatar aleung commented on July 3, 2024 1

My use case was: The repo has a rule matching "*" to protect all branches from direct push. GitLabForm is unable to unprotect the branch because the rule is not using the branch name.

I couldn't reproduce the issue with v2.7.0, but I didn't see the code has handled it.

It doesn't bother me because we're using GitLab Premium and we can setup an special user for GitLabForm that has direct push privilege. Let it close and I will provide more information if I have.

from gitlabform.

aleung avatar aleung commented on July 3, 2024

Protected branch name with wildcard is not supported neither. For example, my protected branch is "*", GitLabForm won't unprotect it before changing files.

Rather than unprotect and protect again, it's better to use a specific user in GitLabForm and add this user to allowed_to_push list. But it's available to GitLab Premium only.

from gitlabform.

gdubicki avatar gdubicki commented on July 3, 2024

Perhaps what we did in #294 has helped with that, @aleung , as now the app will not unprotect the branch if the user has permissions to update the file regardless of the branch protection. Can you try your use case again with v2.7.0 please?

from gitlabform.

aleung avatar aleung commented on July 3, 2024

I tested with a config of protected branch naming in "*" and it seem to work. But in #294 I didn't find the code that handles wildcard.

from gitlabform.

gdubicki avatar gdubicki commented on July 3, 2024

#294 just makes GitLabForm stop doing unprotect/protect if it doesn’t have to. That’s why it doesn’t reference wildcard protection.

if it works for you then I will close this issue and reopen if someone gets hit by it again.

from gitlabform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.