Comments (5)
My use case was: The repo has a rule matching "*" to protect all branches from direct push. GitLabForm is unable to unprotect the branch because the rule is not using the branch name.
I couldn't reproduce the issue with v2.7.0, but I didn't see the code has handled it.
It doesn't bother me because we're using GitLab Premium and we can setup an special user for GitLabForm that has direct push privilege. Let it close and I will provide more information if I have.
from gitlabform.
Protected branch name with wildcard is not supported neither. For example, my protected branch is "*", GitLabForm won't unprotect it before changing files.
Rather than unprotect and protect again, it's better to use a specific user in GitLabForm and add this user to allowed_to_push
list. But it's available to GitLab Premium only.
from gitlabform.
Perhaps what we did in #294 has helped with that, @aleung , as now the app will not unprotect the branch if the user has permissions to update the file regardless of the branch protection. Can you try your use case again with v2.7.0 please?
from gitlabform.
I tested with a config of protected branch naming in "*" and it seem to work. But in #294 I didn't find the code that handles wildcard.
from gitlabform.
#294 just makes GitLabForm stop doing unprotect/protect if it doesn’t have to. That’s why it doesn’t reference wildcard protection.
if it works for you then I will close this issue and reopen if someone gets hit by it again.
from gitlabform.
Related Issues (20)
- Support `job_token_scope` configuration HOT 6
- Improve logging by catching exceptions and printing helpful custom messages
- when running for a single group, its subgroups should be included HOT 2
- Enable automerge for dependency updates by dependabot HOT 2
- Migrate project:archive feature to use python-gitlab library HOT 1
- Migrate `integrations` feature to use python-gitlab library HOT 3
- Migrate `hooks` configuration feature to use python-gitlab library HOT 2
- Migrate `branches` configuration feature to use python-gitlab library HOT 1
- Migrate `files` configuration feature to python-gitlab library HOT 2
- Migrate project's `members` configuration feature to use python-gitlab library
- Migrate `resource_group` configuration feature to use python-gitlab library
- Migrate `schedules` configuration feature to use python-gitlab library
- Migrate `tags` configuration feature to use python-gitlab library HOT 1
- Migrate group's `group_members` configuration feature to use python-gitlab library HOT 1
- Change to protected_environment deploy_access_levels is not detected HOT 1
- Error while processing group sharing HOT 10
- Resource Groups - don't fail if key not exist HOT 10
- Use of expires_at in project members fails due to debug function HOT 4
- Project Transfer feature's few acceptance tests failing after GitLab 16.7 release HOT 2
- Add `enforce` support for `hooks` configuration HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitlabform.