Comments (4)
https://github.com/gjaldon/heroku-buildpack-phoenix-static/blob/master/lib/build.sh#L91 expects that the node_modules are inside the phoenix directory. This is what the phoenix_dir is https://github.com/gjaldon/heroku-buildpack-phoenix-static/blob/master/lib/common.sh#L40.
$build_dir/node_modules
refers to node_modules outside of the phoenix project's directory. How does your npm script
look like? Maybe you could change it to ensure that node_modules dir is going to be in phoenix?
from heroku-buildpack-phoenix-static.
Ah. That explains it. Yeah my node_modules is at the root of my umbrella app. My Phoenix app's Endpoint configuration uses a watchers
keyword entry that looks like watchers: [exit_on_eof: ["npm run watch"]]
which means it needs to be able to run an npm
script. When I move the package.json
down to the Phoenix directory and install the dependencies there, and then run mix phoenix.server
from the root of the umbrella, the watchers
command tries to run npm run watch
and looks for the package.json
at the root of the umbrella (where I started the app) and does not find it, since it's now in the Phoenix dir. Do you know how I can indicate where the package.json
is?
from heroku-buildpack-phoenix-static.
Adding a cd:
keyword list argument fixed my issue like so:
watchers: [exit_on_eof: ["npm run watch", cd: Path("../", __DIR__)]]
Thanks.
from heroku-buildpack-phoenix-static.
Great to hear you were able to find a solution!
On Thu, Nov 10, 2016 at 8:44 PM, Nikhil Tilwalli [email protected]
wrote:
Adding a cd: keyword list argument fixed my issue like so:
watchers: [exit_on_eof: ["npm run watch", cd: Path("../", DIR)]]
Thanks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#47 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABY-QvonUS6qZk08vsdMHXKWQ0RfPqn0ks5q8xGTgaJpZM4KuJ3n
.
Gabe Jaldon
from heroku-buildpack-phoenix-static.
Related Issues (20)
- Build is failing with NPM_TOKEN issue HOT 2
- My build just failed on phoenix.digest vs phx.digest HOT 1
- The build is failing if there is a .yarnrc with --cwd at the root HOT 1
- Support the new Cloud Native Buildpack (CNB) format.
- Files are compiled on startup
- New versions of node break the build HOT 17
- Remove default node_version
- Support for Yarn 2?
- Update heroku commands
- ngrok Error: certificate has expired HOT 3
- question about deployment to heroku with waypoint
- nodebin.herokai.com not resolving HOT 1
- Yarn error: "Command "deploy" not found." HOT 6
- Setup test suite and CI
- Heroku Build Fails HOT 2
- heroku build fails when node patch not specified HOT 4
- Improve error message below Phoenix 1.4?
- Is it possible to skip audit when building? HOT 3
- Is it possible to cache digested Phoenix output? HOT 4
- Installs an ancient version of yarn by default HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from heroku-buildpack-phoenix-static.