gjpc/combatanalysis

A Lord of the Rings Online Lua Plugin

combatanalysis's Issues

Add option to show damage numbers in normal number format

First of two issues, both damage number related. This one has to do with the number format used. The short number format uses modifiers K/M/B/T/Etc. Would it be possible to provide an option to change the format to show the actual number (Normal.Number in C++)?

CA should track an encounter's loot

CA already partitions the damage, buffs, damage accrued, etc into encounters.

It would be very helpful to present the user with all the acquired loot during an encounter.

Kinship command is different in french

here : https://github.com/gjpc/CombatAnalysis/blob/master/Locale/fr.lua#L401
the command to start talking to the kinship in the french client has changed to /k (like in the english client) instead of /conf

I can't submit a PR because it's changing the file encoding format :(

On-demand Stop Encounter

The ability to on-demand stop an encounter. This could then be added as a console command as
/ca stop encounter
People could then create a quickslot as follows
/shortcut # /ca stop encounter
Which would allow them to stop the encounter with a single keystroke.

I know this would be possible I'm just not show how to go about it.

Damage dealt by character option

Right now, Combat Analysis doesn't handle damage done over a character's entire time in game. It does the damage dealt on a per session basis. I'm wondering if there is a way to provide an option to show this over all sessions.

French version does not track individual skills

Most of the damages reported in the French damage box are not attributed to the skill that caused the damage.

The damage should be attributed to the specific skill.

Don't include .git folders inside archives

You leak your private data, your git config etc.

German skills not tracking

Some german skills are missing in CA
i dont play german client myself, but was reported that brawlers Fist of the Valar, and Beornings Execute (only the 2H version) is not working.
Might be also some others.

Saving the new normal/crit/devestate stats to the data file

@Ravdor any idea how to get your new damage categories into the save file?

Testing

Is there any unit testing for this project yet?

Would there be opposition to a PR to integrate busted?
https://olivinelabs.com/busted/

The graphics in the LoTRO Interface are out of date

The graphics in the Lotro Interface description are too old they need to be updated.