gkotian/git_scripts

git_scripts's Issues

Provide ability to only list the commits in a branch

(without actually doing any diff)

git contribs throws ValueError

When git-contribs is run against a clone of the oh-my-zsh repository, it throws this:

➜  oh-my-zsh (master) > git contribs   
                  Name                      Commits    Lines Added    Lines Deleted
Marc Cornellà                                  421         8424           5422
Robby Russell                                  132         1177            629
Andrew Janke                                    82         7612           2716
...
...
...
Traceback (most recent call last):
  File "/home/gautam/play/git_scripts/git-contribs", line 57, in <module>
    num_additions, num_deletions, file_name = stats_entry.split('\t')
ValueError: not enough values to unpack (expected 3, got 1)

use getopt to parse input arguments

Make fetch_pull_request.sh work with GitLab

fetch_pull_request.sh currently only works with GitHub PRs. It would be good to enhance it to support GitLab MRs as well.

Check whether the given branch is valid or not

Validate list of files given on the command line

When running the git_add_gui.sh script, a user is free to enter any filename(s). These filenames are currently not validated. Instead, they should be checked against the files listed in the output of git diff --name-only, and only matching files should be added to the FILES_LIST array.
If any files are not added, the user should be informed accordingly.

Provide ability to review the current branch

If the user is in a git repository and launches the script without a branch name, then ask the user if the current branch should be reviewed.

TBD: what if there are modified files in the current working copy. Include them in the diff or not?

Provide help text

clone.py

Refuse to clone if the destination directory already exists.

Show commit summary at diff confirmation

Currently, the diff confirmation is displayed as:

Found 11 commits in branch test
    Press enter to diff commit 1 (031939c)
    Press enter to diff commit 1 (7238cd2)

It would be nice for the user to have a one-line commit summary like:

Found 11 commits in branch test
    Press enter to diff commit 1 (031939c) - Remove trailing whitespaces
    Press enter to diff commit 1 (7238cd2) - Fix method header comment

Provide ability to diff the whole branch

(without diff'ing individual commits)

Only works from the top-level git directory

Throws some strange error if launched from anywhere else in the repo.

File appearing both as staged and not staged

When all the diffs in a file are staged using gag, then the file appears as both staged and not staged. Diff'ing the non-staged file shows no actual differences.

Show full commit message + number of files changed

I have often found the need to look at the full commit message when reviewing a pull request.

The number of changed files could give some idea of the time required for reviewing a commit.

Files get staged unnecessarily

If the git_add_gui.sh script is run, but all diffs are simply quit after being launched (i.e. no changes are actually added for staging), then it is observed that files still get staged.
Then on running git diff --staged, no changes are actually reported. This unnecessary staging should not happen at all.

Check if pull request exists before fetching

Provide ability to take a base as an optional argument

(instead of always assuming upstream/master as the base)

Provide ability to add a single file to the staging area

Currently the git_add_gui.sh script by default works on all modified files in the working copy. To add a single file, a user has to run the script, add the changes from the desired file, and manually exit the graphical diff of all the other files (without adding any changes from these other files).

Instead, the user should be able to specify which file(s) the script should consider for staging, much like how files can be given to git add when launching the command.