"glasgow --version" produces TypeError: entry_points() got an unexpected keyword argument 'group'

[txf-]

"glasgow --version" produces TypeError: entry_points() got an unexpected keyword argument 'group'

[whitequark]

That's really odd! Could you run pipx runpip glasgow freeze and post the output please?

[txf-]

Here:

amaranth @ git+https://github.com/amaranth-lang/amaranth.git@0c3ada62503359900f185a9b2d8f122b2d952013
amaranth-yosys==0.25.0.0.post77
appdirs==1.4.4
bitarray==2.8.1
click==8.1.7
colorama==0.4.6
fx2==0.11
-e git+https://github.com/GlasgowEmbedded/glasgow@17b22eafd48a55d5fa95f7f1fa9bddc835d30ad5#egg=glasgow&subdirectory=software
Jinja2==3.1.2
libusb1==3.0.0
MarkupSafe==2.1.3
packaging==23.2
pyvcd==0.4.0
wasmtime==13.0.2
yowasp-nextpnr-ice40==0.6.0.0.post445
yowasp-runtime==1.40
yowasp-yosys==0.33.0.0.post574

[whitequark]

Ah, looks like our software is currently broken on 3.9.

[txf-]

Which version of python do you recommend?

[whitequark]

We should just fix our software to work on 3.9. Someone will do this (possibly me) whenever available.

[whitequark]

I'm actually quite confused how you end up getting this error considering that we have continuous integration running on 3.9, so this isn't quite trivial to fix. It should already work! No idea why it doesn't.

[attie]

Which version of python do you recommend?

@txf- if you want to play before there is a fix, then 3.10 definitely works.

[emaste]

FWIW I see the same issue running glasgow on FreeBSD, w/ python 3.9.18

  File "/usr/home/emaste/src/glasgow/software/glasgow/support/plugin.py", line 71, in all
    return {ep.name: cls(ep) for ep in importlib.metadata.entry_points(group=cls.GROUP_NAME)}
TypeError: entry_points() got an unexpected keyword argument 'group'

[emaste]

On https://docs.python.org/3/library/importlib.metadata.html I see:

Compatibility Note

The “selectable” entry points were introduced in importlib_metadata 3.6 and Python 3.10. Prior to those changes, entry_points accepted no parameters and always returned a dictionary of entry points, keyed by group.

[SnoopJ]

Yep, the proximal cause here is that importlib.metadata.entry_points() didn't accept arguments until Python 3.10 (f917efc), but Glasgow is assuming this functionality is present.

An expedient fix would be to use the third-party importlib-metadata, or otherwise write two code paths depending on what Python version the software is running under.