glassbricks/kotlinbard

KotlinPoet extensions to provide a fluent kotlin DSL for code generation.

kotlinbard's Issues

Code block inside control flow not generating properly

Hey, first wanna say this project is awesome, much more readable than vanilla KotlinPoet!!

I think, however, there is currently a problem with nested control flows. A simple example

fun main() {
  val potatoFun = buildFunction("test") {
    addCode {
      controlFlow("if (1 == 1)") {
        controlFlow("if (2 == 2)") {
          addStatement("val nice = true")
          addStatement("val cool = true")
          addCode {
            addStatement("val amazing = false")
          }
        }
      }
    }
  }

  println(potatoFun.toString())
}

should, in theory, correspond to

fun test() {
  if (1 == 1) {
    if (2 == 2) {
      val nice = true
      val cool = true
      val amazing = false
    }
  }
}

However, currently, KotlinBard will generate the following

fun test() {
  val amazing = false
  if (1 == 1) {
    if (2 == 2) {
      val nice = true
      val cool = true
    }
  }
}

My project versions, if that helps, are
kotlin -> 1.4
kotlinPoet -> 1.6.0
kotlinBard -> 0.2.0

Compact element adding syntax

Here are some ideas possible more compact syntax for adding elements inside builders.

Current syntax:

buildElement(){
   addSubelement(){ }
}

Ideas to enhance this:

Use unaryPlus operator

val mySpec = element(){
  +subelement(){ }
}

Pros:

• Extra compact
• Separates "adding" from "building"
  • can easily do +mySpec or +mySpec.withModifications()
  • room for "prefix" modifiers, integrates well with new building syntax

Cons:

• Requires having own type to control scope (cannot be purely extension functions)
• Requires unique type to each "add" function; may have clashes
• May not always be obvious what is added (readability)
• easy to forget +

Use infix extension functions

val mySpec = element(){
   this add subelement(){ }
// or
   this addXXX subelement(){ }
}

Pros:

• Still separates "adding" from "building"
• Named function (clarity and dis-ambiguity)
• Can be just extension functions (or operator + )

Cons:

• Clunky syntax (restating this repeatedly)
• Possibly more words than necessary

Just remove 'add' prefix

val mySpec = buildElement(){
   subelement(){ }
}

Pros:

• Named function
• Can be just extension functions

Cons:

• Adding and building put together
• Need separate functions for only adding and only building
• Doesn't express "adding"

Publish to Maven central due to Jcenter decommission

JFrog announced decommission: https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/

Here example of how I moved from bintray to maven central: mfarsikov/kotlite@1194559#diff-c0dfa6bc7a8685217f70a860145fbdf416d449eaff052fa28352c5cec1a98c06