gleb-chipiga/backoff-stubs

Type annotations for Python library providing function decorators for configurable backoff and retry

backoff-stubs's Issues

MyPy raises `Missing positional argument "predicate" in call to "on_predicate"`

The on_predicate argument is defaulted to operator.not_ in version 1.10.0 of backoff:

def on_predicate(wait_gen,
                 predicate=operator.not_,
                 max_tries=None,
                 max_time=None,
                 jitter=full_jitter,
                 on_success=None,
                 on_backoff=None,
                 on_giveup=None,
                 logger='backoff',
                 **wait_gen_kwargs):

MyPy shows this error if predicate is not provided:

error: Missing positional argument "predicate" in call to "on_predicate"

The stub for on_predicate defines predicate as a required positional argument, instead of a defaulted optional argument:

def on_predicate(
    wait_gen: Callable[..., Generator[float, None, None]],
    predicate: Callable[[Any], bool],
    max_tries: Optional[int] = ...,
    max_time: Optional[int] = ...,
    jitter: Callable[[float], float] = ...,
    on_success: Optional[_EventHandler] = ...,
    on_backoff: Optional[_EventHandler] = ...,
    on_giveup: Optional[_EventHandler] = ...,
    logger: Union[str, logging.Logger, None] = ...,
    **wait_gen_kwargs: Any
) -> Callable[[_FuncT], _FuncT]: ...