globaltradingtechnologies/workflow-extensions-bundle

Bundle for extended workflow management and automation

workflow-extensions-bundle's Issues

[Feature] Add subject to the guard expressions

I find my self writing a lot of event.getSubject() in guard expressions. Wouldn't it be a good option to add this to the expression context in

workflow-extensions-bundle/Guard/ExpressionGuard.php

Line 123 in 5266c0c

$expressionResult = $this->language->evaluate($expression, ['event' => $event]);

Every GuardEvent has a subject. This would make my expressions a bit more readable.

Fix tests

Since workflow configuration issue is fixed now (symfony/symfony#20760) we should fix tests by using new symfony/framework-bundle version in tests

Port to Messenger for the scheduledjobs and async events

Are there any plans or a roadmap to support different job queues?

Symfony messenger is moving forward to really stable, so it would be very nice if the JMS JobQueue can be replaced by the messenger.

And pls dont get me wrong, im a fan of JMS JobQueue ;)

Cheers,
Andreas

Feature: add workflow subject as relatedEntity to the JMS Job

In our workflow setup we have some scheduled transitions for reminders we a subject enters a certain place, but we would like to clean those scheduled jobs if the subjects leaves the place using a different (or the same, but not scheduled) transition.

For this functionality I like to use the JMS Job repository like so:

$jobRepository = $entityManager->getRepository(Job::class);
$relatedJobs = $jobRepository->findAllForRelatedEntity($subject);

The current implementation of the ActionScheduler doesn't set the related entity on the JMS Job like:

$jobToSchedule->addRelatedEntity($workflowContext->getSubject());

Is there a specific reason that the related entity is not set or is a pull request welcome?

Error entity not found

$  ./bin/console doctrine:schema:create
[Doctrine\ORM\Mapping\MappingException]                                                           
  The target-entity JMS\JobQueueBundle\Entity\Job cannot be found in 'Gtt\Bundle\WorkflowExtension  
  sBundle\Entity\ScheduledJob#job'.

Can this bundle work without JMS\JobQueueBundle?

Wrong package configuration

This bundle is incompatible with symfony3.2

$ composer require gtt/workflow-extensions-bundle
Using version ^0.1.0 for gtt/workflow-extensions-bundle
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - fduch/workflow-bundle 0.1.0 conflicts with symfony/symfony[v3.2.0].
    - fduch/workflow-bundle 0.1.0 conflicts with symfony/symfony[v3.2.0].
    - fduch/workflow-bundle 0.1.0 conflicts with symfony/symfony[v3.2.0].
    - gtt/workflow-extensions-bundle 0.1.0 requires fduch/workflow-bundle ^0.1 -> satisfiable by fduch/workflow-bundle[0.1.0].
    - Installation request for gtt/workflow-extensions-bundle ^0.1.0 -> satisfiable by gtt/workflow-extensions-bundle[0.1.0].
    - Installation request for symfony/symfony ^3.2.0 -> satisfiable by symfony/symfony[v3.2.0].


Installation failed, reverting ./composer.json to its original content.