globox1997/jobsaddon

https://modrinth.com/mod/jobsaddon

jobsaddon's Issues

Crash when clicking on job

Minecraft crashes when selecting a job in the jobs tab. Mod version: 1.0.8

---- Minecraft Crash Report ----
// This is a token for 1 free hug. Redeem at your nearest Mojangsta: [HUG]
Time: 2023-02-07 07:03:34
Description: Rendering screen
java.lang.NullPointerException: Cannot invoke "net.minecraft.class_1799.method_7950(net.minecraft.class_1657, net.minecraft.class_1836)" because "$$0" is null
at net.minecraft.class_437.method_25408(class_437.java:181)
at net.minecraft.class_437.constant$dmm000$renderTooltipFromComponentsColorTwoMixin(class_437.java:770)
at net.minecraft.class_437.method_32633(class_437.java:231)
at net.minecraft.class_437.method_25417(class_437.java:193)
at io.github.cottonmc.cotton.gui.widget.WWidget.renderTooltip(WWidget.java:356)
at io.github.cottonmc.cotton.gui.client.CottonClientScreen.method_25394(CottonClientScreen.java:146)
at net.jobsaddon.gui.JobsScreen.method_25394(JobsScreen.java:46)
at net.minecraft.class_757.method_3192(class_757.java:881)
at net.minecraft.class_310.method_1523(class_310.java:1177)
at net.minecraft.class_310.method_1514(class_310.java:768)
at net.minecraft.client.main.Main.method_44604(Main.java:244)
at net.minecraft.client.main.Main.main(Main.java:51)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88)
at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126)
at org.prismlauncher.EntryPoint.main(EntryPoint.java:71)

Mods list:
- additionz 1.1.3
- advanced_runtime_resource_pack 0.6.4
- adventurez 1.4.17
- amecsapi 1.3.6+mc22w17a via backslot
- autotag 2.0.0+1.19 via autotag-convention
- autotag-convention 2.0.0+1.19
- backslot 1.2.11
- backslotaddon 1.0.10
- blue_endless_jankson 1.2.1 via owo
- caffeineconfig 1.0.0+1.17 via sodium-extra
- cloth-basic-math 0.6.1 via cloth-config
- cloth-config 8.2.88
- dehydration 1.3.3
- dragonloot 1.1.2
- dualwielding 1.1.2
- dynamicfps 2.2.0
- earlystage 1.0.5
- environmentz 1.3.5
- eventmod 1.0.5
- fabric-api 0.73.2+1.19.2
- fabricloader 0.14.14
- fabricshieldlib 1.6.1-1.19
- ferritecore 5.0.3
- fiber 0.23.0-2 via patchouli
- fireplacemode 1.0.5
- forgeconfigapiport 4.2.10
- herdspanic 1.0.6
- indium 1.0.9+mc1.19.2
- inmis 2.7.1-1.19
- inmisaddon 1.0.3
- io_github_douira_glsl-transformer 2.0.0-pre9 via iris
- iris 1.5.2
- jankson 4.1.1+j1.2.1 via libgui
- java 17
- jobsaddon 1.0.8
- lazydfu 0.1.3
- levelz 1.4.4
- libgui 6.0.1+1.19 via levelz
- libninepatch 1.1.0 via libgui
- lithium 0.10.4
- medievalweapons 1.4.2
- minecraft 1.19.2
- mm 2.3 via fabricshieldlib
- mobz 3.3.5
- modmenu 4.1.2
- nameplate 1.0.10
- numismatic-overhaul 0.2.8+1.19
- numismaticclaim 1.0.4
- omega-config 1.2.3-1.18.1 via inmis
- openpartiesandclaims 0.16.6
- owo 0.9.3+1.19
- patchouli 1.19.2-77-FABRIC
- patchoulibutton 1.0.2
- reach-entity-attributes 2.3.0 via medievalweapons
- reciperemover 1.0.5
- reeses-sodium-options 1.4.9+mc1.19.2-build.67
- revive 1.0.5
- rotten 1.4.7
- rpgdifficulty 1.3.5
- satin 1.8.0 via environmentz
- sodium 0.4.4+build.18
- sodium-extra 0.4.16+mc1.19.2-build.90
- stacc 1.3.3 via numismatic-overhaul
- starlight 1.1.1+fabric.ae22326
- talkbubbles 1.0.4
- tiered 1.2.1
latest.log

- tooltiprareness 1.0.7
- villagerfix 1.0.3
- villagerquests 1.0.7
- voidz 1.0.9

Ports to 1.18.2

Hi,

Will there any chance this gets ports to 1.18.2?

thanks,

[Compat] JobsAddon with Farmer's Delight

I've tried to create a datapack that supports Farmer's Delight crops for the Farming profession but nothing works. I got the wild variations of the plants (Wild Cabbage, Wild Onion... etc) to work properly but the crops themselves don't produce any experience. I've attached my configuration below for reference.

File location:
datapack\data\jobsaddon\farmer\farmersdelight.json

Uploaded as a .txt because Github doesn't support .json uploads
farmersdelight.txt

Compatibility with Panda's Falling Tree's

Make sure you are not opening a duplicate.

• I have searched the issue tracker and did not find an issue describing my bug.

Description of your suggestion.

Doesn't give exp when tree's are cut using https://modrinth.com/mod/pandas-falling-trees

Mining Skill Not Working (mining stone)

When you max out the mining skill, or on any other level of mining you can never mine stone. Version is 1.19.2

Add Compatibility for HT's TreeChop

Make sure you are not opening a duplicate.

• I have searched the issue tracker and did not find an issue describing my bug.

Description of your suggestion.

Please add compatibility for the following mod:
https://www.modrinth.com/mod/treechop

The Lumberjack profession grows way too slow to mae it usable, and I suspect it's because the player isn't technically chopping logs.

While I would ideally see integration out of the box in the future, for now I would really appreciate a Datapack to solve this issue.

Translating to russian language

Make sure you are not opening a duplicate.

• I have searched the issue tracker and did not find an issue describing my bug.

Description of your suggestion.

I suggest adding Russian localization to the mod and I'm ready to help with the translation. That`s all

[bug] Infinite exp glitch

It is possible to get infinite smithing experience by repeatedly crafting iron ingots into iron blocks and back.

Should also work with nuggets but is not as profitable.

An option to not reward when crating the item could mitigate this.

[Feature request] add support for Midnight Controls

Hey there,
I'm currently playing Minecraft on my Steam Deck with your mod and Midnight Controls installed and noticed that the Jobs menu isn't navigatable using the controller.
It would be cool if you could add support for Midnight Controls. :)

I already opened an issue on their GitHub issue tracker: TeamMidnightDust/MidnightControls#163

Crash when selecting a job

Crashes whole client when selecting any job in the jobs tab.

latest.log
crash-2022-09-28_11.23.45-client.txt

Smither Exp Exploit

Minecraft Version

1.19.x

Mod Loader Version

Quilt

Mod Version

jobsaddon-1.1.0+1.19.2

Describe the Issue

Job: Smither

Issue: You can have infinite loop of creating wheat to Hay Bale, and Hay Bale to wheat, but each time you create it into Hay Bale, it gives exp.

latest.log

NA

Do you use any other mods except the required ones?

No response

Compatibility with "FallingTree"

When you cut trees with the mod "FallingTree" the LumberJack job doesnt recognise that you have cuted a tree

[Compat] JobsAddon and Harvest Scythes

Harvest Scythes currently yields no experience with JobsAddon's Farming profession

Blacksmith level are easy to obtain

Make sure you are not opening a duplicate.

• I have searched the issue tracker and did not find an issue describing my bug.

Description of your suggestion.

The Blacksmith level can be quickly achieved at around 30 by synthesizing dyes with flowers

Mixin crashing with new versions of TreeChop

Minecraft Version

1.19.x

Mod Loader Version

NA

Mod Version

NA

Describe the Issue

Crash at startup when using both JobsAddon and TreeChop 0.18.3(+). Reported to me in hammertater/treechop#216. The root cause is a mixin for an internal TreeChop class that has changed in a recent update, same problem as described in Globox1997/LevelZ#191. I only glanced at your code, but I think the TreeChop event AFTER_CHOP (https://github.com/hammertater/treechop/blob/main/fabric/src/main/java/ht/treechop/api/TreeChopEvents.java) should work for your compatibility. I'd be happy to help if anything isn't clear, or if the API needs to be expanded

The problem was reported for Minecraft 1.19.2, but I expect it'll also crash for 1.20.

latest.log

See the crash log in hammertater/treechop#216

Do you use any other mods except the required ones?

No response

No LevelZ experience is gained with mod

Hey there,
I have this mod installed alongside the other two mentioned mods and while I do earn money (not a lot though) I didn't earn any levelz experience to unlock abilities.
I haven't changed the configs of these files.
Is there anything I forgot?

Trying to recompile after editting the JobsAddonConfig.class, won't allow me

Minecraft Version

1.19.x

Mod Loader Version

0.14.19

Mod Version

1.1.1

Describe the Issue

The jobsaddon.json5 config file isn't properly applying its edits to my server, so I decided to see if there was something i could edit in the java file itself and I found JobsAddonConfig with all the config values at default. I changed what I felt was balanced and adequate, but after trying to recompile using javac JobsAddonConfig.java and javac -Xlint:unchecked JobsAddonConfig.java I've made no progress and it wont let me proceed further.

Here's the command prompt error:

latest.log

JobsAddonConfig.java:6: error: package me.shedaniel.autoconfig does not exist
/* / import me.shedaniel.autoconfig.ConfigData;
^
JobsAddonConfig.java:7: error: package me.shedaniel.autoconfig.annotation does not exist
/ / import me.shedaniel.autoconfig.annotation.Config;
^
JobsAddonConfig.java:8: error: package me.shedaniel.autoconfig.annotation.Config.Gui does not exist
/ / import me.shedaniel.autoconfig.annotation.Config.Gui.Background;
^
JobsAddonConfig.java:9: error: package me.shedaniel.autoconfig.annotation.ConfigEntry does not exist
/ / import me.shedaniel.autoconfig.annotation.ConfigEntry.Category;
^
JobsAddonConfig.java:10: error: package me.shedaniel.cloth.clothconfig.shadowed.blue.endless.jankson does not exist
/ / import me.shedaniel.cloth.clothconfig.shadowed.blue.endless.jankson.Comment;
^
JobsAddonConfig.java:14: error: cannot find symbol
/ / public class JobsAddonConfig implements ConfigData {
^
symbol: class ConfigData
JobsAddonConfig.java:12: error: cannot find symbol
/ / @config(name = "jobsaddon")
^
symbol: class Config
JobsAddonConfig.java:13: error: cannot find symbol
/ / @background("minecraft:textures/block/stone.png")
^
symbol: class Background
JobsAddonConfig.java:15: error: cannot find symbol
/ / @comment("Count for how many jobs can a player have at a time")
^
symbol: class Comment
location: class JobsAddonConfig
JobsAddonConfig.java:18: error: cannot find symbol
/ / @comment("Delay to employ new job")
^
symbol: class Comment
location: class JobsAddonConfig
JobsAddonConfig.java:21: error: cannot find symbol
/ / @comment("Reset current job lvl xp when died")
^
symbol: class Comment
location: class JobsAddonConfig
JobsAddonConfig.java:24: error: cannot find symbol
/ / @comment("Only for Devs")
^
symbol: class Comment
location: class JobsAddonConfig
JobsAddonConfig.java:27: error: cannot find symbol
/ / @category("experience_settings")
^
symbol: class Category
location: class JobsAddonConfig
JobsAddonConfig.java:28: error: cannot find symbol
/ / @comment("Max level of each job")
^
symbol: class Comment
location: class JobsAddonConfig
JobsAddonConfig.java:31: error: cannot find symbol
/ / @category("experience_settings")
^
symbol: class Category
location: class JobsAddonConfig
JobsAddonConfig.java:32: error: cannot find symbol
/ / @comment("XP equation: lvl^exponent * multiplicator + base")
^
symbol: class Comment
location: class JobsAddonConfig
JobsAddonConfig.java:35: error: cannot find symbol
/ / @category("experience_settings")
^
symbol: class Category
location: class JobsAddonConfig
JobsAddonConfig.java:38: error: cannot find symbol
/ / @category("experience_settings")
^
symbol: class Category
location: class JobsAddonConfig
JobsAddonConfig.java:41: error: cannot find symbol
/ / @category("experience_settings")
^
symbol: class Category
location: class JobsAddonConfig
JobsAddonConfig.java:44: error: cannot find symbol
/ / @category("experience_settings")
^
symbol: class Category
location: class JobsAddonConfig
JobsAddonConfig.java:45: error: cannot find symbol
/ / @comment("Default xp per job execution")
^
symbol: class Comment
location: class JobsAddonConfig
JobsAddonConfig.java:48: error: cannot find symbol
/ / @category("experience_settings")
^
symbol: class Category
location: class JobsAddonConfig
JobsAddonConfig.java:51: error: cannot find symbol
/ / @category("experience_settings")
^
symbol: class Category
location: class JobsAddonConfig
JobsAddonConfig.java:54: error: cannot find symbol
/ / @category("experience_settings")
^
symbol: class Category
location: class JobsAddonConfig
JobsAddonConfig.java:57: error: cannot find symbol
/ / @category("experience_settings")
^
symbol: class Category
location: class JobsAddonConfig
JobsAddonConfig.java:60: error: cannot find symbol
/ / @category("experience_settings")
^
symbol: class Category
location: class JobsAddonConfig
JobsAddonConfig.java:63: error: cannot find symbol
/ / @category("experience_settings")
^
symbol: class Category
location: class JobsAddonConfig
JobsAddonConfig.java:66: error: cannot find symbol
/ / @category("experience_settings")
^
symbol: class Category
location: class JobsAddonConfig
JobsAddonConfig.java:69: error: cannot find symbol
/ / @category("reward_settings")
^
symbol: class Category
location: class JobsAddonConfig
JobsAddonConfig.java:72: error: cannot find symbol
/ / @category("reward_settings")
^
symbol: class Category
location: class JobsAddonConfig
JobsAddonConfig.java:75: error: cannot find symbol
/ / @category("reward_settings")
^
symbol: class Category
location: class JobsAddonConfig
JobsAddonConfig.java:76: error: cannot find symbol
/ / @comment("Numismatic Overhaul compat lvl * multiplicator")
^
symbol: class Comment
location: class JobsAddonConfig
JobsAddonConfig.java:82: warning: [unchecked] unchecked call to ArrayList(Collection<? extends E>) as a member of the raw type ArrayList
/ 64 / return new ArrayList(Arrays.asList((Object[])new Serializable[] {
^
where E is a type-variable:
E extends Object declared in class ArrayList
JobsAddonConfig.java:82: warning: [unchecked] unchecked conversion
/ 64 */ return new ArrayList(Arrays.asList((Object[])new Serializable[] {
^
required: ArrayList
found: ArrayList
32 errors
2 warnings

Do you use any other mods except the required ones?

Indubitably