globus/globus-publish-dspace

globus-publish-dspace's Issues

Missing LICENSE file

Hi Jim, I don't see a LICENSE file or any other indication as to what license this source code is released under. Also in checking Dspace source, I think you need to pull in a copy of this:

https://github.com/DSpace/DSpace/blob/master/LICENSE

Improper Globus Auth redirect links

In some cases, such as item landing pages for protected (i.e not all readable) items, following a link to the item causes fault re-direct URL to be generated which Auth will throw back as invalid. See, for example, following report text:

Todd Trann, Dec 16, 14:45 CST:

For example, this works:
https://frdr-alpha.computecanada.ca/jspui/handle/ITEM/6

But this does not (as long as you are not logged in):
https://frdr-alpha.computecanada.ca/jspui/handle/ITEM/5

The difference in these two items is that item 5 is under embargo. We don't see anything useful in our logs to help us. Can you?

Thanks,
Todd

One cause of this is certainly the way that the redirect URL is getting generated. It is based on the URL of the HttpServletRequest object, but in cases where there are, for example, both http and https are supported (and auth requires https), this can results in a bad redirect URL if the http method was used to access the page. (note, this https example doesn't satisfy the requirement in the above message). None the less, moving to redirect based on the already defined dspace.url config parameter rather than the URL in the request seems like a good idea.

collection name validity checking

It's possible for collections to get created with no name, or all whitespace names, or probably other things that make working with the collection later harder. Add some validity checking on collection creation/update to avoid these situations.

globus_publish missing

The git repository for globus_publish is missing. Where can I find it?

webapp links

With the Globus WebApp changes, we need to update all the links that go out to Transfer and possibly the helper pages.

@blaiszik For your tracking purposes

Remove references to GoAuth

anonymous missing from PrinicpalType list

PrincipalType list in TransferInterface is missing the enum value for anonymous.