glorpen/kimai-duration-plugin

Enables setting duration rounding option (same as global one) to override rounding for any Customer, Project or Activity.

Overridable Duration Rounding for Kimai2

Enables setting duration rounding option (same as global one) to override rounding for any Customer, Project or Activity.

Plugin version	Supported Kimai version
1.x	1.x
2.x	2.x

Installation

Checkout plugin into var/plugins/GlorpenDurationBundle & clear cache.

Run bin/console kimai:bundle:glorpen-duration:install.

Usage

After installation, existing Rounding methods will be extended with new functionality. When editing any Customer, Project or Activity you can set Rounding of the duration in minutes option to override global one.

kimai-duration-plugin's Issues

PHP Exception / Kimai 2 (1.19.6)

After installing on current Kimai 1.19.6, I've got a problem

[2022-05-05 08:33:03] request.CRITICAL: Uncaught PHP Exception Symfony\Component\Form\Exception\InvalidArgumentException: "The name "glorpen.duration" contains illegal characters. Names should start with a letter, digit or underscore and only contain letters, digits, numbers, underscores ("_"), hyphens ("-") and colons (":")." at /var/www/clients/clienX/webXXXX/web/vendor/symfony/form/FormConfigBuilder.php line 782 {"exception":"[object] (Symfony\\Component\\Form\\Exception\\InvalidArgumentException(code: 0): The name \"glorpen.duration\" contains illegal characters. Names should start with a letter, digit or underscore and only contain letters, digits, numbers, underscores (\"_\"), hyphens (\"-\") and colons (\":\"). at /var/www/clients/clientX/webXXXX/web/vendor/symfony/form/FormConfigBuilder.php:782)"} []
[2022-05-05 08:33:03] request.INFO: Matched route "admin_activity_edit". {"route":"admin_activity_edit","route_parameters":{"_route":"admin_activity_edit","_controller":"App\\Controller\\ActivityController::editAction","_locale":"de","id":"1"},"request_uri":"https://xxx/de/admin/activity/1/edit","method":"GET"} []

kimai-duration-plugin/Timesheet/Rounding/OverriddenDurationRounding.php

Line 19 in 80840cf

public const META_FIELD_NAME = 'glorpen.duration';

Solution
changed 'glorpen.duration' to 'glorpen_duration'

PHP Fatal error: Incompatible Declaration

Hi there, thanks for the plugin! Just wanted to let you know that there is an issue when I try to reload the cache after the plugin has been cloned.

I have created a PR #4 with an untested fix. It would be great if you gave it a glance whenever possible.

PHP Fatal error:  Declaration of KimaiPlugin\GlorpenDurationBundle\Timesheet\Rounding\OverriddenDurationRounding::roundBegin(App\Entity\Timesheet $record, int $minutes): void must be compatible with App\Timesheet\Rounding\RoundingInterface::roundBegin(App\Entity\Timesheet $record, $minutes) in /opt/kimai/var/plugins/GlorpenDurationBundle/Timesheet/Rounding/OverriddenDurationRounding.php on line 72
[2023-05-07 20:41:09] php.CRITICAL: Fatal Compile Error: Declaration of KimaiPlugin\GlorpenDurationBundle\Timesheet\Rounding\OverriddenDurationRounding::roundBegin(App\Entity\Timesheet $record, int $minutes): void must be compatible with App\Timesheet\Rounding\RoundingInterface::roundBegin(App\Entity\Timesheet $record, $minutes) {"exception":"[object] (Symfony\\Component\\ErrorHandler\\Error\\FatalError(code: 0): Compile Error: Declaration of KimaiPlugin\\GlorpenDurationBundle\\Timesheet\\Rounding\\OverriddenDurationRounding::roundBegin(App\\Entity\\Timesheet $record, int $minutes): void must be compatible with App\\Timesheet\\Rounding\\RoundingInterface::roundBegin(App\\Entity\\Timesheet $record, $minutes) at /opt/kimai/var/plugins/GlorpenDurationBundle/Timesheet/Rounding/OverriddenDurationRounding.php:72)"} []

In OverriddenDurationRounding.php line 72:

  [Symfony\Component\ErrorHandler\Error\FatalError]
  Compile Error: Declaration of KimaiPlugin\GlorpenDurationBundle\Timesheet\Rounding\OverriddenDurationRounding::roundBegin(
  App\Entity\Timesheet $record, int $minutes): void must be compatible with App\Timesheet\Rounding\RoundingInterface::roundB
  egin(App\Entity\Timesheet $record, $minutes)


Exception trace:
  at /opt/kimai/var/plugins/GlorpenDurationBundle/Timesheet/Rounding/OverriddenDurationRounding.php:72

Support for Kimai 2.0.0

Are there any plans this plugin will support Kimai 2.0.0 and up?