gmamar/homework

HomeWork

homework's Issues

Don't use <br> for layout stuff

This is eseentially styling the document, placing elements in a specific spot and is a semantic error. You can use CSS to position the fields in the form.

The profileInformation array may seem useful but its abstracting meaning

If you look at it, info.html_url is more readable than info[profileInformation[3]].
I understand it's rally useful for the addFullInfo function but you can get all the info in a different way. If you want to print all the keys of an object and their values you can use this:

for (var i in myObject)
{
	console.log("key: " + i + " value: " myObject[i]);
}

Try to use descriptive variable names

I have no idea what an sBTN is. Try to give your elements names that other people will understand.

Good job reusing the mainRequest function

Pretty smart to look at what the response look like and then to call a different function based on that.
Alternatively, you could pass two parameters to mainRequest. 1 being the targetPage and 2 being the callback function. That way you can tell mainRequest which function to pass the resulting data to. This is also described in the week 6 assignment.

Good job setting up polling

That's pretty cool, you figured out how to load new info every 60 seconds. You should probably add a check though, to see if a username has been filled in after a minute. Now when you leave the page open without doing anything it tries to get the data for an empty user and that generates an error.

Looks like you got quite far already

It seems like you finished most of last weeks homework but haven't gotten around to this weeks homework yet.

Please add a description to your Repo

As per Github conventions, please include both a short description as well as a readme detailing the use of your repository.

Don't use capitalization for variable names

I know this sounds like its not important but it really helps if you stick to the standards. So "Info" should probably be something like repoInfo or at least info.

The interaction with the page is a bit janky

This means the content "jumps around" based on what the user does. It's unpredictable and confusing for a user. You can solve this by creating a layout in CSS with a set size and then when the js fills op the html it wont jump around anymore. Think back to the classes on flexbox for instance.

Please put code comments above functions

//It's easier to read
function killAllPuppies(){
}

the mouseover function is quite advanced

Nice job on checking for issues. You might want to use a .forEach instead of that forloop.