gmorpheme/lein-githooks

Leiningen plugin for managing client git hooks.

lein-githooks's Issues

Wrong arity with hooks with arguments

Hey! Thanks for creating this library! I've found that using this hook:

:githooks {:auto-install false
           :pre-commit   ["lein eastwood \"{:namespaces [:source-paths]}\""]}}

Will end with the following message:

#'lein-githooks.plugin/hooks
Running pre-commit hook.
Wrong number of arguments to eastwood task.
Expected [] or [opts]
:pre-commit hook failed.

I've investigated a little and found that https://github.com/gmorpheme/lein-githooks/blob/master/src/leiningen/githooks.clj#L135 is splitting the arguments by "space". In my case this is generating this output:

user=> (clojure.string/split "lein eastwood \"{:namespaces [:source-paths]}\"" #"\W+")
["lein" "eastwood" "namespaces" "source" "paths"]

But, in order to work properly, have to be this:

["lein" "eastwood" "\"{:namespaces [:source-paths]}\""]

I think only changing the regex it should work :)

Incorrect split happening for command

Because of the split happening while executing command, i can't execute a script located in any directory because / in path will be used to split the command which doesn't make sense.

lein-githooks/src/leiningen/githooks.clj

Line 135 in 71a48e0

(let [exit-code (apply sh (string/split cmd #"\W+"))]

What's the use case to split a command? why can't we simple execute it as it is?