go-vela/worker

Worker for Vela (Target's official Pipeline Automation Framework)

worker's Issues

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Cannot find preset's package (github>whitesource/merge-confidence:beta)

Builds without steps should not spawn

Description

Vela should refrain from spawning builds that have no valid steps

Steps to Reproduce

push to master

vela.yml:

steps:
  - name: dont_run
    image: golang:latest
    commands:
      - echo "do not run"
    ruleset:
      branch: [ nonexistent_branch ]

Value

Reduce on builds, avoid false-negative status checks, etc

Definition of Done

When a build should have no steps to run based on rulesets etc, that build should not be created

Step with status: failure doesn't get triggered

Consider the following pipeline:

version: "1"

steps:
  - name: failing
    image: alpine:latest
    commands:
      - sleep 5 && echo "failing the build" && exit 1
  - name: run on failure
    image: alpine:latest
    ruleset:
      status: [failure,pending]
    commands:
      - echo "i show on build failure"

In this scenario the build fails successfully, but "run on failure" never runs.

Update urfave/cli to v2

Description

What is your idea?

Update our urfave/cli library to the v2 functionality.

https://github.com/urfave/cli#using-v2-releases

Value

Why is this important? Who does it impact? Will this make something better, faster, etc?

• Reduce technical debt

Definition of Done

What is the end goal of this story?

This repo is using the v2 branch of the urfave/cli library.

Effort (Optional)

Estimated effort to complete this story? (Best Guess e.g. 1-2 days)

N/A

implement a kubernetes runtime for linux executor

Description

What is your idea?

Value

Why is this important? Who does it impact? Will this make something better, faster, etc?

Definition of Done

What is the end goal of this story?

Effort (Optional)

Estimated effort to complete this story? (Best Guess e.g. 1-2 days)

Impacted Personas (Optional)

Which personas will benefit from completing this story? (Users, Administrators, etc)

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Edited/Blocked

These updates have been manually edited so Renovate will no longer make changes. To discard all commits and start over, click on a checkbox.

• fix(deps): update module github.com/docker/docker to v25

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update all non-major dependencies (codecov/codecov-action, github.com/golang-jwt/jwt/v5, github.com/prometheus/client_golang, github/codeql-action, reviewdog/action-golangci-lint)

Detected dependencies

dockerfile

Dockerfile

• alpine 3.19.1@sha256:c5b1261d6d3e43071626931fc004f70149baeba2c8ec672bd4f27761f8e1ad6b

Dockerfile-alpine

• alpine 3.19.1@sha256:c5b1261d6d3e43071626931fc004f70149baeba2c8ec672bd4f27761f8e1ad6b

github-actions

.github/workflows/build.yml

• actions/checkout v4.1.1@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-go v5.0.0@0c52d547c9bc32b1aa3301fd7a9cb496313a4491

.github/workflows/codeql-analysis.yml

• actions/checkout v4.1.1@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-go v5.0.0@0c52d547c9bc32b1aa3301fd7a9cb496313a4491
• github/codeql-action v3.24.5@47b3d888fe66b639e431abf22ebca059152f1eea
• github/codeql-action v3.24.5@47b3d888fe66b639e431abf22ebca059152f1eea
• github/codeql-action v3.24.5@47b3d888fe66b639e431abf22ebca059152f1eea

.github/workflows/prerelease.yml

• actions/checkout v4.1.1@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-go v5.0.0@0c52d547c9bc32b1aa3301fd7a9cb496313a4491
• elgohr/Publish-Docker-Github-Action v5@eb53b3ec07136a6ebaed78d8135806da64f7c7e2
• elgohr/Publish-Docker-Github-Action v5@eb53b3ec07136a6ebaed78d8135806da64f7c7e2

.github/workflows/publish.yml

• actions/checkout v4.1.1@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-go v5.0.0@0c52d547c9bc32b1aa3301fd7a9cb496313a4491
• elgohr/Publish-Docker-Github-Action v5@eb53b3ec07136a6ebaed78d8135806da64f7c7e2
• elgohr/Publish-Docker-Github-Action v5@eb53b3ec07136a6ebaed78d8135806da64f7c7e2

.github/workflows/reviewdog.yml

• actions/checkout v4.1.1@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-go v5.0.0@0c52d547c9bc32b1aa3301fd7a9cb496313a4491
• reviewdog/action-golangci-lint v2.6.0@8e1117c7d327bbfb1eb7ec8dc2d895d13e6e17c3
• actions/checkout v4.1.1@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-go v5.0.0@0c52d547c9bc32b1aa3301fd7a9cb496313a4491
• reviewdog/action-golangci-lint v2.6.0@8e1117c7d327bbfb1eb7ec8dc2d895d13e6e17c3

.github/workflows/spec.yml

• actions/checkout v4.1.1@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-go v5.0.0@0c52d547c9bc32b1aa3301fd7a9cb496313a4491

.github/workflows/test.yml

• actions/checkout v4.1.1@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-go v5.0.0@0c52d547c9bc32b1aa3301fd7a9cb496313a4491
• codecov/codecov-action v4.0.2@0cfda1dd0a4ad9efc75517f399d859cd1ea4ced1

.github/workflows/validate-pr-title.yml

.github/workflows/validate.yml

• actions/checkout v4.1.1@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-go v5.0.0@0c52d547c9bc32b1aa3301fd7a9cb496313a4491

gomod

go.mod

• go 1.21
• github.com/Masterminds/semver/v3 v3.2.1
• github.com/distribution/reference v0.5.0
• github.com/docker/docker v24.0.9+incompatible
• github.com/docker/go-units v0.5.0
• github.com/gin-gonic/gin v1.9.1
• github.com/go-vela/sdk-go v0.23.1
• github.com/go-vela/server v0.23.1
• github.com/go-vela/types v0.23.1
• github.com/golang-jwt/jwt/v5 v5.2.0
• github.com/google/go-cmp v0.6.0
• github.com/joho/godotenv v1.5.1
• github.com/opencontainers/image-spec v1.1.0
• github.com/prometheus/client_golang v1.18.0
• github.com/sirupsen/logrus v1.9.3
• github.com/urfave/cli/v2 v2.27.1
• golang.org/x/sync v0.6.0
• gotest.tools/v3 v3.5.1
• k8s.io/api v0.29.2
• k8s.io/apimachinery v0.29.2
• k8s.io/client-go v0.29.2
• sigs.k8s.io/yaml v1.4.0

---

• Check this box to trigger a request for Renovate to run again on this repository

Step is scrubbed when status is used in ruleset without "pending"

When you define a step with ruleset such as:

ruleset:
  status: [success, failure]

the step is scrubbed from ever running.

Currently, you have to supply pending as a status for it to not get scrubbed at compile time, like:

ruleset:
  status: [success, failure, pending]

Consider dropping the need to supply pending since it really works a bit differently conceptually than the other values.

Possible solutions:

• don't check status for scrubbing
• add pending automagically
• others?