Shared Locking?

[gofrs]

Shared Locking?

[theory]

Would we need a separate object? Otherwise Locked() is ambiguous.

[theckman]

I don't see a reason why the support couldn't be extended to allow advisory (shared) locks. My initial implementation was built to implement the sync.Locker interface. So maybe we could continue taking inspiration from synx.RWMutex type and go with RLock(), RTryLock(), and RUnlock()?

One caveat is that we would also need to implement Windows support. But it looks like we may only need to omit the exclusive flag[1] (from the _windows.go file), making it a fairly small change: https://github.com/theckman/go-flock/blob/d0cbbf0727cd7369d6deda1da29490dc132d45b4/flock_windows.go#L32

What do you think? Would you want to try and implement it?

[1] https://msdn.microsoft.com/en-us/library/windows/desktop/aa365203(v=vs.85).aspx

[theory]

I could, yes, though I don't think I'd be able to test the Windows implementation. I don't see a Windows Travis CI instance, either.

[theckman]

I'm working on getting CI up for Windows. It's a bit of slog as I don't personally have a Windows box handy. I hope I can finish it this afternoon.