Comments (4)
I think panics being an intentional design decision in an interface is not a good choice, and isn't something I'd personally want to support. If you'd like to work with that interface instead, I think it's better to write a shim that wraps the flock
library, versus complicating this package further.
from flock.
Flock does not exactly follow the sync.Locker interface
Indeed, it does not. I don't think it should, either, because the semantics don't match. sync.Locker
is not the right interface if lock and unlock operations may fail, which is the case for flock
operations. To wit, perhaps the package-level documentation should be adjusted such that it does not mention sync.Locker
anymore. I'll send a PR.
from flock.
Either way seems fine to me. There are way more things that may panic with filelocks, so I get the aversion to panics. Simply fixing the Readme removes confusion as well.
Will close since I don't think much can be said, more of a sematics problem.
from flock.
Either way seems fine to me. There are way more things that may panic with filelocks, so I get the aversion to panics. Simply fixing the Readme removes confusion as well.
from flock.
Related Issues (19)
- Shared Locking? HOT 4
- Stop file from being deleted (win, mac, linux) HOT 3
- Stutter in flock.NewLock HOT 3
- Close/Unlock won't close the file descriptor if not locked
- Add codecov to gofrs/flock
- problem with remove lock file in windows HOT 2
- API is too restrictive for use on Windows. HOT 4
- 3rd clause of BSD refers to "linode-netint" HOT 4
- [documentation] Does not implement sync.Locker
- AIX TryLock() issue HOT 1
- Cannot build on Illumos HOT 3
- Problem with file operation on windows HOT 1
- Reconsider exposing the underlying file handle HOT 1
- [Attention] seens not working in unix HOT 1
- Unexpected behaviour: file created when acquiring lock HOT 1
- Cannot build on js/wasm, plan9/386, plan9/amd64, solaris/amd64
- How to writeFile???
- Exposing lock age
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flock.