Giter Site home page Giter Site logo

googleapis's People

Contributors

abhijitherekar avatar awalterschulze avatar erikgrinaker avatar iwaltgen avatar jeyoungkwon avatar johanbrandhorst avatar kyessenov avatar multiply avatar robinbraemer avatar sgtsquiggs avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

googleapis's Issues

Generated types are no longer convertable to golang/protobuf types

Since googleapis/go-genproto#65 was merged, google.golang.org/genproto types have the new protoc-gen-go fields:

https://github.com/jadekler/go-genproto/blob/c60d0593e41763b34a56c7ae500acf1d232486e4/googleapis/rpc/status/status.pb.go#L74

type Status struct {
	// The status code, which should be an enum value of [google.rpc.Code][google.rpc.Code].
	Code int32 `protobuf:"varint,1,opt,name=code" json:"code,omitempty"`
	// A developer-facing error message, which should be in English. Any
	// user-facing error message should be localized and sent in the
	// [google.rpc.Status.details][google.rpc.Status.details] field, or localized by the client.
	Message string `protobuf:"bytes,2,opt,name=message" json:"message,omitempty"`
	// A list of messages that carry the error details.  There is a common set of
	// message types for APIs to use.
	Details              []*any.Any `protobuf:"bytes,3,rep,name=details" json:"details,omitempty"`
	XXX_NoUnkeyedLiteral struct{}   `json:"-"`
	XXX_unrecognized     []byte     `json:"-"`
	XXX_sizecache        int32      `json:"-"`
}

This means the generated types in this repo are no longer convertable, i.e. this is no longer possible:

var _ *rpc.Status = (*rpc.Status)(&status.Status{})

Will gogoproto be updated (is it already?) to include these fields as well? If so we need to regenerate these types again.

add new release version

Could you please add new release version?
Not found rpc.ErrorInfo in latest release version.

Sorry for my poor English

Please consider new release version

Hi all,

Please consider releasing a new version to pull in #17. This will allow projects depending on this library to not incidentally pull in a version of gogo/protobuf that is vulnerable to the "skippy peanut butter" issue.

Thank you for your consideration!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.