gogo1951/gogoloot

gogoloot's Issues

Gogoloot announces autoneed on BoEs even when it's disabled

I was in a ZG run where the loot is changed from master loot to group loot back and forth, and every time group loot is enabled, GogoLoot announces that I am autoneeding on BoEs even though I specifically have that setting disabled.

Empty items string, and "and Blue" out of order "and".

I think this is fixed, just adding a card so it doesn't get lost.

Need Option to Auto-Destroy Grays

Need a checkbox:

"Automatically Destroy Gray Items"

Updates to Ignore Lists

Currently item images don't all load unless you have an item in your bag / on your person. The circled item is a Righteous Orb. Note it does show when I close and reload /gl.

Softres.it Automatic Looting Not Working

Just killed Patchwerk, https://softres.it/raid/upw54r, two items that dropped were Wand of Fates (1 person SRed) and Desecrated Spaulders (4 people SRed).

GoGoLoot with the settings imported (and chat output on closing the GGL window confirmed 76 reserves across 27 items) and checkbox ticked did nothing.

Version 1.5
I was Master Looter but not Raid Leader

Gogoloot data from softres.it:
eNql2M1OGzEQB/BXifacw2aThcCNqBRUQtWKCKRWHIbdIWvFayN/hI1Q36Zv0herc2l7+Xtrc4yTn8a7nhnbeStEW5wX/uW1XphiWghlHamGw5iiYTDUkw3DVj87w5bNnm1x/v2tEI774ryqzk7KaWG0lCutfPgqfFLUH/ml8aQUBay0Ow4UP6Z/3fykznHzspohJ8NvFAx3msPOlkvA7lm9kISzPK1zXCTeR0Nb23nl2AC7rMpcG+aL7Gcyw6DYJr/XUYiedMW6aZA6rdLVvFwsgNp4I1iiYHUWW5YoQ9fasGSR/Eaibl6WaO1uDD3ZJ2+2OGdmdb4t0XzvOu3IaDDfClZw1IXlmAP3gUQvMFvmMbT4l7ahPbXwveB5jksU80ERriQYL6pwtvmGXFZ6xyGOeMM7K3bJJR9ncF+6Zim17ajvD8ld+D32qydDygnFbfKe+B77jVixGKCb5bjIjrHWWh0Ozkd6P1zSURvpdvdkWhgSN6tMdk2vOnmKGIVOjCJ9CSWlTZvcM0YcLqtfP43kXXoVjzhcj43TZuiTEzQbXliv6FWobXItjUt0HNqwMewN7BrzLBc5fvFepPf+uIJH6D3Lg+LkaCMO7mtr34sIW2SwcK9A+bnR1llS2/Qz+5jENXHFhmTLketMnSkjjZAHpf22c+mdNy4jmXOnvZSZN5P/sPDcfyF39CxF44833dTHHcchCU8AvhVSw1Wt6xwFs+hGSnhMgc0xgnBHXZOxUshOS5cccNxGOojpDxZGLDMUbh9Xhqx9YoJb6tlylkQfp0UXhv75W+Xxz7cr2kyGya22dlItXDf5RMflb4Vtjlv6Uf8GxmVoIQ==

Code Cleanup

Remove unused code.

Hide opption rows when not equal to or above loot threshold

Instead of a grayed out name in the dropdown, just hide the row if they are below the loot threshold.

test

test

Update Build on CurseForge

https://www.curseforge.com/wow/addons/gogoloot/files

If it ever gets approved... ha.

Need to Validate Functionality when User has Leatrix / Speedy Auto Loot / other addons running

Likely need to pop a warning when we detect another loot addon, letting the user know to disable it.

Leatrix Plus and Speedy Auto Loot are both very popular.

Leatrix overwrites default auto-loot settings it seems.

https://www.curseforge.com/wow/addons/leatrix-plus-classic/issues/180

GGL Settings (Sometimes?) Don't Save

Apologies in advance, this is quite a rubbish bug report - I'll try to investigate further tomorrow if I can.

It seems that (sometimes?) GGL doesn't save its settings in terms of which boxes are ticked in the first tab (eg speedy loot). I've not noticed a specific pattern for when it seems to reset, I thought it was resetting every time but just relogged and it was saved that time so, yeah, sorry for lack of repro and I'll work on that!

Disable Loot Destinations when Loot Threshold set higher than that color

So like, if the threshold is Green, show Gray and White as disabled Loot Destinations

Add "Standard Master Loot Window" to Master Looter Destinations

Some people want to use GogoLoot for just grays, whites, greens, & blues... and keep the standard Master Looter window for Purples.

To enable this, we need an option in each destination for "Standard Master Loot Window" -- and any loot set to this would show up in a standard loot window for the Master Looter to deal with.

This came from a guy on the SoftRes.It Discord. It was in one of my early sketches for Loot Destinations, but it didn't make the priority cut for V1. (=

Update "Ignore Item" instructional text

Items in this list will always show up for manual need or greed rolls.

Enter Item ID, or Drag Item on to Input.

[Field] [Ignore Item Button]

Need similar text on the ML ignore list as well.

Create First Release! (=

Copy for v1.

A Classic WoW addon to help speed up runs by automating the Master Looter and Group Loot settings.

GogoLoot settings will appear when you are promoted to Master Looter, or you can type /gl to bring up the window.

By default "Auto Loot", "Auto Greed on BoEs", and "Speedy Loot (No Loot Window)" settings are enabled.

GogoLoot integrates with Softres.it! Simply paste in your CSV export from Softres.it and GogoLoot will automatically loot items to the people who it can; when more than one person had a SR on an item, the Master Looter can manually call for a roll on that item.

Stay tuned, there's more to come! (=

Need to add "About" tab

Content for the "About" tab:

GogoLoot was designed to help speed up the looting process.

Tips & Tricks

• Hold Shift while looting to disable GogoLoot for that corpse.

• To keep momentum during a raid, have your Master Looter come with empty bags so they > can scoop up all the gear and hand it out at the end.

• For faster raid clears, set the threshold to gray (poor). This will allow your raiders > to focus on moving in one direction towards the next boss, not having to run back > randomly when they see sparkles. (Most instances don't have more than 5-10g worth of > grays total; makes a good donation to your flask fund.)

• When getting boosted, or power-leveled, turn "destroy grays" to avoid clutter.

Creators

• Gogo (Earthfury-US).

• Aero (Earthfury-US). Aero was also the creator of Questie.

• Special thanks to Codzima (Stonespine-EU). Codzima was also the creator of Softres.it.

If you have any suggestions, or find any bugs, please add them to GitHub.

[GitHub Repository Link]

(Note: Let's put the GitHub repo link in a text field so people can copy it.)

Add Support for "Creator Message" on Player Mouse Over

On Earthfury there's a weak aura made by a coalition of guilds that reports if someone is a "friend" or "rat" -- it was very popular during the AQ opening events, likely will be for Naxx as well.

https://wago.io/f5MKYZMyw

Anyway, thinking about this as a future phase... and sort of something fun... possible to add this to the addon (and maybe Questie) so when someone who isn't in a party / raid with you mouses over you they see some text on the screen, "Hey this guy made that addon you use!"

We'd probably just have to add all of our alt's names, yeah?

Not set in stone, just a thought.

Skinning, Mining, Herbing, and Opening Chest Issues

Occasionally when you gather, the item shows up in the loot window but isn't looted. To get the item, you have to re-gather the source again. Needs a bit more investigation. Not a consistent bug, happens periodically.

Activate GogoLoot Settings Tab for Master Looter when Master Looter is Turned On

So there's an issue where if you have the settings window open, and then turn on Master Looter, you don't see the Master Looter Settings Tab activate.

Can we close the settings window and re-open it when Master Looter is enabled?

Changing Loot Threshold in Combat

We need a way to tell the user that they can't change the loot threshold during combat. A user sets it in the UI, but they don't really set it because someone in the raid is in combat and then apparently things get mismatched between loot threshold and destinations.

Maybe we check to see if anyone is in combat, and if so we just close the window? Whatever is easier here. Simple output in chat would work too.

Support for Softres.it CSV

Need to add another section inside of the Master Looter Settings tab for support for SoftRes.it CSV import.

Contents of section hidden / disabled unless user was Master Looter.

Contents of tab should clear whenever a user joins a Party / Raid.

Under Loot Destinations, above Ignored Items:

GogoLoot supports Softres.it; paste CSV code from website here to enable automatic distribution for this raid.

[Input box]

Format of Softres.it CSV

You can make a list here.

https://softres.it/

ItemId,Name,Class,Note,Plus
21503,Testname,Hunter,,2
21499,Testname,Hunter,,2

Output

On Save:

{standard loot destinations output}

{rt4} GogoLoot : Softres.it List Imported! {#} Reserves across {#} Items included.

On Loot:

When an item is looted:

{rt4} GogoLoot : Per Softres.it List, {item} goes to {Player1}!

or

{rt4} GogoLoot : Per Softres.it List, {item} will be rolled on by {Player1}, {Player2}, ...!

Need a better way to remind users that tool always ignores Orange Items.

Not sure if the ignore list is the right place, since they can't be removed...

Need Output for Auto Greed / Auto Need

Joining a Party or Raid w/ Group Loot On OR Entering an Instance w/ Group Loot On

Changing to Auto Greed / Need when in Party with Group Loot On

{rt4} GogoLoot : Auto Greed on BoEs Enabled!

{rt4} GogoLoot : Auto Need on BoEs Enabled!

Turning off Auto Greed / Need when in Party with Group Loot On (note switching from Need to Greed would trigger above message).

{rt4} GogoLoot : Auto Greed on BoEs Disabled!

{rt4} GogoLoot : Auto Need on BoEs Disabled!

Needs to be smart enough to output in Party or Raid depending on the group type.

Set Detault Settings

On Install Speedy Loot, Speedy Confirm, and Auto Roll on Boes (Greed) should be set.

Master Looter Active! message posts when no settings changed

the "GogoLoot : Master Looter Active! Blue, Gray, Green, Purple, and White items will go to " message posts every time you close the /gogoloot window, even if you haven't changed anything about the master looting. I agree that it should post that it's on, but please consider only stating that master looting is active if there's a material change to the looting conditions.

Printout for Auto Greed / Need Should Wait until First Person Joins Group

Super low priority as the message will fire when they enter an instance too. We don't want it have to fire it every time someone joins... yeah meh, very low priority.

Add support for Auto Confirm BoP

Future Phase.

We should check to see how these guys did it.

https://www.curseforge.com/wow/addons/bop-items-quick-loot

Extra loot window popping up on looting

Hey, loving your addon! Thanks! I have one slight issue with it however. When I loot sth that does not get auto-picked up (left to master looter) I get a loot window that does NOT close when I simply leave the loot behind. I cant move this window and I am not sure what it is even for. Can this be disabled so it doesn't show up at all?

See the example below - I am looting a mob and get the normal loot window by ElvUI, but also this extra window in the top left that has no functionality.

After passing ML, gogoloot no longer works for a mob I am the ML on

After passing ML to someone else (for gbid addon purposes) but while still the person eligible to masterloot a boss, gogoloot does not work and will only offer to grant items manually, unsuccessfully. I tried to ML myself an item and it caused massive lagspike and it went to some other person instead of me.

Steps to reproduce:

• Be ML
• Kill boss
• Change ML to someone else before clearing out boss
• Unable to auto nor manual loot boss anymore

Improved Support for SoftRes.it

New Json Format:

{
    "raidId": "760335762599968798",
    "instance": "aq40",
    "reserved": [
        {
            "name": "Gwbst",
            "class": "Druid",
            "items": [
                21669
            ],
            "note": ""
        }
    ],
    "hardreserved": [
        {
            "item": 21669,
            "note": ""
        }
    ],
    "note": ""
}

Changes to Announcements

On Save

Party / Raid: {rt4} GogoLoot : Welcome to {Instance}! {Raid Note}

Note: Not every raid will have a Raid Note.
It'd be good if we didn't use "AQ40" but rather the real name of the instance... Not BWL but Blackwing Lair.

Party / Raid: {rt4} GogoLoot : {#} Items are Hard-Reserved by {#} Players & {#} Items are Soft-Reserved by {#} Players! For full list of items https://softres.it/raid/{760335762599968798} - Powered by SoftRes.It!

On Item Drop, and item was Hard Reserved, or Soft Reserved by only 1 player.

Party / Raid: {rt4} GogoLoot : Congrats to {Player} on {Item} (Hard-Reserved)! {Reserve Note}

Note: Not every Item will have a Reserve Note.

Party / Raid: {rt4} GogoLoot : Congrats to {Player} on {Item} (Soft-Reserved)! {Reserve Note}

Note: Not every Item will have a Reserve Note.

On Item Drop, and item was Soft Reserved by more than 1 player.

Party / Raid: {rt4} GogoLoot : {Item} was Soft-Reserved by {Player1}, {Player 2}, and {Player 3}! Requires Master Looter Attention!
Party / Raid: {rt4} GogoLoot : {Player 1}'s Note: {Reserve Note}
Party / Raid: {rt4} GogoLoot : {Player 2}'s Note: {Reserve Note}

Note: Not every Item will have a Reserve Note.

Need to Validate Functionality when auto-loot is on or off in default settings

Regardless of what setting a user has, GogoLoot should function the same way.

When you hit an item on the ignore list, you don't loot items below it until you re-loot the corpse

Occasionally you have to click mobs twice to loot all the non-ignored items on a corpse.

A - Non-ignored Item
B - Ignored Item
C - Non-ignored Item

When this happens, it would loot A, but leave B and C. Clicking the corpse again loots the items.

Probably needs a bit more investigation; not consistently a problem but happens periodically.

Issue when Importing SoftRes.It List

Code Imported

eNqdl01v2kAQhv8K8pkD2IAhNwJNony0UYLUL+Ww2AOest4hu946TtT/3qWHFlV5o26FuHh5tON5Z94ZXhIuk5Mkn01H4ZuPx8Msm45m+SDpJ2xco0xB4Vw9jg5PnGwaS47sd3LJydeXhBuqk5N0OBlO+4kVrU/F+HA06CdG1QfyvlauWltxATfSHB4lP/rH5BiQS2/WCmLjAcBWyu4EUQMYZivrtSbAjacTxFWkNSNuMskQ50rbVijOfDAE3GkIkywbRKYpIm/UrpHWvM5l4xzl81yaoKA00Rfe7ys2hYu+8KKrOqgDKpa5DmkREx3krbK2iw5xyU9MTUUlqRJJD+Ezb7vn16nBLEUFurCKt69TaZ7BZqBSnPIW5SXLAXjXiX8C1DSbAepLt69EdzBMpMJCdMlmG636quXnhsto7lS2pTKy2US/4TvmaOZGrLRkFKqUFFuZJkjlyFpW/qlWBuYEYZeqVVbBQkkB9p6K8JwLFOYM3bdQdi1m42H/vZVRZbY72oekbqMre/5dkY1upA+2INdY1VD0aLn2BZOB4HiWQ/k5YEfVvVCmFybyrte0YTb/FTkS6LM3wRmj/ebW1/suehwuiW1p8RhFBvARtdUbklx5rY/r/Iwt9dj1NG/oH6WZ26JictFX3z96dlW3UfE+fm79rmklus8+kRHHLr7cyXbOwQ5D2BVrTTa0mf+PAe5NU4dwW3TrcIQ9wUQvfHOtarUDQuTpBLryN6kFYsh6Vmx2QPXhMEMvtqq8KVX0lngXdi82XMTb8m1YveAahbGlMowtDg6qu+CNYWGwTryOhi/9mjVRdGVfi9R7F71BX8iW4vfLRSVF+BxzD/2kUge3+/1/6OHPaT8p2RViy18//QmeEA/F

From this URL

https://softres.it/raid/798479875513384970

Expectation

{rt4} GogoLoot : Softres.it List Imported! {#} Reserves across {#} Items included.
{rt4} GogoLoot : Softres.it URL https://softres.it/raid/{ID}

Also need to make sure we're including the Discord link if it was set.

Remove "CSV" from SoftRes.It instructions

Item names and icons dont show in ignore list the first time its opened

Hide Master Looter settings when Not Master Looter

Should still be able to adjust ignore list.

Loot Window Behavior

With Speedy Loot on, I still see the Loot Window for a second when I'm in a 5-man, but it does work in a raid setting.

However, in a raid setting, I don't even see the window when there are quest items unless I hold down shift.

It should always show the window if there are ignored items / quest items present.

Change "Suppress BoP Confirmation Popups" to "Speedy Confirm (Auto Confirm BoP Loot)"

Need to Validate Functionality across Leader / Non-leader with Master Loot enabled

Seems to bug out when you're not the Raid Leader.

May be fixed when we disable the Loot Threshold box for non-Raid Leaders, but likely needs further testing.

Set Orange Quality items to Always Use Standard Loot Window and Require Manual Loot

Let's make it so Orange items are always manually looted.

Noticed that the Eye of Sulfuras was autolooted with current settings, even though we have it set to Purple it's grabbing Orange too.

Notification Announcements in Party / Raid

Removed parts of this task that were completed already.

On Out of Range

/raid (or party):{rt4} GogoLoot : Tried to loot {item(s)} to {player}, but {player} was out of range or not in the instance.

Not Eligible

/raid (or party):{rt4} GogoLoot : Tried to loot {item} to {player}, but {player} was not eligible.

Bags Full

/raid (or party):{rt4} GogoLoot : Tried to loot {item} to {player}, but {player}'s bags are full.

Revert Users' Original Auto-loot Setting when Disabling GogoLoot

Currently we turn the WoW setting for auto loot on for everyone, and leave it on even when GogoLoot is disabled.

We need to record the users' original setting, and revert back to that when GogoLoot is disabled from the addon options window (/gl). (We won't be able to fix this if GogoLoot isn't loaded.)

GGL Overrides WoW's Autoloot Setting

When I installed this addon it overrode WoW's settings for autoloot - I had autoloot off (with shift as the modifier key), however after installing this addon autoloot was then enabled in WoW's interface options.

World Boss epic loot should be default ignored

World boss loot is not tradable. All epic item world boss loot should be added to the default ignore list.

Revert in-game autoloot setting when not MLing

It seems that this addon relies on using the stock in-game autoloot functionality, which is fine. But after finishing a raid I logged on to an alt, and I wanted to check inside a chest without looting it, and it emptied it in my inventory. I noticed that on WoW settings my autoloot was enabled.

Can the autoloot setting be enabled only when masterlooting, and otherwise reverted back off if that was the original setting?

Loot Destination Settings Should Not Be Retained Between Raids

If you do one raid, and then drop group and join another, the settings for who items are sent to are retained.

Settings need to be cleared the moment you drop group.

When you set up ML settings, it should always default to you as the master looter, and not try and keep settings from past runs.

Warning at Launch if Player has BetterAutoLoot or SpeedyAutoLoot Installed

"GogoLoot : You have multiple addons running that are attempting to interact with the loot window. This will cause problems. If you don't disable your other loot addons you will experience issues with GogoLoot."

These can conflict.

https://www.curseforge.com/wow/addons/auto-destroy
https://www.curseforge.com/wow/addons/auto-loot-assist
https://www.curseforge.com/wow/addons/autolooter
https://www.curseforge.com/wow/addons/better-autoloot
https://www.curseforge.com/wow/addons/cepgp
https://www.curseforge.com/wow/addons/communitydkp
https://www.curseforge.com/wow/addons/lootfast2
https://www.curseforge.com/wow/addons/rclootcouncil-classic
https://www.curseforge.com/wow/addons/speedyautoloot

Enable "Backup Option" for Auto Loot

This is a future phase thing.

Add support for raidroll

Usecase - MC's mats, AQ's scarabs and idols, ZG's bijous and coins, every raid's random greens/blues - all of these could be (and usually are) randomly distributed in a pug.

Technically - show loot window and a button next to each item that will raidroll item and then transfer that item to person who won.

Need to Disable GogoLoot when user holds Shift while looting