Comments (5)
Removing the theme from build/go.mod & build/go.sum is not sufficient. In the past, when dealing with CI problems, I had to remove the theme from these files as well:
Note that I'm talking about the 2 specific error cases above, not "every CI problem".
from hugothemessitebuilder.
I have adjusted the builds to improve this, esp. see my comment in f844650 I'm closing this for now.
from hugothemessitebuilder.
Assuming this is most likely the theme authors' mistake, we could just remove the problematic themes, but the pragmatic approach is probably:
- Remove the theme from
build/go.mod
and commit. It will be reconstructed fromthemes.txt
.- Remove the
build/go.sum
and commit it.
I agree that this is a better way to handle things. Removing the theme from build/go.mod
& build/go.sum
is not sufficient. In the past, when dealing with CI problems, I had to remove the theme from these files as well:
cmd/hugothemesitebuilder/build/cache/0000.githubrepos.json
cmd/hugothemesitebuilder/build/config.json
References:
from hugothemessitebuilder.
Note that I'm talking about the 2 specific error cases above, not "every CI problem".
I see.
One commendable action you've taken is removal of the cache step in the GitHub action workflow.
from hugothemessitebuilder.
I'm working on fixing the build / making it more robust now.
from hugothemessitebuilder.
Related Issues (20)
- Remove the git config HOT 1
- Website still points to old repository
- Old version of theme being shown since adding Hugo modules support to theme HOT 3
- Broken CI during theme update HOT 11
- Netlify deploy failed HOT 1
- Missing filter tags on website HOT 3
- Unable to deploy preview when adding new theme
- CI failed due to issue with README.md of `github-style` theme HOT 2
- theme not updated HOT 6
- Updated_at should reflect actual theme updates HOT 2
- Theme metadata is often lacking HOT 1
- Themes updated inconsistently HOT 3
- Pico (theme) has been archived HOT 3
- License HOT 3
- workflow fails with "unknown revision" HOT 4
- Issue with specifying version for themes (Go modules) in `themes.txt` HOT 4
- Link to "Dark mode" tagged themes yields a 404 HOT 1
- ci:themes are not deployed/updated HOT 4
- ci: themes page is not deployed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hugothemessitebuilder.