Giter Site home page Giter Site logo

hugothemessitebuilder's People

Contributors

1bl4z3r avatar aminzibayi avatar apvarun avatar bep avatar chrede88 avatar coolapso avatar digitalcraftsman avatar floyd-li avatar frjo avatar httpsecure avatar hugo-sid avatar igor-baiborodine avatar jingwangtw avatar jpanther avatar jyygithub avatar lukeorth avatar mansoorbarri avatar nunocoracao avatar opera7133 avatar peaceiris avatar razonyang avatar sanmayjoshi avatar tfsomrat avatar tohn avatar tylerlaws0n avatar victoriadrake avatar willfaught avatar wivik avatar wjh18 avatar xslingcn avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

hugothemessitebuilder's Issues

Issues for theme resolved

There were some issues that were occuring when building the theme Vibrant Shadows. I have corrected issues that I think may have been causing problems(Softorage/HugoTheme-VibrantShadows#3). Would really love to see the theme appear again!

If there's anything more that I need to do, feel free to let me know ๐Ÿ˜„

Old version of theme being shown since adding Hugo modules support to theme

My theme was recently added to the showcase and was displaying the correct version initially. In the latest release of the theme, Hugo modules support was added. Since then, the theme has reverted back to an older major version (presumably 2.x.x instead of 3.x.x which is current). I noticed this due to the old screenshot being displayed on themes.gohugo.io.

I'm trying to figure out what went wrong despite not changing any git references or tags (I read the note about outdated themes in the README of this repo, not sure that applies here). I'm not 100% positive that the Hugo modules change is the reason for the issue but I suspect it may have something to do with it. Any help would be appreciated.

Cache invalidation?

I noticed that the GitHub Stars count on themes.gohugo.io is not up to date (because the data cache file is 2 months old).

Next to the Updated date (which is up to date), I think the (most recent) number of stars is a significant indicator (for popularity).

How often does the cache get cleared?

How are themes sorted on themes.gohugo.io ?

In searching for a new theme for a site, the first three rows (presently) have two themes that haven't seen an update in over a year while several which have seen updates in the past week are stuffed at the bottom. It's clear they're not sorted alphabetically, so what criteria is being used to sort these themes? If I'm a user looking for a theme, I'd rather focus my searches on those which seem to be active projects rather than wading my way through 100+ themes that haven't been touched in a year.

update-themes CI is broken

https://github.com/gohugoio/hugoThemesSiteBuilder/actions/runs/4516409153/jobs/7954703472#step:5:128

go: github.com/lucperkins/[email protected]: parsing go.mod:
	module declares its path as: github.com/StefMa/hugo-fresh
	        but was required as: github.com/lucperkins/hugo-fresh
Error: failed to get ["-d" "-u" "github.com/lucperkins/hugo-fresh"]: failed to execute 'go [get -d -u github.com/lucperkins/hugo-fresh]': failed to execute binary "go" with args [get -d -u github.com/lucperkins/hugo-fresh]: go: downloading github.com/lucperkins/hugo-fresh v1.0.0
go: github.com/lucperkins/[email protected]: parsing go.mod:
	module declares its path as: github.com/StefMa/hugo-fresh
	        but was required as: github.com/lucperkins/hugo-fresh

Download buttons for themes hosted on Gitlab does not point to their homepages or repo urls

Download buttons on the pages of themes hosted on Gitlab (which includes my theme) points to their themes.gohugo.io page link. Ideally this should be pointed at the homepage variable from themes.toml or to the actual repo url from themes.txt.

I did look at the respective pages on themes.gohugo.io of all themes listed in themes.txt that are hosted on Gitlab and have verified the same.

How to handle missing Git refs

I'm about to fix/get the build running, but thought I would open this issue to discuss how we handle this in the future.

In my head there are 2 common error situation.

  1. invalid version: unknown revision
  2. checksum mismatch for the go.sum file.

For the two variants above:

  1. Is most likely unversioned theme (we use the last commit ref) where the theme owner have done a git push -f so the ref is gone. It could also be a versioned theme where the theme author has deleted the tag on GitHub.
  2. This is most likely a versioned theme where a theme author has replaced the tag on GitHub.

Assuming this is most likely the theme authors' mistake, we could just remove the problematic themes, but the pragmatic approach is probably:

  1. Remove the theme from build/go.mod and commit. It will be reconstructed from themes.txt.
  2. Remove the build/go.sum and commit it.

/cc @hugo-sid

Add search feature

I was looking for a theme I had seen beginning with letter T and it took a while to browse through all the themes. Kindly add a search featue to check themes by titles.

Appending version number to existing theme record in themes.txt creates a new theme

Here is my latest commit: igor-baiborodine@b22443c

I wanted to upgrade the Bilberry Hugo theme to v3 since the info about the theme was outdated on themes.gohugo.io. Therefore, I appended /v3 to the theme record in the themes.txt file, assuming it will fix the issue:
image

But it replaced the Bilberry Hugo theme page with a page for a theme named v3.
Before: https://themes.gohugo.io/themes/bilberry-hugo-theme/
After: https://themes.gohugo.io/themes/v3

Seeing this, I assume you use the last part in the theme's GitHub URL to extract the theme name, which is not correct when the URL ends with the version number part.

There is another theme with the same issue: https://themes.gohugo.io/themes/v5.

Is Sourcehut supported?

I see that themes.txt contains both github.com and gitlab.com links. If I were to submit a theme with a repo hosted on git.sr.ht (Sourcehut), would that be accepted?

Unable to deploy preview when adding new theme

Hi, I'm trying to add theme, but couldn't deploy the preview, and I don't know how to fix it.

https://app.netlify.com/sites/hugothemes/deploys/650599fd3c125f0009d0c274

8:05:32 PM: $ ./build.sh
8:05:32 PM: go: downloading github.com/peterbourgon/ff/v3 v3.0.0
8:05:32 PM: go: downloading gopkg.in/yaml.v2 v2.4.0
8:05:32 PM: go: downloading github.com/pelletier/go-toml/v2 v2.1.0
8:05:32 PM: go: downloading github.com/rogpeppe/go-internal v1.8.0
8:05:32 PM: go: downloading github.com/bep/workers v0.0.0-20210707112724-e02f640a8c6b
8:05:32 PM: go: downloading golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
8:05:32 PM: go: downloading github.com/pelletier/go-toml v1.6.0
8:05:39 PM: Writing output files to /opt/build/repo/cmd/hugothemesitebuilder/build
8:05:39 PM: Running on Netlify (and not Cloudflare :-))
8:05:39 PM: Get Hugo Modules, config config.json
8:06:45 PM: verifying github.com/ntk148v/[email protected]: checksum mismatch
8:06:45 PM: 	downloaded: h1:kWbaK5JXp1sIqzOsrcS6cWw+OlzMjaFOIH1ZLsIu99g=
8:06:45 PM: 	go.sum:     h1:8Vy+1nQCgKgr9aDFZ4pAUjp0sVE/ZzXgsRrqCYehuaA=
8:06:45 PM: SECURITY ERROR
8:06:45 PM: This download does NOT match an earlier download recorded in go.sum.
8:06:45 PM: The bits may have been replaced on the origin server, or an attacker may
8:06:45 PM: have intercepted the download attempt.
8:06:45 PM: For more information, see 'go help module-auth'.
8:06:45 PM: Got Hugo Modules in 65802 ms
8:06:45 PM: error: exit status 1
8:06:45 PM: exit status 1
8:06:45 PM: go failed: exit status 1

License

Please consider adding a license for the Go code in this repo.

Themes not automatically updated

Are themes not automatically updated yet? On the old setup, it was scheduled for 00:00 UTC on the 1, 4, 7, 10, 13, 16, 19, 22, 25, 28 and 31th of every month. How is it done now?

ci:themes are not deployed/updated

The following themes are not deployed to the production, but exists in the themes.txt file:

  • github.com/paposeco/quietfoodie
  • github.com/hugo-porto/theme
  • gitlab.com/mrubli/hugo-theme-comic

This may not be a complete list.

Themes are noted in the Netlify deployment log:

12:21:33 PM: go: added github.com/hugo-porto/theme v0.1.7
12:21:33 PM: go: added github.com/paposeco/quietfoodie v0.0.0-20240522105017-ca30389fab2d
12:21:34 PM: go: added gitlab.com/mrubli/hugo-theme-comic v0.1.2

In addition, themes are not presented in the config.json file and in the go.mod file.

Allow theme to live in sub folders on GitHub

Problem

When attempting to add a valid Hugo Module/Theme to themes.txt, the build fails stating it cannot find the GitHub repo.

It appears that the build script treats the Hugo Module path as the GitHub repo when that is not how the Go Module spec is defined.

According to the spec for Hugo and Go modules/themes:

  1. a module/theme may be located within a subdirectory of a repository (i.e. you are allowed to have a repository containing multiple modules/themes)
    • e.g. modules/themes are allowed to exist at github.com/myname/myrepo/mytheme1/ and github.com/myname/myrepo/mytheme2/ according to the spec, but will cause the hugoThemesSiteBuilder to fail
  2. a module/theme with a version greater than 2 must postfix the version to the Go Module path (and also worth mentioning, it does not need to create a physical subfolder for each version - a v5 subfolder doesn't need to exist although it must be in the module path)
    • currently, when a valid Hugo Module URI github.com/myname/myrepo/mytheme1/v5 is entered in themes.txt, the hugoThemesSiteBuilder fails when it should pass as it's a valid Hugo Module/Theme that meets the module spec

Solution

I propose we:

  1. allow valid Hugo Module/Theme URIs to be defined in themes.txt (rather than treating Hugo Modules as GitHub repos, which is not how the Modules spec was defined)
  2. introduce some simple logic in the build script to extract the GitHub Repo from the Hugo Module path
    • e.g. accept the valid Hugo Module/Theme URI github.com/myname/myrepo/mytheme1/v5
    • and extract the Github repo github.com/myname/myrepo from the module path

Broken CI during theme update

I've just noticed that my SalingerTheme gives an error during the CI action but I don't know why.
The theme is tagged since I made a second version. I've also made a go.mod file looking at similar themes.
The following is the error message in the CI log from the action of yesterday.

go: github.com/jacksalici/[email protected]: invalid version: resolves to version v1.1.1-0.20220529184427-4eefcee963f3 (v1.1.0 is not a tag)
Error: failed to get ["-d" "-u" "github.com/jacksalici/salinger-theme"]: failed to execute 'go [get -d -u github.com/jacksalici/salinger-theme]': failed to execute binary "go" with args [get -d -u github.com/jacksalici/salinger-theme]: go: github.com/jacksalici/[email protected]: invalid version: resolves to version v1.1.1-0.20220529184427-4eefcee963f3 (v1.1.0 is not a tag)

Thank you in advance and sorry for the inconvenience.

Issue with specifying version for themes (Go modules) in `themes.txt`

If I add my theme with github.com/frjo/hugo-theme-zen (no version part) the preview does not include the Zen theme at all.

If I add my theme with github.com/frjo/hugo-theme-zen/v3 (with version part) the preview displays the Zen theme in order but with an incorrect path for the download button. It sets the download path to include the version part making the download link end in a 404.

There seems to be a bug with setting html_url for themes with a version. I suspect it works for some theme due to the correct html_url being cached.

Originally posted by @frjo in #453 (comment)

Netlify deploy failed

What's the issue?

The Netlify deployment for the production environment for the last two commits has failed.

Relevant resources

  1. Netlify log corresponding to commit 2a4376c
  2. Netlify log corresponding to commit 66b9b39

Updated_at should reflect actual theme updates

I was looking at the github cache, and it seems to pull the updated_at element from the github api. That element seems to include any action on the repo, even issues opened by other users, so a "recently updated" theme may actually not have had new commits in years. Would a better "updated_at" value be the date on the latest commit to the default branch of the theme?

[Question] What to do when theme's README.md needs an update

Hi,

first of all thanks for accepting my theme to your great project. I'm very happy about that. :-)

I already realized that the README.md needs some updates I wanted to know if I need to issue another Pull Request for this or if you have another workflow in place?

Best regards, M.

Remove Themefisher from this directory for spam and unethical behaviour

Themefisher has a long history of being a bad actor in the Hugo community. They are a premium theme company that is mostly interested in abusing open source channels to promote paid offerings.

They have been banned on the Hugo themes directory in the past for bait and switching their free offerings with commercial ones gohugoio/hugoThemes#760. They continue to sully the Hugo open source projects brand with their usage of Hugo in their brand names and commercial sites such as gethugothemes.com

Now they have been found to be completely copying another open source project www.jamstackthemes.dev. They have literally copied the site code verbatim, removed the original attribution in the MIT License, deleted the git history history and re-branded the site as their own. they have launched the rebranded site at www.statichunt.com except it now contains all of their own themes at the top...

The lack of action in the past has emboldened the owner of this company to do what they wish with the Hugo brand and they have intensified their spam and grifting activities (probably because its working and they are getting sales and nobody is saying anything).

I suggest that all themes by Themefisher, Gethugothemes and Statichunt are removed from this directory.

I am the core maintainer of www.jamstackthemes.dev and I am very unhappy. I realise you may not wish to involve yourself, but I am asking for your support to pressure this person into taking down their site. The removal of their themes from this official Hugo theme directory would be a significant blow to their traffic (and profits) and in my mind it is completely justified.

@bep @digitalcraftsman

workflow fails with "unknown revision"

The updating workflow is failing for 5 days, since: https://github.com/gohugoio/hugoThemesSiteBuilder/actions/runs/8654962571

The error seems to be related to an "unknown revision":

Run go install github.com/gohugoio/[email protected]
  go install github.com/gohugoio/[email protected]
  go run main.go build -skipSiteBuild -cleanCache
  cd build
  hugo mod get
  hugo mod tidy
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    HUGO_VERSION: v0.119.0
    HUGO_CACHEDIR: /tmp/hugo_cache
    GITHUB_TOKEN: ***
Writing output files to "/home/runner/work/hugoThemesSiteBuilder/hugoThemesSiteBuilder/cmd/hugothemesitebuilder/build"
go: github.com/maolonglong/[email protected][2](https://github.com/gohugoio/hugoThemesSiteBuilder/actions/runs/8697885864/job/23853949498#step:4:2)0240407162311-66df9eb4f184: invalid version: unknown revision 66df9eb4f184
command error: exit status 1
Got Hugo Modules in 1[4](https://github.com/gohugoio/hugoThemesSiteBuilder/actions/runs/8697885864/job/23853949498#step:4:4)2882 ms
exit status 1
Error: Process completed with exit code 1.

(example of the failing runs)

I'm guessing that this is about a commit sha not found in https://github.com/maolonglong/hugo-simple/commits/main/

This issue is also reproducible running locally:

go run main.go build
Writing output files to "(...)/hugoThemesSiteBuilder/cmd/hugothemesitebuilder/build"
go: github.com/maolonglong/[email protected]: invalid version: unknown revision 66df9eb4f184
Got Hugo Modules in 1228 ms
command error: exit status 1
exit status 1

The error seems to come from the go.mod:
https://github.com/gohugoio/hugoThemesSiteBuilder/blob/main/cmd/hugothemesitebuilder/build/go.mod#L303

Removing the erroring line:

	github.com/maolonglong/hugo-simple v0.0.0-20240407162311-66df9eb4f184 // indirect

The script executes:

โžœ  hugothemesitebuilder git:(main) โœ— go run main.go build
Writing output files to "(...)/hugoThemesSiteBuilder/cmd/hugothemesitebuilder/build"
go: downloading github.com/maolonglong/hugo-simple v0.0.0-20240416135222-1f6e2158af4f
go: added github.com/maolonglong/hugo-simple v0.0.0-20240416135222-1f6e2158af4f
go: downloading github.com/techbarrack/terminal-hugo-theme v0.0.0-20240413174942-51818d810c4a
go: added github.com/techbarrack/terminal-hugo-theme v0.0.0-20240413174942-51818d810c4a
Get Hugo Modules, config "config.json"
warn: failed to parse theme.toml for theme "github.com/Bonzdev/alexa-portfolio": toml: incomplete number
warn: failed to parse theme.toml for theme "github.com/unicef/inventory-hugo-theme": toml: incomplete number
Got Hugo Modules in 497203 ms
Get GitHub repos
Got GitHub repos in 3 ms
Loaded 115012 bad hosts
Processed 492 themes.
Total in 497978 ms

Which leads me to think that there could be some validation per line - and skip instead of fail the whole script if there's an error?

Long List of Files Cuts off Page

Apologies if there's an elementary fix. This is my first Hugo site and I don't have much coding knowledge.

I'd like to put a very long list of files (possibly a few hundred) in this section:

files = [
["C/C++", "https://www.example.com/"],
["Python", "https://www.example.com/"],
["Go", "https://golang.org/"],
["Hugo", "/post/some-activity.md"],
["Docker", "/post/some-activity.md"],
]

When I do that though, the page cuts off at the bottom. I was thinking adding scroll might help, but there may be a more elegant solution that I'm not coming up with. Love the theme, and would appreciate any guidance you have. Thanks!

Theme metadata is often lacking

Hey,

I've notice that a lot of themes (4 of the top 10 and many more) don't have a direct link to their demo site, despite having one. This seems to be the result of demosite simply not being set in theme.toml.

There's however also themes that lack other metadata, such as in the case of https://themes.gohugo.io/themes/reveal-hugo/, which lacks a description.

It seems like a good idea to me, to create a GitHub PR template, which reminds people (check boxes that have to be ticked) to enter all metadata, especially the demo site, if applicable. Perhaps you could even have tests, though that seems rather complicated and unnecessary to me.

CI failed due to issue with README.md of `github-style` theme

From log:

Error: error building site: assemble: /opt/build/repo/cmd/hugothemesitebuilder/build/site/content/themes/github-style/index.md:1:1: got closing shortcode, but none is open
hugo failed: exit status 1

Details

A commit was made in the GitHub style theme yesterday which introduced a shortcode in the README.md file.
There appears to be an issue with this. Hugo, states that it has encountered a closing shortcode without a corresponding opening shortcode.

/cc: @bep
Shall we ask the theme maintainer(s) to remove the shortcode from README?
I am removing the theme from themes.txt temporarily unless this issue is solved.

Themes updated inconsistently

It seems the Updated metadata displayed at themes.gohugo.io, for a few themes that have releases on GitHub, is the date of the latest release, not the latest commit, as is the case for most themes.

It seems to correlate with the way they are found in cmd/hugothemesitebuilder/build/go.mod:

However, for other themes, which have releases on GitHub, the date of the latest commit is displayed at themes.gohugo.io:

I suspect the first case also leads to the themes not being updated at themes.gohugo.io, as in the case of docsy: they have added a demosite several days ago, but the link is not displayed.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.