goiblas/map-block-leaflet

Map Block Leaflet for WordPress 🗺️

map-block-leaflet's Issues

Grayscale theme does not work

Block is not shown anymore in frontend

I have used the block on https://taschenbuchladen.de/ and it is not shown anymore. It is visible in the Gutenberg editor though.

For my frontend it shows the "L is not defined" JS erorr.

Map Block Leaflet 1.5 doesn't load.

After upgrading to version 1.5, Wordpress seems unable to detect this plugin.

Specifically, the plugin appears to be installed and activated, but I am unable to find it in the list of blocks. Blocks added with a previous version of the plugin no longer work.

Map icon customization

Should be possible to customize the marker

• https://leafletjs.com/examples/custom-icons/

Like user I do not know what I can resize the map

• Add height input in the inspector
• Add element like spacer when it is selected

Map Height Not Remembered in Block Settings

After setting "Options > Map Height" and Publishing/Updating the Post/Page the Map does use correct height, but if you edit the Page/Post the Map Height reverts to "220".

So if you edit something on the page and Update, the Map height reverts.

Guessing the current map height is not checked when editing the Post/Page?

Update images WordPress directory

Allow newlines in tooltip text

It would be nice to be able to display newlines within the tooltip.

For example, this could be achieved by the wrapping the tooltip text in <p> tags, and replacing newlines with <br>.

Support themes with transtions pages

If the theme use transitions no paint map correctly.

• Observe if body has class "loading"
• Throw repaint when finish

Icon map don't show

Hello,
the icon marker does not show on the map on the front end.
The map try to load the png from the url of the page.
GET https://gargas-dev-front.149-202-93-199.plesk.page/fr/infos-pratiques/**marker-shadow.png**

Thank you for your work.

Add option to customise text displayed in marker

Currently, the Leaflet marker displays the address which was entered to locate the marker.

It would be nice to be able to change what is displayed in the marker without changing the location of the marker.

The search engine appears over the block´s toolbar

When do scroll on page may move map zoom

Add option for disable scroll scrollwheel for zoom

Conditional enqueue script

example of implementation https://richtabor.com/has-blocks-gutenberg-scripts/

Content of tooltip is not properly escaped.

The contents of the tooltip are inserted directly into the page without proper escaping. This means that including quotation marks breaks the loading and rendering of the map. Additionally, inserting a newline also breaks rendering.

It also means that by setting the value of the tooltip as follows, arbitrary javascript can be inserted into the page:

');alert('hi');console.log('unescaped arbitrary code execution!

(You should see an alert, and an entry in the console.)

Remove unnecessary functions for alignment

• Remove getEditWrapperProps
• update supports to align: true

map_block_leaflet_render() disabled?

It seems that "map_block_leaflet_render()" is removed, is there a replacement? I have used it to fill in a custom map by code from custom meta.

Thanks for all the work.

¿Qué licencia tiene este bloque?¿Es código abierto?

Improved resize behaviour

Extend provider list

Extend the provider list for the map

• https://github.com/leaflet-extras/leaflet-providers
• https://www.maptiler.com/

WordPress support topic

• https://wordpress.org/support/topic/extend-provider-list/

Update version of library Leaflet map

https://leafletjs.com/

Improve the theme selector

change the theme through thumbnail of maps

• Generate thumbnails
• Add to providers array
• Create a new component picker
• Integrate into inspector

Javascript code gets wrapped in <p>

For some reason Wordpress auto-wraps parts of the Javascript code in <p> Tags. Any tips what I can try to clear this up? I have a current version of WP and your plugin. The content gets no special treatment and is just output with the_content().

This of course causes an error and the map never shows on the page.

Update:

I do in fact process the blocks, by passing them through render_block() inside add_filter('the_content', …). I disabled that and the map shows up fine. I don't know why that would be different than what Wordpress does during render anyway, but it fixed the issue. Luckily, I was in a position where removing the filter was possible.

Disable assets if block isn't in page

The assets is in all pages. For the moment i use this snippet for remove assets if the block isn't in page.

/**
 * Completely remove assets from plugin block leaflet if isn't in page
 */
function disableLeafletAsset()
{
  $id = get_the_ID();
  if (!has_block('map-block-leaflet/map-block-leaflet', $id)) {
    wp_dequeue_script('lib-js-map-block-leaflet');
    wp_dequeue_script('lib-js-map-block-leaflet-cluster');
    wp_dequeue_script('js-editor-map-block-leaflet');

    wp_dequeue_style('css-editor-map-block-leaflet');
    wp_dequeue_style('lib-css-map-block-leaflet');
    wp_dequeue_style('lib-css-map-block-leaflet-cluster');
  }
}


add_action('wp_enqueue_scripts', 'disableLeafletAsset');

Added version number in enqueued scripts and styles

Inner map tile is not set up correctly in full-width mode

Hi,

Thanks for this great plugin.

On a currently in-dev site (using Hestia theme), I'm willing to load a full-width map on a page by using the dedicated option from block toolbar.

On frontend, the container is well updated to expand to full-width through negative left/right margins but the inner map tile is stuck to initial width and there's a grayed empty area.

If I force a new rendering, by resizing window for instance, map tile expands correctly to fill all container.

Is it fixable ?

Thanks !

Define from PHP the default settings

• Add settings into declaration block
• Remove conditionals of callback render
• Remove attributes of block if it's not necessary

How can I add a two or more markers

There's any way we can add more than one marker?

Thanks in advance

Invalidate map size when change the alignment

Disabled zoom by default

Leaflet 1.5.1 openstreetmap not working

My maps use Leaflet 1.5.1 with openstreetmap tiles. They stopped working last week (no tiles showing).
Do I need to update to Leaflet 1.7.1?

The map disappear when it is align left or right