goliatone/arpscan

Node arp-scan wrapper

arpscan's Issues

Module name is not consistent

We can find either arpscan or arpscanner in the project:

• In README.md: the project name is named arpscanner
• But we need to install the module with npm install arpscan

make interfaces optional

arp-scan -l is a valid command but as far as I can tell not possible with your node implementation. I tried setting the value to null but it wouldn't work. I was able to get the feature working the way I had wanted by removing line 47 in arpscanner.js.

arpscan/lib/arpscanner.js

Line 47 in e898498

options.args = options.args.concat(['-interface', options.interface]);

Ideally this flag would be optional. I looked at the forks of your repo and this seems to be a common change.

TypeScript types missing

The module does not correctly import in TypeScript, maybe a 'd.ts' could be added to solve this:

Could not find a declaration file for module 'arpscan/promise'. '[edited]/node_modules/arpscan/promise.js' implicitly has an 'any' type.
Try npm i --save-dev @types/arpscan if it exists or add a new declaration (.d.ts) file containing declare module 'arpscan/promise';

Verbose option does not print the command when sudo is enabled

DESCRIPTION
When calling the scanner(cb, options) function in verbose mode, the command won't print if sudo mode is enabled.

STEPS TO REPRODUCE

1. Set options.verbose to true.
2. Set options.sudo to true.
3. Invoke the scanner(cb, options) method.

EXPECTED RESULTS

• The command should print to the console like the following:

  sudo arp-scan -l -interface wlan0
  

ACTUAL RESULTS

• The command prints to the console only the word sudo followed by an empty space:

  sudo 
  

returns error in basic example

When running the following example I get error 1 returned:

var arpscanner = require('arpscan');
arpscanner(onResult);

function onResult(err, data){
    if(err){
    console.log("Error number: "+ err);
    }else{
    console.log(data);
    }

}

ubuntu 12.04 32-bit
npm: 3.10.6
node: 4.5.0
arpscan: 0.1.0
arp-scan 1.8.1

I got the following warning when installing:

npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

Thanks

sudo not really implemented

Hi,

Command built with suspawn is like :
sudo -- sh -c "arp-scan -l ..."

Rules added in sudoers file, to avoid typing password, can't obviously be effective
my_user ALL=(root) NOPASSWD: /usr/bin/arp-scan

Method using chmod u+s /usr/bin/arp-scan, is not "upgrade compliant"
Granting access with NOPASSWD to sh is totallly unsafe

Do you have a workaround ?

Regards
F.

In macOS check if we have arp-scan

In macOS we can use arp but the output is different- it has no vendors. We should use arp-scan if available on mac.

grunt-cli listed as dependancy instead of devDependancy

grunt-cli listed as dependancy instead of devDependancy

Does not conform to standard nodejs syntax

normally the callback is last after any arguments (including optional arguments).

So I was expecting

arpscanner(callback); //or
arpscanner(options, callback);

Sadly because your syntax is opposite to the rest of nodejs

arpscanner(callback, options);

things such as promisify cannot get a handle on your code.

I can fix it my side with a wrapper functions, but just thought I would let you know.

• Colin.

Hassio, how can install?

Hi,
i have Hassio and sudo command dont work...
can write me please, the correct comnad to install arpcan :)
i try this.. but...
apk add arp-scan
error: unsatisfiable constraints:
arp-scan (missing):
required by: world [arp-scan]