google-cloudsearch/connector-sdk

Google Cloud Search Connector SDK

connector-sdk's Issues

Fail to install the Google Cloud Search Indexing Connector SDK

I follow the steps to install the packages, however, it returns a installation failure result.

Like:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Google Cloud Search Connector SDK v1-0.0.3:
[INFO] 
[INFO] Google Cloud Search Connector SDK .................. SUCCESS [  0.701 s]
[INFO] Google Cloud Search Connector SDK .................. SUCCESS [ 12.349 s]
[INFO] Google Cloud Search Indexing Connector SDK ......... FAILURE [  7.751 s]
[INFO] Google Cloud Search Identity Connector SDK ......... SKIPPED
[INFO] Google Cloud Search Connector Integration Tests Common SKIPPED
[INFO] Google Cloud Search CSV Connector .................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  20.925 s
[INFO] Finished at: 2019-03-21T10:12:51+08:00
[INFO] ------------------------------------------------------------------------

Insstall-fail-log.txt

full traversal connector deletes existing items

We've noticed that the full traversal connector deletes any existing items in the repository and in essence "replaces" them with the new ones on the next run. Is this expected behavior?

How do you deal with adding more items to an existing repository while using the full traversal connector?

Missing dependency in RepositoryDoc.java

Hello,

When running a connector developed from the Graph traversal sample, I get a NoClassDefFoundError exception on the com.google.api.client.repackaged.com.google.common.base.Strings class inside the getDoc() method.
More specifically, the missing library is called by the addChildId() method inside the RepositoryDoc.java class inside the indexing template project.
I already modified the getIds() method so let me know if I'm doing something wrong.

Here is the complete stacktrace :

Exception in thread "TraverserRunner-default-39" com.google.common.util.concurrent.ExecutionError: java.lang.NoClassDefFoundError: com/google/api/client/repackaged/com/google/common/base/Strings
at com.google.common.util.concurrent.SimpleTimeLimiter.wrapAndThrowExecutionExceptionOrError(SimpleTimeLimiter.java:271)
at com.google.common.util.concurrent.SimpleTimeLimiter.callWithTimeout(SimpleTimeLimiter.java:154)
at com.google.enterprise.cloudsearch.sdk.indexing.traverser.ParallelProcessingTraverserWorker$PollAndProcessRunnable.run(ParallelProcessingTraverserWorker.java:153)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.base/java.lang.Thread.run(Thread.java:844)
Caused by: java.lang.NoClassDefFoundError: com/google/api/client/repackaged/com/google/common/base/Strings
at com.google.enterprise.cloudsearch.sdk.indexing.template.RepositoryDoc$Builder.addChildId(RepositoryDoc.java:180)
at com.sword.cloudsearch.connectors.sites.Connector$SitesRepository.buildDocumentAndChildren(Connector.java:307)
at com.sword.cloudsearch.connectors.sites.Connector$SitesRepository.getDoc(Connector.java:253)
at com.google.enterprise.cloudsearch.sdk.indexing.template.ListingConnector.process(ListingConnector.java:300)
at com.google.enterprise.cloudsearch.sdk.indexing.traverser.ParallelProcessingTraverserWorker$PollAndProcessRunnable$ProcessingFunction.call(ParallelProcessingTraverserWorker.java:192)
at com.google.enterprise.cloudsearch.sdk.indexing.traverser.ParallelProcessingTraverserWorker$PollAndProcessRunnable$ProcessingFunction.call(ParallelProcessingTraverserWorker.java:180)
at java.base/java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:264)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java)
... 3 more

I tried importing the corresponding Maven dependency but the Strings class doesn't seem to be inside.

Thanks,
Hugo GEORGET

Add support for "Increase ranking based on item context attributes" in the Indexing Connector SDK

Add support in Indexing connector SDK for setting the named attributes associated with the item for influencing the ranking of the item based on the context in the request.

Interfaces are package private their implementations are not

Hi Folks,

I have noticed that the UsersService interface is package private while the implementation is not. This leads to an unintuitive API.
The entry point for all of the identity services (UsersService, GroupsService) are the IdentityService interface and the regarding implementation IdentityServiceImpl.

To be more convenient - you should either make GroupsServiceImpl and UsersServiceImpl package private or the regarding interfaces public.

Please verify - I would add a pull requests with the changes necessary.

[v1-0.0.5] Wrong tag name

Hi,

The v1-0.0.5 release name does not follow the naming convention.
Right now, it is "v1.0.0-5" but it should be "v1-0.0.5".

It also makes the README.md invalid since the

git checkout tags/v1-0.0.5

command will not work.

Is it possible to fix this ?

Thank you.

Stale version number specified.

Hi

How can i delete an item when "Stale version number specified." error incoming ?

Request failed with error {"code":400,"errors":[{"domain":"global","message":"Stale version number specified. ","reason":"failedPrecondition"}],"message":"Stale version number specified. ","status":"FAILED_PRECONDITION"}

Update CloudSearch API Services to include recent additions

connector-sdk/sdk/pom.xml

Line 143 in dd12cfd

<version>v1-rev18-1.25.0</version>

Have you considered updating the CloudSearch API Services to a newer version to pick up some recent changes in the API? For example, the current version you have here does not include newer things like PropertyDefinition.setIsSuggestable() or setIsWildcardSearchable().

Authorization Error - Invalid Scope; likely due to provisioning issues

When trying to explore the Cloud Search API v1 API, I am seeing Authorization Errors due to invalid_scope on pretty much all the scopes declared by the Cloud Search API.

Also, approaching it from the GSuite angle, while access via https://cloudsearch.google.com works just fine querying stock GSuite data, trying to add a 3rd party source - https://admin.google.com/ac/apps/cloudsearch/datasources - does nothing and fails silently. Further, there is no 'Third-party data sources' card in Apps > G Suite > Settings for Cloud Search page.

I suspect that this may be due to the service not being provisioned on my GCP/GSuite account from Google Sales' end. If so, what is the fastest way to request approval? I have already filled out the form at https://cloud.google.com/products/search/apply/.

Would upgrading to an enterprise GSuite account help? We are implementing a large scale proof of concept and any pointers to expedite would be greatly appreciated.