google-deepmind/xitari

This is the 0.4 release of the Arcade Learning Environment (ALE), a platform designed for AI research. ALE is based on Stella, an Atari 2600 VCS emulator.

xitari's Issues

Problem with running ROMs with improper names

This bug is regarding the DQN demo provided here.

There is an undocumented and undisplayed error in the code that should be addressed. If an improper name of the ROM is used (for example "Breakout" instead of "breakout"), the program simply crashes with a SEGFAULT leaving the user clueless of what they are doing wrong.

The problem is caused by the buildRomRLWrapper function within the games/Roms.cpp file, where the loop is looking through a list of supported ROMs. If the name isn't matched exactly, the method silently returns NULL, causing a crash down the road.

Here are a couple of proposed solutions:

1. Make a note in the README files about the list of supported ROMs and their proper naming convention
2. If possible, make the program output a warning inside the buildRomRLWrapper function before the NULL is returned. Say something like "The ROM XXX isn't supported. Please make sure the name is written correctly!"
3. Fix this entirely, by asking the user to provide the codename (or some kind of ID) of the game, together with the ROM file, instead of relying on the file name itself - which is a poor practice.
4. Use md5sum in a hashmap to determine which game ROM it is that you are trying to load

xitari make error

when use luarocks make xitari-0-0.rockspec in win.

[ 50%] Built target ale
[100%] Built target xitari
Install the project...
-- Install configuration: "Release"
-- Up-to-date: C:/torch/luarocks/xitari/0-0/include/xitari/ale_interface.hpp
CMake Error at cmake_install.cmake:56 (file):
file INSTALL cannot find "C:/torch/xitari-master/libxitari.a": No error.

NMAKE : fatal error U1077: “D:\cmake\bin\cmake.exe”: 返回代码“0x1”
Stop.

Error: Build error: Failed installing.

help! please!!!

Cmake failed

When I run $PREFIX/bin/luarocks make under /tmp/xitari, I got the following error:

CMake Error: Generator: execution of make failed. Make command was: /tmp/xitari/make "cmTryCompileExec69850377/fast"
-- Check for working C compiler: /usr/bin/cc -- broken
CMake Error at /usr/share/cmake-2.8/Modules/CMakeTestCCompiler.cmake:61 (message):
The C compiler "/usr/bin/cc" is not able to compile a simple test program.

It fails with the following output:

Change Dir: /tmp/xitari/CMakeFiles/CMakeTmp

Run Build Command:/tmp/xitari/make "cmTryCompileExec69850377/fast"

Permission denied

Generator: execution of make failed. Make command was: /tmp/xitari/make
"cmTryCompileExec69850377/fast"

Can anyone help me with this?

Trained DQN models

Maybe you guys could publish trained models along with DQN code, it would save the world some energy.