Version 1.2 throws with "could not find 'app.yml' file"

[google-github-actions]

Version 1.2 throws with "could not find 'app.yml' file"

[sethvargo]

v1.2.1 was just released. If you do not set env_variables or build_env_variables, everything should work correctly. However, specifying those fields (which are new in 1.2) require the file to be named app.yaml.

If v1.2.1 fixes the issue, we can consider this enhancement to accept other appyaml file names, but it will be a slightly larger refactor and my primary goal is restoring the old behavior.

[sethvargo]

Hi @clintonb - with 1.2.1, you should be able to use dev-app.yaml and prod-app.yaml. You just cannot do that and set envvars or build envvars. Can you confirm?

[clintonb]

Source of the problem: v1.1.0...v1.2.0#diff-4fab5baaca5c14d2de62d8d2fceef376ddddcc8e9509d86cfa5643f51b89ce3dR289

[sethvargo]

Duplicate of #302, fix is in #305.

[sethvargo]

Actually wait - this is a slightly different error.

[sethvargo]

How are you deploying without an app.yaml deliverable?

[clintonb]

Our files are named app-dev.yaml and app-prod.yaml.

- id: deploy-dev
  name: 'Deploy dev services'
  uses: google-github-actions/deploy-appengine@v1
  with:
    promote: true
    deliverables: services/flex-worker/app-dev.yaml
    flags: '--stop-previous-version'
  env: 
    CLOUDSDK_APP_CLOUD_BUILD_TIMEOUT: 1200

[clintonb]

The new version is a bit too "smart".

[sethvargo]

I see. In order to update environment variables, we need to know the app.yaml. I've updated the logic in #305 to only try and parse the app.yaml if env/build_env is given. But short of reading the entire list of deliverables, I don't think we have a good way to determine which one is the "appyaml".

[clintonb]

Confirmed that our deploys are working once more after renaming to (dev|prod)-app.yaml.