google/fplutil

fplutil is a set of small libraries and tools that can be useful when developing applications for Android and other platforms.

fplutil's Issues

python build scripts don't escape paths on Windows

Running with "-d @ -r" on Windows, I get the output:

BUILD SUCCESSFUL
Total time: 4 seconds
Subprocess returned 1
Traceback (most recent call last):
  File "build_all_android.py", line 212, in <module>
    sys.exit(main())
  File "build_all_android.py", line 171, in main
    adb_devices = [d.serial for d in env.get_adb_devices()]
  File "C:\w\lobster\dev\android\buildutil\android.py", line 1182, in get_adb_devices
    capture=True, shell=True)[0]
  File "C:\w\lobster\dev\android\buildutil\common.py", line 470, in run_subprocess
    raise SubCommandError(argv, process.returncode, stderr)
buildutil.common.SubCommandError: Error 1 running C as: C:\Program Files (x86)\Android\android-sdk\platform-tools\adb.exe devices -l, stderr: {'C:\Program' is not recognized as an internal or external command,
operable program or batch file.
}

Appears it should be quoting paths somewhere.

Supported device list

Hi there,

I've only seen 4 devices in SUPPORTED_DEVICES and BROKEN_DEVICES from the source code.

SUPPORTED_DEVICES = set([
'mantaray', # Nexus 10
'nakasi', # Nexus 7 (2012)
])
BROKEN_DEVICES = set([
'razor', # Nexus 7 (2013)
'hammerhead', # Nexus 5
])

And I've tested Nexus 5(hammerhead) and seen a warning message when I tried ./android_ndk_perf --apk testbed-debug.apk record -o perf.data.

WARNING: AOSP on HammerHead is not in the list of supported devices. It is likely that the
performance counters don't work so you may need to try a different device.

So I'd like to ask whether Nexus 6/5x is supported by Android perf, as I badly need to use to perf to profile my apk to show its run-time call graph. Thanks.

Security Policy violation Binary Artifacts

This issue was automatically created by Allstar.

Security Policy Violation
Project is out of compliance with Binary Artifacts policy: binaries present in source code

Rule Description
Binary Artifacts are an increased security risk in your repository. Binary artifacts cannot be reviewed, allowing the introduction of possibly obsolete or maliciously subverted executables. For more information see the Security Scorecards Documentation for Binary Artifacts.

Remediation Steps
To remediate, remove the generated executable artifacts from the repository.

First 10 Artifacts Found

• libs/cardboard.jar
• libs/libprotobuf-java-2.6-nano.jar
• perf/bin/android-16/arch-arm/perf
• perf/bin/android-16/arch-x86/perf
• perf/bin/android-16/linux-x86/perfhost
• perf/bin/android-17/arch-arm/perf
• perf/bin/android-17/arch-mips/perf
• perf/bin/android-17/arch-x86/perf
• perf/bin/android-17/linux-x86/perfhost
• perf/bin/android-18/arch-arm/perf
• Run a Scorecards scan to see full list.

Additional Information
This policy is drawn from Security Scorecards, which is a tool that scores a project's adherence to security best practices. You may wish to run a Scorecards scan directly on this repository for more details.

---

Allstar has been installed on all Google managed GitHub orgs. Policies are gradually being rolled out and enforced by the GOSST and OSPO teams. Learn more at http://go/allstar

This issue will auto resolve when the policy is in compliance.

Issue created by Allstar. See https://github.com/ossf/allstar/ for more information. For questions specific to the repository, please contact the owner or maintainer.

Unable to run android_ndk_perf on Nexus 9

Following the instructions here: https://google.github.io/fplutil/android_ndk_perf.html. I run the following command:

cd liquidfun/Box2D/Testbed android_ndk_perf --apk bin/testbed-debug.apk record -o output/perf.data

This produces the following error:

WARNING: Nexus 9 is not in the list of supported devices. It is likely that the
performance counters don't work so you may need to try a different device.

run-as: exec failed for /data/local/tmp/perf: Permission denied
243
chmod: /data/data/com.google.fpl.liquidfun.testbed/perf.data: No such file or directory
1
0
Unable to make /data/data/com.google.fpl.liquidfun.testbed/perf.data readable.

Cannot build on linux

When I try to build with the latest ndk (r15) and build-tools I have that error:

---

The "android" command is deprecated.
For manual SDK, AVD, and project management, please use Android Studio.
For command-line tools, use tools/bin/sdkmanager and tools/bin/avdmanager

---

Invalid or unsupported command "update project --path /usr/local/google/home/dmabin/dev/sample-jni/fplutil/libfplutil/unit_tests/test_main --target android-25 --name test_main"

Supported commands are:
android list target
android list avd
android list device
android create avd
android move avd
android delete avd
android list sdk
android update sdk
Subprocess returned 2
Caught buildutil error: Error 2 running /usr/local/google/home/dmabin/Android/Sdk/tools/android as: ['/usr/local/google/home/dmabin/Android/Sdk/tools/android', 'update', 'project', '--path', '/usr/local/google/home/dmabin/dev/sample-jni/fplutil/libfplutil/unit_tests/test_main', '--target', 'android-25', '--name', 'test_main'], stderr: {not captured}

android_ndk_perf: Symbols not appearing in reports.

I'm trying to profile my NDK code, but symbols don't show up in the results. I've followed the steps to enable debuggable builds, and i can see function names using nm on the .a file in my libs folder. But this is what i see in the HTML report:

http://i.imgur.com/7XxJgxk.png

-mapcs-frame option not working with clang

I am not able to build my project with compiler flag - mapcs_frame for android_ndk_perf profiler. Clang++ compiler doesn't support this option. Is there any equivalent option for clang?

I am using the clang compiler shipped with NDK version 12.2.0.

Android.mk invalid argument '-std=c99' not allowed with 'C++/ObjC++'

I'm trying to integrate libfplutils printf redirection into an existing project with the older Android.mk system on NDK-13b.

I notice you have included an Android.mk in the jni tree of this project. However, it seems there may be a mistake that it has c library with the cpp code? Line 64: https://github.com/google/fplutil/blob/master/libfplutil/jni/Android.mk#L64

Thank you.

Add GitHub repo description

Would be nice to see it in the list at https://github.com/google