google/googledatatransport

googledatatransport's Issues

[10.0.0] Bump `swift-tools-version` to `5.6`.

Build Failed

I'm developing a React Native app and when I run react-native run-ios I receive this error related with GoogleDataTransport:

The following build commands failed:
CompileC /Users/fair/Library/Developer/Xcode/DerivedData/FairMobile-bqgeuszvlfcgenemmqawwkroifuq/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/GoogleDataTransport.build/Objects-normal/x86_64/GDTCCTUploadOperation.o /Users/fair/Documents/fair-mobile-react-native/ios/Pods/GoogleDataTransport/GoogleDataTransport/GDTCCTLibrary/GDTCCTUploadOperation.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

How can I proceed?

Undefined symbol: _GDTCCTConstructiOSClientInfo

This issue occured after update xcode 14.2 to 14.3.

Thread Sanitizer Data race in [GDTCCTUploadOperation finishOperation]

I've just ran my code trough Thread Sanitizer and got report for data race in GDTCCTUploadOperation

We use the following Pods

  pod 'Firebase/Core'
  pod 'Firebase/Performance'
  pod 'Firebase/Messaging'
  pod 'Firebase/Analytics'
  pod 'Firebase/Crashlytics'

Already updated to latest versions:

Installing Firebase 7.9.0 (was 7.8.1)
Installing FirebaseABTesting 7.9.0 (was 7.8.0)
Installing FirebaseAnalytics 7.9.0 (was 7.8.1)
Installing FirebaseCore 7.9.0 (was 7.8.0)
Installing FirebaseCoreDiagnostics 7.9.0 (was 7.8.0)
Installing FirebaseCrashlytics 7.9.0 (was 7.8.0)
Installing FirebaseInstallations 7.9.0 (was 7.8.0)
Installing FirebaseInstanceID 7.9.0 (was 7.8.0)
Installing FirebaseMessaging 7.9.0 (was 7.8.0)
Installing FirebasePerformance 7.9.0 (was 7.8.0)
Installing FirebaseRemoteConfig 7.9.0 (was 7.8.0)
Installing GoogleAppMeasurement 7.9.0 (was 7.8.1)

In code we have custom Crashlytics logs and custom analytics event and screen tracking.
The project uses Swift + SwiftUI and targets iOS 14.
The issue has been detected on iOS 14 Simulator.

Console output:

WARNING: ThreadSanitizer: data race (pid=72528)
  Write of size 1 at 0x7b44000901f9 by thread T18:
    #0 -[GDTCCTUploadOperation finishOperation] GDTCCTUploadOperation.m:508 (GoogleDataTransport:x86_64+0x11821)
    #1 __53-[GDTCCTUploadOperation uploadTarget:withConditions:]_block_invoke.72 GDTCCTUploadOperation.m:184 (GoogleDataTransport:x86_64+0xccdf)
    #2 __44-[FBLPromise(CatchAdditions) onQueue:catch:]_block_invoke FBLPromise+Catch.m:34 (FBLPromises:x86_64+0xbf1e)
    #3 __56-[FBLPromise chainOnQueue:chainedFulfill:chainedReject:]_block_invoke.68 FBLPromise.m:277 (FBLPromises:x86_64+0x2378f)
    #4 __44-[FBLPromise observeOnQueue:fulfill:reject:]_block_invoke_2 FBLPromise.m:229 (FBLPromises:x86_64+0x22738)
    #5 __wrap_dispatch_group_async_block_invoke <null>:2 (libclang_rt.tsan_iossim_dynamic.dylib:x86_64+0x71c37)
    #6 _dispatch_client_callout <null>:2 (libdispatch.dylib:x86_64+0x39c7)

  Previous read of size 1 at 0x7b44000901f9 by thread T16:
    #0 -[GDTCCTUploadOperation isFinished] GDTCCTUploadOperation.m:489 (GoogleDataTransport:x86_64+0x11cec)
    #1 __NSOQSchedule_f <null>:2 (Foundation:x86_64+0xddcee)
    #2 _dispatch_client_callout <null>:2 (libdispatch.dylib:x86_64+0x39c7)

  Location is heap block of size 320 at 0x7b4400090100 allocated by thread T16:
    #0 calloc <null>:2 (libclang_rt.tsan_iossim_dynamic.dylib:x86_64+0x4f072)
    #1 _objc_rootAllocWithZone <null>:2 (libobjc.A.dylib:x86_64+0x16a99)
    #2 __52-[GDTCORUploadCoordinator uploadTargets:conditions:]_block_invoke GDTCORUploadCoordinator.m:112 (GoogleDataTransport:x86_64+0x4352b)
    #3 __tsan::invoke_and_release_block(void*) <null>:2 (libclang_rt.tsan_iossim_dynamic.dylib:x86_64+0x70ebb)
    #4 _dispatch_client_callout <null>:2 (libdispatch.dylib:x86_64+0x39c7)

  Thread T18 (tid=3005412, running) is a GCD worker thread

  Thread T16 (tid=3004697, running) is a GCD worker thread

SUMMARY: ThreadSanitizer: data race GDTCCTUploadOperation.m:508 in -[GDTCCTUploadOperation finishOperation]

Screenshots:

Improve testing CI to test SPM builds with warnings-as-errors

Memory leak or cycle reference question

Will this place cause a cycle reference?

Function is copied from a Stack overflow Response with License CC BY-SA 3.0

Hi,
I'm using Crashlytics for iOS for a new App, but the legal department of my company found out that a function of this library is directly copied from a Stack Overflow response for which it automatically has the license CC BY-SA 3.0

The concerned lines are from line 44 to 53 and 62-74 from this file.

This makes the current license Apache License 2.0 from this library incorrect.

Can you please solve this issue?

Crash on GDTCCTUploader.m

Hi,

we are using latest Firebase, that is using latest GoogleDataTransport (9.0.1). We found crash in crashlytics today:

Crashed: com.google.GDTCORUploadCoordinator
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x7000000010cf7047
-[GDTCCTUploader uploadTarget:withConditions:]


Crashed: com.google.GDTCORUploadCoordinator
0  Foundation                     0x181e90f5c ____addOperations_block_invoke.621 + 228
1  Foundation                     0x181e8fb7c __addOperations + 1272
2  Bibino                         0x10086d814 -[GDTCCTUploader uploadTarget:withConditions:] + 121 (GDTCCTUploader.m:121)
3  Bibino                         0x10087d050 __52-[GDTCORUploadCoordinator uploadTargets:conditions:]_block_invoke + 113 (GDTCORUploadCoordinator.m:113)
4  libdispatch.dylib              0x180d58aa0 _dispatch_call_block_and_release + 24
5  libdispatch.dylib              0x180d58a60 _dispatch_client_callout + 16
6  libdispatch.dylib              0x180d629b4 _dispatch_queue_serial_drain$VARIANT$mp + 608
7  libdispatch.dylib              0x180d632fc _dispatch_queue_invoke$VARIANT$mp + 336
8  libdispatch.dylib              0x180d63cc8 _dispatch_root_queue_drain_deferred_wlh$VARIANT$mp + 340
9  libdispatch.dylib              0x180d6c098 _dispatch_workloop_worker_thread$VARIANT$mp + 668
10 libsystem_pthread.dylib        0x18108be70 _pthread_wqthread + 860
11 libsystem_pthread.dylib        0x18108bb08 start_wqthread + 4

The dependency version on cocoapods is incorrect

I found that 9.4.0 version on Cocoapods，the version range marked with nanoPB is < 2.30910.0, which is inconsistent with the actual code.

Can you re release a correct version

https://github.com/CocoaPods/Specs/blob/master/Specs/0/6/a/GoogleDataTransport/9.4.0/GoogleDataTransport.podspec.json

Getting `Null pointer passed as argument 1, which is declared to never be null`

ℹ️

Getting Null pointer passed as argument 1, which is declared to never be null message from

GoogleDataTransport/GoogleDataTransport/GDTCORLibrary/GDTCORLogSourceMetrics.m

Line 55 in 6e27aa5

[NSMutableDictionary dictionaryWithDictionary:eventCounterByLogSource[event.mappingID]];

🖼️

[FR]: Support for Apple Privacy Info Manifest-Files

Apple will enforce the requirement for a privacy info manifest file for all third party libraries this year.
More information can be looked up here: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files
The library needs to be updated to include a privacy info manifest-file

Can the client use only the most secure protocols?

Can the client use only the most secure protocols?

GoogleDataTransport/GoogleDataTransport/GDTCCTLibrary/GDTCCTUploadOperation.m

Line 106 in 25449cd

_uploaderSession = [NSURLSession sessionWithConfiguration:config

Rename `transform:` API due to App Store Rejections

Originally reported in firebase/firebase-ios-sdk#7177

The existing transform: public API can lead to false-positives regarding private API usage in the App Store. We should rename it to avoid this, likely adding a prefix, renaming to transformGDTEvent:, or something similar.

GoogleDataTransport/GoogleDataTransport/GDTCORLibrary/Public/GoogleDataTransport/GDTCOREventTransformer.h

Line 34 in c654af7

- (nullable GDTCOREvent *)transform:(GDTCOREvent *)event;

This is a breaking change, so all dependencies need to be updated as well.

Cleanup directory structure

• Clean up GoogleDataTransport/ to align with guidelines
• Package.swift TODO
• Conversation here

Bazel/Blaze BUILD

Hey Googlers!

Any chance you'd be down to release the Blaze/Bazel (Blazel!) BUILD files for this code? Would be handy to those of use building with Bazel.

Two of the external dependencies have done so already (nanopb and PromisesObjC), and I'd asked GoogleUtilities if they'd do the same in google/GoogleUtilities#72

If useful, here's one I spun up for my own quick use.

# Created from https://github.com/google/GoogleDataTransport/blob/1a65c30db4fc841e06586441682c2dda036d9db3/GoogleDataTransport.podspec

objc_library(
    name = "GoogleDataTransport",
    hdrs = glob(["GoogleDataTransport/GDTCORLibrary/Public/GoogleDataTransport/*.h"]),
    visibility = ["//visibility:public"],

    srcs = glob(["GoogleDataTransport/GDTCORLibrary/**/*", "GoogleDataTransport/GDTCCTLibrary/**/*"]),
    deps = [
        "@GooglePromises//:FBLPromises",
        "@GoogleUtilities//:Environment",
        "@GoogleUtilities//:Logger",
        "@nanopb//:nanopb",
    ],
    sdk_frameworks = [
        "CoreTelephony",
        "SystemConfiguration",
    ],
    sdk_dylibs = ["libz"],
)

Thanks for your consideration!
Chris
(ex-Googler)

P.S. To load nanopb, you'll need a patch file to enable malloc. To save time, here's one that works for the latest commit (2210cd92a6237a9ff82b58cfbe0c58da25ce1e11) that supports the compiled protos you're embedding

--- pb.h
+++ pb.h
@@ -13,2 +13,2 @@
 /* Enable support for dynamically allocated fields */
-/* #define PB_ENABLE_MALLOC 1 */
+#define PB_ENABLE_MALLOC 1

--- BUILD
+++ BUILD
@@ -7,2 +7,3 @@
 cc_library(
   name = "nanopb",
+  include_prefix = "nanopb",