googlearchive/apps-resource-loader

apps-resource-loader's Issues

Readme

Add one.

[enhancement] Add missing bower.json.

Hey, maintainer(s) of GoogleChrome/apps-resource-loader!

We at VersionEye are working hard to keep up the quality of the bower's registry.

We just finished our initial analysis of the quality of the Bower.io registry:

7530 - registered packages, 224 of them doesnt exists anymore;

We analysed 7306 existing packages and 1070 of them don't have bower.json on the master branch ( that's where a Bower client pulls a data ).

Sadly, your library GoogleChrome/apps-resource-loader is one of them.

Can you spare 15 minutes to help us to make Bower better?

Just add a new file bower.json and change attributes.

{
  "name": "GoogleChrome/apps-resource-loader",
  "version": "1.0.0",
  "main": "path/to/main.css",
  "description": "please add it",
  "license": "Eclipse",
  "ignore": [
    ".jshintrc",
    "**/*.txt"
  ],
  "dependencies": {
    "<dependency_name>": "<semantic_version>",
    "<dependency_name>": "<Local_folder>",
    "<dependency_name>": "<package>"
  },
  "devDependencies": {
    "<test-framework-name>": "<version>"
  }
}

Read more about bower.json on the official spefication and nodejs semver library has great examples of proper versioning.

NB! Please validate your bower.json with jsonlint before commiting your updates.

Thank you!

Timo,
twitter: @versioneye
email: [email protected]
VersionEye - no more legacy software!

Specify based directory to store files

I can see many apps not wanting /mainfest.json plus directories etc in the root of the HTML5 Filesystem, but rather under a specially named directory.

If a manifest is not loaded, everything fails

If a file is not in the manifest it will not be saved in the file system.

RAL.Queue.Add(undefined) causes a failure

There was a weird situation where adding an image element that didn't caused a weired series of events where the manifest would not be fetched and stored.

The manifest issue is because the first file requested caused the error and stop subsequent processing.

Suggestion, fail in a better way when we know there is a change or erroring based on bad input

Uncaught TypeError: Cannot call method 'replace' of undefined Sanitiser.js:11

I have created a simple chrome app, testing in Chrome Canary, where I try to inject two images into a div, exactly as suggested in the readme. The div is

I get the error in the title; this happens at the end of the script after the RAL.Queue.start(); it looks like the cleanURL function is being called with empty url. I checked and the loop is going through the two URLs ok, and the div gets two empty tags appended to it.

My images are valid and declared as in readme
toLoad = { 'images': [
'http://criteeq.net/images/blue-dot.png',
'http://criteeq.net/images/red-dot.png'
] }; // list of image URLs

and I have set permission in the manifest
"permissions": [ "<all_urls>" ],
(NOTE : in the readme the permission is per below, which throws an error (single quotes)
permissions: [ '<all_urls>' ]

also tried
"permissions": [ "http://criteeq.net/*" ],

In Chrome Canary in chrome://extensions if I check Permissions on my app, I get "(appname) has no special permissions", no matter what urls I put in permissions, this seems to be a bug in Chrome (sorry for the tangent).

Loaded images appear with a 1px grey border

The asset loader inserts images by creating an <img> tag with no src attribute, and setting the CSS background-image property to refer to the blob response from the XHR.

The image element is rendered with a 1px grey border because of the empty src attribute. The background image appears behind it, but the border cannot be removed.

This effect can be seen in the included demo. A smaller test case for the rendering artifact can be found here: http://jsfiddle.net/gRpRK/1/

Switching to use a valid src attribute pointing to a 1px transparent image appears to render correctly.

Create a unit test suite

There are no tests @paullewis is too bad-ass for them