googlecodelabs/android-design-library

Build a Material Design App with the Android Design Support Library

android-design-library's Issues

Material design codelab not in English.

On the following link:
Material Design Codelabs

Line Missing in Online Tutorial Version, in 5 Style Each View, Under #14

On the webpage tutorial, in the section #5 Style Each View and Add a Recycler View
Then under #14, in the TileContentFragment onCreateView class, there are two recyclerView statements when there should be three as listed in GitHub

public View onCreateView(LayoutInflater inflater, ViewGroup container,
Bundle savedInstanceState) {
RecyclerView recyclerView = (RecyclerView) inflater.inflate(
R.layout.recycler_view, container, false);
ContentAdapter adapter = new ContentAdapter();
recyclerView.setAdapter(adapter);
recyclerView.setHasFixedSize(true);

    // this is the 3rd recyclerView.set statement added from Github that is missing in the online tutorial
    recyclerView.setLayoutManager(new LinearLayoutManager(getActivity()));

Build error: values-21 should be values-v21

The error is in this step:
https://codelabs.developers.google.com/codelabs/material-design-style/#6

This paragraph is wrong:

In values-21 folder, update styles.xml to create system bar transparent for device running Android 5 and above.

See this answer: http://stackoverflow.com/a/31361546.

Tutorials are missing

It's a such wonderful tutorial, but I just found that the chapters of the tutorial are missing.
All the other topics on website are missing as well, please check it out, thanks.
http://www.code-labs.io/codelabs/material-design-style/index.html

Navigation drawer

there is code for navigation drawer but it dosent work on sliding from any side

After importing 1-Base, SDK location not found

1. Double checked local.properties in root have location of my SDK: sdk.dir=/Applications/android-sdk-mac_x86. (Using Mac, 10.11). Tried manually to change SDK location in sdk.dir using relative notation ../../../ (etc), same outcome
2. Tools-Android-SDK Managers sees SDK, all updated, Android Support Library 23.1 Installed, Build-tools 23.1 installed, SDK tools 24.4.1 installed
3. while importing project, tried both manually specifying Gradle location (inside AStudio package (2.4)), or leave it for AStudio to download Gradle

Anyone has suggestions? Other projects on this machine works without problem (projects using design support lib)

1-Base hardcodes the status bar color

In 1-Base v21/styles there is a line

<item name="android:statusBarColor">@android:color/black</item>

https://github.com/googlecodelabs/android-design-library/blob/master/1-Base/src/main/res/values-v21/styles.xml#L20

When we try to do the first step here at
https://www.code-labs.io/codelabs/Material-Design-Style/index.html#2

The status bar color on lollipop devices will not be the blue shown in the screenshot but black instead. Commenting out the above line will result in the correct behavior.

Toolbar partially covered by status bar

to trigger this, select Tile tab, click on any image and then scroll by touching the appbar then the toolbar will partially be covered by the status bar.

Drawer is not open & close for some android phone

The code to open drawer is

NavigationView navigationView = (NavigationView) findViewById(R.id.nav_view);
// navigationView.setNavigationItemSelectedListener(
// new NavigationView.OnNavigationItemSelectedListener() {
// // This method will trigger on item Click of navigation menu
// @OverRide
// public boolean onNavigationItemSelected(MenuItem menuItem) {
// // Set item in checked state
// menuItem.setChecked(true);
//
// // TODO: handle navigation
//
// // Closing drawer on item click
// mDrawerLayout.closeDrawers();
// return true;
// }
// });

//need to replace and using the action bar
//or u can refer this link
https://github.com/google-developer-training/android-fundamentals-apps-v2/tree/master/NavDrawerExperiment

ActionBarDrawerToggle toggle = new ActionBarDrawerToggle(
this, mDrawerLayout, toolbar, R.string.navigation_drawer_open, R.string.navigation_drawer_close);
mDrawerLayout.setDrawerListener(toggle);
toggle.syncState();

FAB issue

The FAB button on example 5 hasn't got proper elevation or shadow.

Layouts customisation error

Setting layout_height as match_parent in item_list, item_card, item_tiles doesn't give expected view. It should be set to wrap text

Doc typo "activty_main.xml"

In http://www.code-labs.io/codelabs/material-design-style/index.html#5 you have "activty_main.xml" instead of "activity_main.xml"

Transition between CardView and DetailView

I would like to implement a transition between those two activities.
It would be nice to have a sample code that show how to implement this transition !
https://material.io/guidelines/motion/material-motion.html#material-motion-what-makes-a-good-transition

Deprecate samples

Deprecate samples in favor of https://github.com/material-components/material-components-android-codelabs

TextInputLayout error customization

hi. the error shown in TextInputLayout which is in the Design Library is in a default style.you cant align it to right or change the TypeFace of it.

ActionBar comes front

Navigation drawer goes behind action bar..and in detail activity collapsing toolbar goies behind actionbar..i checked completeley in code..give me some solutions..