gopasspw/git-credential-gopass

Gopass git-credentials helper

git-credential-gopass's Issues

Please add a minimal setup documentation

Please add a minimal setup documentation

Building 1.14.3 fails with assertion error

Hi,

I am trying to build the official Arch Linux package for git-credential-gopass and I am running into an assertion error:

go: downloading github.com/gopasspw/gopass v1.14.3
go: downloading github.com/urfave/cli/v2 v2.10.3
go: downloading github.com/xrash/smetrics v0.0.0-20201216005158-039620a65673
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.2
go: downloading github.com/russross/blackfriday/v2 v2.1.0
go: downloading github.com/blang/semver/v4 v4.0.0
go: downloading github.com/fatih/color v1.13.0
go: downloading golang.org/x/term v0.0.0-20220526004731-065cf7ba2467
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading gopkg.in/yaml.v3 v3.0.1
go: downloading github.com/dustin/go-humanize v1.0.0
go: downloading github.com/caspr-io/yamlpath v0.0.0-20200722075116-502e8d113a9b
go: downloading golang.org/x/exp v0.0.0-20220613132600-b0d781184e0d
go: downloading golang.org/x/crypto v0.0.0-20220622213112-05595931fe9d
go: downloading filippo.io/age v1.0.0
go: downloading github.com/nbutton23/zxcvbn-go v0.0.0-20210217022336-fa2cb2858354
go: downloading github.com/twpayne/go-pinentry v0.2.0
go: downloading github.com/hashicorp/go-multierror v1.1.1
go: downloading bitbucket.org/creachadair/stringset v0.0.10
go: downloading github.com/hashicorp/golang-lru v0.5.4
go: downloading github.com/ProtonMail/go-crypto v0.0.0-20220623141421-5afb4c282135
go: downloading github.com/google/go-github v17.0.0+incompatible
go: downloading github.com/google/go-cmp v0.5.8
go: downloading github.com/mattn/go-colorable v0.1.12
go: downloading github.com/mattn/go-isatty v0.0.14
go: downloading github.com/hashicorp/errwrap v1.1.0
go: downloading golang.org/x/sys v0.0.0-20220622161953-175b2fd9d664
go: downloading github.com/google/go-querystring v1.1.0
go: downloading go.uber.org/multierr v1.8.0
go: downloading github.com/rs/zerolog v1.27.0
go: downloading go.uber.org/atomic v1.9.0
go: downloading filippo.io/edwards25519 v1.0.0
tput: unknown terminal "unknown"
tput: unknown terminal "unknown"
>> BUILD, version = 1.12.0/5449acee, output = git-credential-gopass# github.com/gopasspw/gopass/internal/backend
/build/go/pkg/mod/github.com/gopasspw/[email protected]/internal/backend/registry.go:85:45: internal compiler error: assertion failed

Please file a bug report including a short program that triggers the error.
https://go.dev/issue/new
make: *** [Makefile:70: git-credential-gopass] Error 2

How do I solve this?

make install error: No rule to make target 'install-completion'

Running make install results in:

make: *** No rule to make target 'install-completion', needed by 'install'.  Stop.

Looks like the Makefile has a stray target here:

install: all install-completion

I have noticed the same for gopass-hibp and gopass-summon-provider.

Credentials end up in the repo to be cloned

Further research needed! I got this issue on an empty repo and a credential helper with a mounted store.

$ git clone http://localhost:3000/jens/store-team1.git
Cloning into 'store-team1'...
Username for 'http://localhost:3000': jens
Password for 'http://jens@localhost:3000':
⚠ Failed to pull before git push: exit status 1: fatal: couldn't find remote ref master
warning: You appear to have cloned an empty repository.
$ cd store-team1/

$ git status
On branch master
Your branch is based on 'origin/master', but the upstream is gone.
  (use "git branch --unset-upstream" to fixup)

Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        deleted:    git/localhost_3000/jens.gpg

no changes added to commit (use "git add" and/or "git commit -a")

git-credential doesn't work with host have colon ":"

Summary

I'm testing for gopasspw/gopass#1670
My usual workflow involve git-sendemail and I'm using pass to store my password.
When git-sendemail invoked, it will invoke a git-credential helper to get my password.
Usually, I use this script https://raw.githubusercontent.com/sgn/dotfiles/414ac02ae383b52b4713b2870244afeebdcdbe0d/bin/git-credential-pass

I tried gopass but it doesn't work because the host sent by git has a colon

Steps To Reproduce

gopass-git-credentials get <<_EOF
protocol=smtp
host=smtp.gmail.com:465
[email protected]
<_EOF

Expected behavior

credential filled

Environment

• OS: Linux 5.10.3
• OS version: [uname -a]
• gopass Version: e3d38c3c81a7e62778b2f78244aecf58df6799df
• Installation method: source

Additional context

git clone failed with entry not in the password store

hello,

a plain simple clone attempt has failed with the following error

git clone https://x.y.z/abc.git
Cloning into 'abc'...

Error: failed to retrieve secret "get": entry is not in the password store
Username for 'https://x.y.z': abc
Password for 'https://[email protected]': 

Error: failed to retrieve secret "store": entry is not in the password store
remote: Enumerating objects: 2733, done.
remote: Counting objects: 100% (2733/2733), done.
remote: Compressing objects: 100% (2440/2440), done.
remote: Total 2733 (delta 1767), reused 401 (delta 285), pack-reused 0
Receiving objects: 100% (2733/2733), 379.23 KiB | 2.30 MiB/s, done.
Resolving deltas: 100% (1767/1767), done.

gopass installation method

$ gopass setup --storage fs

relevant config

[credential]
	credentialStore = gpg
	helper =
	helper = /usr/bin/gopass
[gpg]
	program = /usr/bin/gpg

$ cat ~/.config/gopass/config.yml
autoclip: false
autoimport: false
cliptimeout: 45
exportkeys: true
nopager: false
notifications: true
parsing: true
path: /home/xyz/.password-store
safecontent: false
mounts: {}
keychain: false

$ /usr/bin/gopass ls
gopass

relevant trace log

$ GIT_CURL_VERBOSE=1 GIT_TRACE=1 git clone https://x.y.z/abc.git
...
09:51:09.618663 run-command.c:664       trace: run_command: '/usr/bin/gopass get'

Error: failed to retrieve secret "get": entry is not in the password store
Username for 'https://x.y.z': abc
Password for 'https://[email protected]':
...
09:51:18.421130 run-command.c:664       trace: run_command: '/usr/bin/gopass store'

Error: failed to retrieve secret "store": entry is not in the password store
...

versions

$ /usr/bin/gopass -v
gopass 1.14.9 go1.19.1 linux arm64

$ git --version
git version 2.30.2

Build is broken since update to gopass 1.12.2

I testet it with git bisect:

FAIL github.com/gopasspw/git-credential-gopass [build failed]
FAIL
make: *** [Makefile:81: test] Error 1
d60e4c6 is the first bad commit
commit d60e4c6
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Mon Mar 15 08:36:39 2021 +0000

Bump github.com/gopasspw/gopass from 1.12.1 to 1.12.2

Bumps [github.com/gopasspw/gopass](https://github.com/gopasspw/gopass) from 1.12.1 to 1.12.2.
- [Release notes](https://github.com/gopasspw/gopass/releases)
- [Changelog](https://github.com/gopasspw/gopass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/gopasspw/gopass/compare/v1.12.1...v1.12.2)

Signed-off-by: dependabot[bot] <[email protected]>

go.mod | 2 +-
go.sum | 39 +++++++++++++--------------------------
2 files changed, 14 insertions(+), 27 deletions(-)
bisect run success
`