goto-bus-stop/flat-loader

Scope hoisting Webpack loader based on Rollup. — use webpack 3's ModuleConcatenationPlugin instead!

flat-loader's Issues

add support for jsx files

I was not able to use it with jsx files.

Check if forcing webpack to add dependencies recursively is necessary

Doing this at the moment:

https://github.com/goto-bus-stop/flat-loader/blob/master/webpack-plugin.js#L9-L24

But it may not be necessary.

Make it work well with chunks

eg. given this:

// app.js
import './something'

import('./other-chunk').then(() => {})

// other-chunk.js
import './whatever'

both app.js and other-chunk.js could be rollup-ed.

"Module not found" on Windows when importing not from context dir

How to reproduce:

1. PC or VM with Windows
2. unzip example.zip
3. npm install
4. npm start

ERROR in ./src/app.js
Module not found: Error: Can't resolve './stylesstyle.css' in 'c:\work\example\src'
@ ./src/app.js 2:0-39
@ multi (webpack)-dev-server/client?http://localhost:8080 ./app.js

What happens:
Substitution of external module at https://github.com/goto-bus-stop/flat-loader/blob/master/webpack-plugin.js#L86 uses relative path which, in case of Windows, results into import "./style\styles.css" emitted into output. Backslash(es) then get interpreted as escape characters, not as path separators.

Proposed fix:
Backslashes should be replaced with '/'.
In the webpack-plugin.js, replace

return ${EXTERNAL_IDENTIFIER}./${relative.replace(/\.js$/, '')}

with

return ${EXTERNAL_IDENTIFIER}./${relative.replace(/\.js$/, '').replace(/\\/g, '/')}