govtechsg/butler-bot

Telegram bot for booking meeting rooms

butler-bot's Issues

Rounding error of /any function

Repro Steps

1. /any
2. 830pm - 930pm (any start time with 30min in it)
3. The booking will round down the start time to 0800pm

/booked is not working when message length is too long

Bot stopped responding to /booked after I made multiple booking.
Is it because max message length has reached?
How about splitting the text and send across multiple messages?

Json Key or Pem Key error

This is PEM error
listBookedEventsByRoom Error: Error: failed to obtain an authentication token, request failed with HTTP code 400: invalid_grant
listEmptySlotsInDay Error: Error: failed to obtain an authentication token, request failed with HTTP code 400: invalid_grant

Json Key error
listBookedEventsByRoom Error: Error: failed to sign JWT, the key is probably invalid
listEmptySlotsInDay Error: Error: failed to sign JWT, the key is probably invalid

Code here:
Settings.js

//require the Google API Json Key
const KEYFILE = '../data/xxxxxx-xxxxxxxxx.pem';
const SERVICE_ACCT_ID = [email protected]';
const CALENDAR_URL = 'https://calendar.google.com/calendar/embed?src=xxxxxxxxgmail.com&ctz=Asia%2FHong_Kong';
const CALENDAR_ID={"primary": "[email protected]","th":"[email protected]","ko":[email protected]","kc":"[email protected]","hl":"[email protected]","ml":"[email protected]","fg":"[email protected]","q1":[email protected]","q2":"[email protected]","qc":[email protected]","dr":[email protected]","bb":"[email protected]","tt":"[email protected]","mc":"[email protected]","ak":"[email protected]","sk":"[email protected]","zk":"[email protected]"
};
const TIMEZONE = 'UTC+08:00';

module.exports.calendarUrl = CALENDAR_URL;
module.exports.serviceAcctId = SERVICE_ACCT_ID;
module.exports.calendarId = CALENDAR_ID;
module.exports.keyFile = KEYFILE;
module.exports.timezone = TIMEZONE;

//To use, require the module in your application and pass in the necessary config file.
/const CONFIG = require('./config/settings.js');
const CalendarAPI = require('node-google-calendar');
let cal = new CalendarAPI(CONFIG);/

export { CONFIG as default, ROOM_CONFIG, SESSION_LENGTH, BOOKING_DURATION_OPTIONS };
`

.env file:

TELEGRAM_BOT_TOKEN=xxxxxxxxxxxxxxxxxttl_xxxxxxxxxxxxxx [email protected] CALENDAR_ID={"primary": "[email protected]","th":"[email protected]","ko":[email protected]","kc":"[email protected]","hl":"[email protected]","ml":"[email protected]","fg":"[email protected]","q1":[email protected]","q2":"[email protected]","qc":[email protected]","dr":[email protected]","bb":"[email protected]","tt":"[email protected]","mc":"[email protected]","ak":"[email protected]","sk":"[email protected]","zk":"[email protected]" }; CALENDAR_URL=https://calendar.google.com/calendar/embed?src=xxxxx%40gmail.com&ctz=Asia%2FHong_Kong GOOGLE_KEYFILE_PATH=../data/xxxx-xxxx.pem

Please Help Thanks!!

Unable to delete bookings if hit the max cap for bookings

Unable to view bookings when there is more than 20 bookings made

Todo

• Write unit tests

• Set up CI (Travis) to:

1. Build
2. Run test suite
3. Deploy to production server

• Find a better way to store/share secrets

• Manage user access list

1. Stash repo for user list
2. Bot to poll and reboot every time changes made to list

• Fix bugs

Bot Randomly Warning People For Forwarded Messages

I have had people forward messages to my group for over a year now no issues, randomly I woke up and a few people have warns for forwarding messages. I don't have anything blocked for forwarding messages, idk if it's a bug or something? I checked config, and everything looked to be the same as always.

Room booking reminders

I think it would be useful to send reminders to the user 5 min before the time slot starts and some actions to acknowledge or cancel the booking.
Also, maybe reminders 5 min before it ends to wrap up the meeting soon.

There have been times where I've booked a room in advance and forgot to cancel the booking when the meeting has been postponed.

Unhandled rejection Error: Error promptTimeslotSelection:

device log:

Unhandled rejection Error: Error promptTimeslotSelection: {}
    at /home/ubuntu/butler-bot/build/modules/TelegramBot.js:387:11
0|build    |     at tryCatcher (/home/ubuntu/butler-bot/node_modules/bluebird/js/release/util.js:16:23)
0|build    |     at Promise._settlePromiseFromHandler (/home/ubuntu/butler-bot/node_modules/bluebird/js/release/promise.js:510:31)
0|build    |     at Promise._settlePromise (/home/ubuntu/butler-bot/node_modules/bluebird/js/release/promise.js:567:18)
0|build    |     at Promise._settlePromise0 (/home/ubuntu/butler-bot/node_modules/bluebird/js/release/promise.js:612:10)
0|build    |     at Promise._settlePromises (/home/ubuntu/butler-bot/node_modules/bluebird/js/release/promise.js:687:18)
0|build    |     at Async._drainQueue (/home/ubuntu/butler-bot/node_modules/bluebird/js/release/async.js:133:16)
0|build    |     at Async._drainQueues (/home/ubuntu/butler-bot/node_modules/bluebird/js/release/async.js:143:10)
0|build    |     at Immediate.Async.drainQueues (/home/ubuntu/butler-bot/node_modules/bluebird/js/release/async.js:17:14)
0|build    |     at runCallback (timers.js:651:20)
0|build    |     at tryOnImmediate (timers.js:624:5)
0|build    |     at processImmediate [as _immediateCallback] (timers.js:596:5)

Repro

1. /book
2. Any room
3. Select date
4. Select time
5. Press Back
6. Error pops up

[Critical] Unable to handle recurring events

1. /booked & /delete command unable to display the latest upcoming booking for recurring bookings. (Recurring bookings are booked directly through google calendar)
2. unable to detect new bookings' conflicts with recurring bookings.

To handle recurrences and calculate upcoming event in the series, with the start, end and recurrence resp from google.

[ { kind: 'calendar#event',
    etag: '"..."',
    id: '....',
    status: 'confirmed',
    htmlLink: '...',
    created: '2017-02-08T03:13:06.000Z',
    updated: '2017-02-08T06:23:06.853Z',
    summary: 'Meeting by ..',
    location: 'FGD',
    creator: { email: '...' },
    organizer: 
     { email: '[email protected]',
       displayName: 'FGD Calendar',
       self: true },
    start: 
     { dateTime: '2017-02-24T14:00:00+08:00',
       timeZone: 'Asia/Singapore' },
    end: 
     { dateTime: '2017-02-24T15:00:00+08:00',
       timeZone: 'Asia/Singapore' },
    recurrence: [ 'RRULE:FREQ=WEEKLY;UNTIL=20170331T060000Z;BYDAY=FR' ],
    ... } ]

Contribute command does not work

/contribute does not work. is it even necessary?

December Calendar

Unable to book room for the month of November. Today is 31 Oct

How to Use This Package?

Excuse my stupidity, but I'm absolutely has no clue about how to use this package or how to install it. Do I just download it as a ZIP and then copy+paste it to my server (i'm using windows) or do I have to some serials of commands just like you shown here? And then where do I have to put it my webhook URL?

Thank you

Include new meeting rooms

Just curious if GCals are created for new meeting rooms?

Wrong URL provided after booking confirmed

wrong URL provided after booking confirmed. recommend to use constant for URL since it is in multiple messages.

Able to allow admins to remove users who left

Requested by SweeZharBo herself.

Possibly under /manage, can list users and a button to ban them. or a new function /ban to ban users

LDAP integration

We can create a mapping between telegram usernames and LDAP entries and do even more cool stuff, like using the google cal API to send an event/invite to tech.gov.sg emails on bookings.

We can either:

1. map it ourselves
2. get users to auth with the bot before using to create the mapping on the backend (we've to write it ourselves)

Right now I'm trying to find out if we can have remote access to the LDAP server (sitting on a AWS VPC) from an ec2 instance...